Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S274986AbTHSQSi (ORCPT ); Tue, 19 Aug 2003 12:18:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270754AbTHSQQF (ORCPT ); Tue, 19 Aug 2003 12:16:05 -0400 Received: from zeus.kernel.org ([204.152.189.113]:53499 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S271118AbTHSQNM (ORCPT ); Tue, 19 Aug 2003 12:13:12 -0400 Subject: Re: [PATCH] RFC: kills consistent_dma_mask From: Alan Cox To: Jes Sorensen Cc: Pete Zaitcev , Krzysztof Halasa , Linux Kernel Mailing List In-Reply-To: References: <20030818111522.A12835@devserv.devel.redhat.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1061298438.30566.29.camel@dhcp23.swansea.linux.org.uk> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.3 (1.4.3-3) Date: 19 Aug 2003 14:07:18 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 16 On Maw, 2003-08-19 at 10:03, Jes Sorensen wrote: > That would be totally messy. Having drivers do the accounting of what > mask is currently set and have them switch back and forth depending on > what type of allocation is currently being used would be a nightmare > to debug. It is messy, but the consistent mask only helps a small subset of cases. Having an __pci_alloc_foo that took the mask as an argument is (a) trivial (b) adds almost no code (c) solves the general case problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/