Received: by 10.192.165.156 with SMTP id m28csp1146415imm; Fri, 13 Apr 2018 14:12:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+/DO3V2an3yfxPYoVP3uWhsXjiNAmD1MUHV87IVpNloq+l7L4zVZhfWHRNdjpJoO3fOUqR X-Received: by 10.101.64.129 with SMTP id t1mr5339451pgp.173.1523653962545; Fri, 13 Apr 2018 14:12:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523653962; cv=none; d=google.com; s=arc-20160816; b=dgIA+oxlPEqrCS8AfQyRLY73Ct0401C/tU2uHp3fhSq+sA6bCerCpN9xy7GGDgfmcv lAV7lYKoRp8BK99abjdrQuHcWPiFoxfmbwtTme0P1KbLnwUlEp7LlTdPndFbC1ZzIZca 8dWd3OvMNA5CaeSX43ifOWhLZVet3YXlNSJtFpnC9ZnEzV7z5WYTd8x3d5H5/avJabTL ZhlUGv3R3w26VLqejp3c4IkhwlVaxnPGqX46jpz4/fiNpqrUC156Vtf1S5+yv8MUZ83l /TklDpLMFTsQIfxXZeAw644465+H54ltjdmPQKzWFFi/M5lHZd+XPXpJDAjnkQEy90PO VKOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=1mU9E/pWXBPIN4bd5Ned0rgGxfXuaglJuTUKEPnNq6Q=; b=iGwAMlpW2A4GL6khaC+PIXoG9Te7B7cThHtswPGJYTLz/hscVHe5yVKnHybznHe63K zm9elRVCxrjrCOzS5S7MmZEcR/w4tHRGkmdgc8XBIMmiLyj3qapAMAVa1ZW6ohNJ7UYa frFf8xjmjUqjkiRKGFH0Hu2OqeRqVAQ21a6RCoqflBs45FIouvPWD23cpzM/r0tWapAF GWIdGi1XPJOXI119aOgQ6E9IA4BGj+iAlxH4DM97yULi9e50L761aKGjY30gtekMvBit 8kRoAXr9+8Ppx9jccR2aGzGjF0yY64t0oI8CE1yFgJFJkYO+QAcUixe7kwvAK0RD1zLN Dhxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p16si3459524pgd.640.2018.04.13.14.12.28; Fri, 13 Apr 2018 14:12:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbeDMVLM (ORCPT + 99 others); Fri, 13 Apr 2018 17:11:12 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33063 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbeDMVLK (ORCPT ); Fri, 13 Apr 2018 17:11:10 -0400 Received: by mail-oi0-f68.google.com with SMTP id 126-v6so9585523oig.0; Fri, 13 Apr 2018 14:11:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1mU9E/pWXBPIN4bd5Ned0rgGxfXuaglJuTUKEPnNq6Q=; b=b7+OvH93iciDChzCZKt9pTN3t5bk8ECC7rvvsBvJYJLiMASQgev5gjhu1fcdF8wmYA IagVQv4V273Z9MGw6Sha5wH4ZnyO64lRYTdQ+m87aHoJGPbUxD1uKxMYCy9rMyf+iswX 2tgy1Ee/sFGiuMhJXIKO0tZc6Pb4pjhM9xx1udJRdoNS5P+vgBVvpqf+yi77PJNBxlqA qmDRmIqmHtI5R6S7qN2y6IgcCyN15wj4Zp0nAGTc7lRrz00gJC3BBYCaCxxAveivbKgf JzsPdEo3xLH+btsxT+i2y+2v3FkFpOSlzNOB5eJDmceIlAun/Zpoh8AbGLtmVLqIhOyy EWOg== X-Gm-Message-State: ALQs6tCXu6YsREY3XMv9V88pbDRaGqutwIf7OqyM3fiwzbIUVzokYnfM BTuRn6c7fblXW4QqA/nsag== X-Received: by 2002:aca:af87:: with SMTP id y129-v6mr9735579oie.83.1523653870215; Fri, 13 Apr 2018 14:11:10 -0700 (PDT) Received: from localhost (216-188-254-6.dyn.grandenetworks.net. [216.188.254.6]) by smtp.gmail.com with ESMTPSA id q33-v6sm5753005otq.78.2018.04.13.14.11.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Apr 2018 14:11:09 -0700 (PDT) Date: Fri, 13 Apr 2018 16:11:09 -0500 From: Rob Herring To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexandre Belloni , Dmitry Torokhov , linux-input@vger.kernel.org, Nicolas Ferre , Nick Dyer , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Input: atmel_mxt_ts - add missing compatible strings to OF device table Message-ID: <20180413211109.scyuwx7gptutvon4@rob-hp-laptop> References: <20180410095340.24074-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410095340.24074-1-javierm@redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 10, 2018 at 11:53:40AM +0200, Javier Martinez Canillas wrote: > Commit af503716ac14 ("i2c: core: report OF style module alias for devices > registered via OF") fixed how the I2C core reports the module alias when > devices are registered via OF. > > But the atmel_mxt_ts driver only has an "atmel,maxtouch" compatible in its > OF device ID table, so if a Device Tree is using a different one, autoload > won't be working for the module (the matching works because the I2C device > ID table is used as a fallback). > > So add compatible strings for each of the entries in the I2C device table. > > Fixes: af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF") > Reported-by: Enric Balletbo i Serra > Signed-off-by: Javier Martinez Canillas > --- > > Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 6 +++++- > drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++++ > 2 files changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring