Received: by 10.192.165.156 with SMTP id m28csp2746724imm; Sun, 15 Apr 2018 08:09:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx48qtIOY70qlmxrFXGaAV1y7LlmVnvLkFAnvr7v8YgGO3HwS/KAMdzDe3WmIjMdANNc7enTl X-Received: by 10.101.68.72 with SMTP id e8mr3562428pgq.56.1523804942332; Sun, 15 Apr 2018 08:09:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523804942; cv=none; d=google.com; s=arc-20160816; b=XDVTxYVNqGfFPeOkDhphAWr8mdEwVkEraE1Ok1p+rqM73saUVqvAbg8CC/VDPKnbw7 OmgPO9ZEs7/Xm9OoFNEJFuESF40yCwbeio4eUMMKYO4Va4Q1F3xGnDaNWIW3aX1Bn7o1 HaExX+4gnNddhs1oD5FqdMPQHN4/+mqMpNikqwGTOFFl2zCDAnPPO94ZmX+fMN21Ic/9 AvVDMwRcJgy66Y7hNBy56mJE1B9hoN8rzRPg18HM0hALtpA5PUxZiVqCaJbAvOyJQe97 Ue6vG/5RbLirEaogT96ZdIna1mn7/s9ShnJr9NWdTj1rOJL7oHotLlZxLx+s/oGoms80 zOaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dmarc-filter:arc-authentication-results; bh=0KaR3/LenkD49YvxdYLmpb+ze5cF84rs7k46s8elrTM=; b=woWscTCuffDNQn8W45yEqsC234G7ygkAveYZD+gcGlgjxp3V9STKT2809DRhic5Eq6 GqFakH+AG0/TYkgSctmT70fmPlDqfJFjATqPovvvMBUQf+sdzzPk8iUfUytMdV5zYEoA vaW9nVnD3dGvKiqpWi15a6gu1gMH060yrFpqc61DjYPVkS+zgf+St+cSUZf72PG4tYi/ 4O2PgRUCQEzljooALI3thIueaHQTroQ6pK/IwW8tZcaykk/rV/Z+doglnaFechifvR9k PJYrXoDGXfdUTVdm+uLYFWb+y2JMYSXV4MC+qSXFAgTtcjkGUZ09dkEXINyFL7EioN52 Sbfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f34-v6si10261793plf.362.2018.04.15.08.08.48; Sun, 15 Apr 2018 08:09:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbeDOPHn convert rfc822-to-8bit (ORCPT + 99 others); Sun, 15 Apr 2018 11:07:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:38510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399AbeDOPHl (ORCPT ); Sun, 15 Apr 2018 11:07:41 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 397E420779; Sun, 15 Apr 2018 15:07:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 397E420779 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 15 Apr 2018 16:07:36 +0100 From: Jonathan Cameron To: =?UTF-8?B?SGVybsOhbg==?= Gonzalez Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/14] staging: iio: ad7746: Fix multiple line dereference Message-ID: <20180415160736.2195142b@archlinux> In-Reply-To: <1523637411-8531-5-git-send-email-hernan@vanguardiasur.com.ar> References: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> <1523637411-8531-5-git-send-email-hernan@vanguardiasur.com.ar> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Apr 2018 13:36:41 -0300 Hernán Gonzalez wrote: > Clear checkpatch.pl WARNING about multiple line derefence but creates a > new one of line over 80 characters. In my opinion, it improves > readability. > > Signed-off-by: Hernán Gonzalez I wouldn't say I personally have strong views either way on this, but your version is fine so I'll apply it. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7746.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > index d793785..82fac76 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -410,8 +410,7 @@ static struct attribute *ad7746_attributes[] = { > &iio_dev_attr_in_capacitance1_calibbias_calibration.dev_attr.attr, > &iio_dev_attr_in_voltage0_calibscale_calibration.dev_attr.attr, > &iio_const_attr_in_voltage_sampling_frequency_available.dev_attr.attr, > - &iio_const_attr_in_capacitance_sampling_frequency_available. > - dev_attr.attr, > + &iio_const_attr_in_capacitance_sampling_frequency_available.dev_attr.attr, > NULL, > }; >