Received: by 10.192.165.156 with SMTP id m28csp2788262imm; Sun, 15 Apr 2018 09:06:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx498xfr9A+l8CIspZznmAS4plFEUXSbIPAu9p1Cm54ZB2QRGAtokMVda8Dak8dFFHp9Drfdb X-Received: by 10.101.100.13 with SMTP id a13mr5025433pgv.360.1523808367413; Sun, 15 Apr 2018 09:06:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523808367; cv=none; d=google.com; s=arc-20160816; b=JxkIbUIPJWRsOX2P219TT3PFi9WAiicF/bm+iV6ok+eR8gWaSzjc9FePconmJOxyF5 XLObN37QVp3vJQFYjNk1HqscsZ76CJK6Zrz0wSgY2SuY9qcQOFGI1UQBdviOqTxVtFrj RPZlM02dyhU5x38rYg4cNt5zDSAjFXP/y8M7HeMEhWQ9Xlj1n5Re4BeB7FjdimDvvFdV K4iPQLjFbLAxEwbMXY+mk22JANl6PgQ+zrKSpVANT5Zqfv6WleLWcdgNkhKe6Zx+nV3N h7VLr5PCFtNsi1VieN7FuPP+S81v8NWSuCsUfHHU4O/+TH9bOdPktT9ljKR4gkjqj8dZ zyQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=YzDGPFYmc3D3nrjxaXFVvIZuGVCM/N+fTk9RPU/y154=; b=iu7AMaaXLV9n1zwPL0ieW9gY30Zd8e78i0PCaFujdgqG8S4GgsbdQJS4YFCjOXsr9W 0p4Ex/RgsmPhKuMgVbgNp4+HSxL0FzFx/Di2VlZqD0bcbXCP3Q+JhyriAuXXowWx4XUH lAxs981clTtmMP16ZOLB2R8QLLgOpEeIqc3lnIYKEKMuZl0FXvf9tSMm2KPPY8U5Fonj 8NGB/6I4GM5cr7yopxUAFu5KFzq6oKbGY6W71rdu3jOjgFUEoFKtit7/RdzsyCxMzXP1 CiZCM8i7fcwGBNVULW5rHpT226nkFO7gXQDHelJpY2IT8dBYaLDDL8sLWAgbley2QfI9 v61g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=Vm7TN8wq; dkim=fail header.i=@chromium.org header.s=google header.b=g8w9jnsZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3si8560924pfe.255.2018.04.15.09.05.53; Sun, 15 Apr 2018 09:06:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=Vm7TN8wq; dkim=fail header.i=@chromium.org header.s=google header.b=g8w9jnsZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbeDOQEs (ORCPT + 99 others); Sun, 15 Apr 2018 12:04:48 -0400 Received: from mail-ua0-f171.google.com ([209.85.217.171]:33348 "EHLO mail-ua0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbeDOQEr (ORCPT ); Sun, 15 Apr 2018 12:04:47 -0400 Received: by mail-ua0-f171.google.com with SMTP id q26so8615884uab.0 for ; Sun, 15 Apr 2018 09:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YzDGPFYmc3D3nrjxaXFVvIZuGVCM/N+fTk9RPU/y154=; b=Vm7TN8wqawDQPbnEM8xZlhJEKvUgCaBmzlSikqhk6f5TCBIEzOMh5oOmChBR4twKlA 5sWGJX1Vz3glxyndQ+WIQBBLbX6soQd3BYPAxjw6fwtrmWcCnG7Zkih9atZG2beSg4zI cII7FKfaqOgM818tdBVHPKVCEUPeig6YOBXI73Ilj0Uef+/XHE8RLuOpZyfPFomsm4P3 WjsBveagBVw79cbO/k5PE+ePwkz7PnTmipmhyvz/wDmQxF8gEakG1zq9Q9vpi3p4mlBJ LpWQS0ZSzrTdPYU4dx00zPwmxNKdpC0GQO+3jbBD/rrKs16xh4T8vVoJ0EYZegUWRLZz X6fQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YzDGPFYmc3D3nrjxaXFVvIZuGVCM/N+fTk9RPU/y154=; b=g8w9jnsZ9xomMXrYavRSb4FUBhWKR+zsfEGEylWudQypMhMiUNqO+3y7rXmA6Mf18F 9oHSdb1f1MsECiMv4XzuXlkqzlUv1ZsJQ7oDHFoM79XXKl18vwZR9e/G4i1wgFvYBXiz bSD1b0MD5BAVfT8XyfVrzlRwytDDy8UvZQDLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YzDGPFYmc3D3nrjxaXFVvIZuGVCM/N+fTk9RPU/y154=; b=VFGrxN7HiDjq3VAPMMUuo0lEs+Ox9dH4cf10OjrD/iDKakjW4Zckv13tndA1S5CnVT BOAERzmmavov9QklNl1xa09Fh9Ta34zcv33s3jTshUGTTrJmFw98voJ0YM6Dcohw/q+O T2w7wnofm05b4GwHGhsyL3sqhFt/jT/uFXxNEFfqzOzcAf7rcTa7rj60wRCj9sLGZ9yV y931NuwilmqKhu/dVK2MN4Me7Pcf+YCNIW9AZmdrYHWR2ssq9AR8AXyBtOrqY/h2Y3iZ WB3ibz2IfiMe98EGWGbwLeTcD0Do8YUCFIH0cEW7fX3bxdC6+WmhNDIx+tkW8OMmCR7s GyyA== X-Gm-Message-State: ALQs6tAHS4w9FtgwTDCIKZhzDxQNG0As19OWshddVFehCxjBncGhH+Xp foVfarPnTFrzQ2SvoZyyvX4ZDQ4SHevZ2/wWYMSt9g== X-Received: by 10.176.78.167 with SMTP id l39mr9649209uah.193.1523808286158; Sun, 15 Apr 2018 09:04:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.164.81 with HTTP; Sun, 15 Apr 2018 09:04:44 -0700 (PDT) In-Reply-To: References: <1523595999-27433-1-git-send-email-yamada.masahiro@socionext.com> <1523595999-27433-22-git-send-email-yamada.masahiro@socionext.com> From: Kees Cook Date: Sun, 15 Apr 2018 09:04:44 -0700 X-Google-Sender-Auth: qZIHZPYiIn_eMnGnDtkorRMDQ7I Message-ID: Subject: Re: [PATCH 21/30] stack-protector: test compiler capability in Kconfig and drop AUTO mode To: Masahiro Yamada Cc: Linus Torvalds , linux-kbuild , Sam Ravnborg , Ulf Magnusson , Nicholas Piggin , Emese Revfy , X86 ML , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 15, 2018 at 6:28 AM, Masahiro Yamada wrote: > In my Makefile ... > > stackp-flags-$(CONFIG_CC_HAS_STACKPROTECTOR_NONE) := -fno-stack-protector > stackp-flags-$(CONFIG_CC_STACKPROTECTOR) := -fstack-protector > stackp-flags-$(CONFIG_CC_STACKPROTECTOR_STRONG) := -fstack-protector-strong > > KBUILD_CFLAGS += $(stackp-flags-y) > > the last one is picked. Ah! Yes, sorry for the noise. I see the := instead of += now. Thanks! -Kees -- Kees Cook Pixel Security