Received: by 10.192.165.156 with SMTP id m28csp87607imm; Sun, 15 Apr 2018 17:47:15 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+IYOWfgTY+5UWKFYscHLosVHGbrqsatcaKg2w21eVXnRukyxx3kD7s42OTEhZ9gHdR/3LK X-Received: by 2002:a17:902:be08:: with SMTP id r8-v6mr13161837pls.289.1523839635177; Sun, 15 Apr 2018 17:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523839635; cv=none; d=google.com; s=arc-20160816; b=xgZxB0JR2GrJXA5zMhE2HXHSapvtzh4xl662zrgwtDxqPdltnn22n5ZuSUwa74PDxO +q0jTd6PFhXV40XvucRxm/yO2jFFcSHP8PryfInn2lk5XiV6fs1VFHNDWXRRYx0GF84V 5aKJkZcmtu/iTV9+TPp+0zUeDPZ+YKDN5YgSt2X0O7+mviNS5b2u1WA2qxxJjcenwnHa iCajoEnxkY5s3PLrY+nnG0CIZqHs8HEvBJFg/3ARJi1IsNFLalH2V4FxUCNdZp9oatOZ LL2dO85F2HWtjKDbl9WAuz2OXwF80uFTI9YkFKKqOYJJV8XdcWT0OLwIdNDsFXPz3y1I tWYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:cc:subject:date:to :from:arc-authentication-results; bh=YQSIxon5YnGKxXypyNszR5IdIdHnPUYtsNG6LyC/kck=; b=FD76Oc1D2aQh+oYT96n/dOoT2reUF1EKbONRwnxcOO3HQaEfbhS+MXgL3NFPsD6xnV vpaTJaYzWNW/unGE1A2gKD5H0BcF4gJmywabWJBGIE93gRPTygu76E+27DbcGx1CKAib v08fj312VSxbj+dOnY8f+lviAS4Tc5uNGBmzuYIWh09qNmoyKZgdI83PP9dpF2Va2Rda WzzX9slN5ofAK8DWx0EK2Td++ihtNZy17RGkowFOh/LKnepJzrekfrPKttELGeAl9Lpi TE3XGRvu9JGYa3OFBbv+TAsoVXHAEmIB8VuzXzA9HmBsQJoZT/htoAFfpHFgQpD+eJ4I 8eyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1si8612186pgs.132.2018.04.15.17.46.27; Sun, 15 Apr 2018 17:47:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbeDPAnZ (ORCPT + 99 others); Sun, 15 Apr 2018 20:43:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:42470 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbeDPAnW (ORCPT ); Sun, 15 Apr 2018 20:43:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DF14FAC1D; Mon, 16 Apr 2018 00:43:20 +0000 (UTC) From: NeilBrown To: Oleg Drokin , Greg Kroah-Hartman , James Simmons , Andreas Dilger Date: Mon, 16 Apr 2018 10:42:37 +1000 Subject: [PATCH 3/6] staging: lustre: remove include/linux/libcfs/linux/linux-cpu.h Cc: Linux Kernel Mailing List , Lustre Development List Message-ID: <152383935737.23409.2271901486597092772.stgit@noble> In-Reply-To: <152383910760.23409.2327082725637657049.stgit@noble> References: <152383910760.23409.2327082725637657049.stgit@noble> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This include file contains definitions used when CONFIG_SMP is in effect. Other includes contain corresponding definitions for when it isn't. This can be hard to follow, so move the definitions to the one place. As HAVE_LIBCFS_CPT is defined precisely when CONFIG_SMP, we discard that macro and just use CONFIG_SMP when needed. --- .../staging/lustre/include/linux/libcfs/libcfs.h | 1 .../lustre/include/linux/libcfs/libcfs_cpu.h | 33 ++++++++ .../lustre/include/linux/libcfs/linux/linux-cpu.h | 78 -------------------- drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c | 4 + 4 files changed, 35 insertions(+), 81 deletions(-) delete mode 100644 drivers/staging/lustre/include/linux/libcfs/linux/linux-cpu.h diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h b/drivers/staging/lustre/include/linux/libcfs/libcfs.h index e59d107d6482..aca1f19c4977 100644 --- a/drivers/staging/lustre/include/linux/libcfs/libcfs.h +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs.h @@ -78,7 +78,6 @@ #include #include #include -#include #include #include diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h index 61bce77fddd6..829c35e68db8 100644 --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h @@ -72,10 +72,43 @@ #ifndef __LIBCFS_CPU_H__ #define __LIBCFS_CPU_H__ +#include +#include +#include + /* any CPU partition */ #define CFS_CPT_ANY (-1) #ifdef CONFIG_SMP +/** virtual processing unit */ +struct cfs_cpu_partition { + /* CPUs mask for this partition */ + cpumask_var_t cpt_cpumask; + /* nodes mask for this partition */ + nodemask_t *cpt_nodemask; + /* spread rotor for NUMA allocator */ + unsigned int cpt_spread_rotor; +}; + + +/** descriptor for CPU partitions */ +struct cfs_cpt_table { + /* version, reserved for hotplug */ + unsigned int ctb_version; + /* spread rotor for NUMA allocator */ + unsigned int ctb_spread_rotor; + /* # of CPU partitions */ + unsigned int ctb_nparts; + /* partitions tables */ + struct cfs_cpu_partition *ctb_parts; + /* shadow HW CPU to CPU partition ID */ + int *ctb_cpu2cpt; + /* all cpus in this partition table */ + cpumask_var_t ctb_cpumask; + /* all nodes in this partition table */ + nodemask_t *ctb_nodemask; +}; + /** * return cpumask of CPU partition \a cpt */ diff --git a/drivers/staging/lustre/include/linux/libcfs/linux/linux-cpu.h b/drivers/staging/lustre/include/linux/libcfs/linux/linux-cpu.h deleted file mode 100644 index 6035376f2830..000000000000 --- a/drivers/staging/lustre/include/linux/libcfs/linux/linux-cpu.h +++ /dev/null @@ -1,78 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * GPL HEADER START - * - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 only, - * as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License version 2 for more details (a copy is included - * in the LICENSE file that accompanied this code). - * - * GPL HEADER END - */ -/* - * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. - * Copyright (c) 2012, Intel Corporation. - */ -/* - * This file is part of Lustre, http://www.lustre.org/ - * Lustre is a trademark of Sun Microsystems, Inc. - * - * libcfs/include/libcfs/linux/linux-cpu.h - * - * Basic library routines. - * - * Author: liang@whamcloud.com - */ - -#ifndef __LIBCFS_LINUX_CPU_H__ -#define __LIBCFS_LINUX_CPU_H__ - -#ifndef __LIBCFS_LIBCFS_H__ -#error Do not #include this file directly. #include instead -#endif - -#include -#include -#include - -#ifdef CONFIG_SMP - -#define HAVE_LIBCFS_CPT - -/** virtual processing unit */ -struct cfs_cpu_partition { - /* CPUs mask for this partition */ - cpumask_var_t cpt_cpumask; - /* nodes mask for this partition */ - nodemask_t *cpt_nodemask; - /* spread rotor for NUMA allocator */ - unsigned int cpt_spread_rotor; -}; - -/** descriptor for CPU partitions */ -struct cfs_cpt_table { - /* version, reserved for hotplug */ - unsigned int ctb_version; - /* spread rotor for NUMA allocator */ - unsigned int ctb_spread_rotor; - /* # of CPU partitions */ - unsigned int ctb_nparts; - /* partitions tables */ - struct cfs_cpu_partition *ctb_parts; - /* shadow HW CPU to CPU partition ID */ - int *ctb_cpu2cpt; - /* all cpus in this partition table */ - cpumask_var_t ctb_cpumask; - /* all nodes in this partition table */ - nodemask_t *ctb_nodemask; -}; - -#endif /* CONFIG_SMP */ -#endif /* __LIBCFS_LINUX_CPU_H__ */ diff --git a/drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c b/drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c index 76291a350406..5818f641455f 100644 --- a/drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c +++ b/drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c @@ -37,7 +37,7 @@ struct cfs_cpt_table *cfs_cpt_table __read_mostly; EXPORT_SYMBOL(cfs_cpt_table); -#ifndef HAVE_LIBCFS_CPT +#ifndef CONFIG_SMP #define CFS_CPU_VERSION_MAGIC 0xbabecafe @@ -225,4 +225,4 @@ cfs_cpu_init(void) return cfs_cpt_table ? 0 : -1; } -#endif /* HAVE_LIBCFS_CPT */ +#endif /* CONFIG_SMP */