Received: by 10.192.165.156 with SMTP id m28csp211095imm; Sun, 15 Apr 2018 21:17:58 -0700 (PDT) X-Google-Smtp-Source: AIpwx48Q4Xc2htKF28axHK40AOipzupxVxPo5s71/WZDzhKXDDXnQHUxIBSrz5hj+REH0/otgRBp X-Received: by 10.99.165.79 with SMTP id r15mr1542920pgu.236.1523852278476; Sun, 15 Apr 2018 21:17:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523852278; cv=none; d=google.com; s=arc-20160816; b=rNZ1husWrOhSpWFoeeAslyG0hxe+hkBNJ5tLcK3Y0FaWodSXOFX2V9uVy49zjfZPV0 Jtn7RoIIoYcsmRy0yE6b5S4S3BVQtXChbcTLP1NbEdNAQHh3c/c0c6+068skOExAeDer QWR8qRuoDFHr+Lfo/SCbbnW1gDbkssTTFhOQBYR3q7PdSeMJ42aQMOP2xC3NJV/jfziN 6KbHZh0Y39zDn3eWeyrbTYJtl3ZM15l+s+e3ksxx2u8KfifAAQIB3ggj6CBBKzQEeqPW OFBMcESdYzh62Iqy7cMFzfyTiAoz16d6uGlyDumn/NSGPFSXYioF2YkzacyyMWZ2W98k Kw+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=e/5suxv9b6JO8peHcckvsEYJGn1DHcSNhfZQfbjRBmM=; b=j6sWszpZQwM8o5RraiXpu+R01ibfoE5ZmaEwG0l38Cg2983imRYAZf/ct7BOm4uc49 3dl3eS97R/hrPBpvXBV9SGXSewM6jQ6k8yVc7PbbhpeBGUORaKPIVMdkGEeHpkmXrvct JH83sVcmkZ4ESn/G1oDUB7VeL6aMy2cCYcbTDMB6JtDAUb5GIKAU250OIWuC2l/tF8tB 93NBgNsl4tAyOlgSmQRjkoGwGtdOqsjBClGsrI79Sg4i73e2LTMUgDrBI6EqoipJAYwM i2+Q4wD28Z84vy+k3kZjlbp6lcuvpzWfANkVSqKr2kR2mf6IlAVT+VOtDOeYH1FE8J+N pnHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si8719078pgg.395.2018.04.15.21.17.44; Sun, 15 Apr 2018 21:17:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832AbeDPEPc (ORCPT + 99 others); Mon, 16 Apr 2018 00:15:32 -0400 Received: from smtp4.ccs.ornl.gov ([160.91.203.40]:35548 "EHLO smtp4.ccs.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749AbeDPEP3 (ORCPT ); Mon, 16 Apr 2018 00:15:29 -0400 Received: from star.ccs.ornl.gov (star.ccs.ornl.gov [160.91.202.134]) by smtp4.ccs.ornl.gov (Postfix) with ESMTP id E49A3100519E; Mon, 16 Apr 2018 00:15:12 -0400 (EDT) Received: by star.ccs.ornl.gov (Postfix, from userid 2004) id E22E71F3; Mon, 16 Apr 2018 00:15:12 -0400 (EDT) From: James Simmons To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , NeilBrown Cc: Linux Kernel Mailing List , Lustre Development List , James Simmons , James Simmons Subject: [PATCH 17/22] staging: lustre: llite: cleanup xattr code comments Date: Mon, 16 Apr 2018 00:15:06 -0400 Message-Id: <1523852111-17321-18-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1523852111-17321-1-git-send-email-jsimmons@infradead.org> References: <1523852111-17321-1-git-send-email-jsimmons@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebastien Buisson Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index d6cee3b..835d00f 100644 --- a/drivers/staging/lustre/lustre/llite/xattr.c +++ b/drivers/staging/lustre/lustre/llite/xattr.c @@ -564,7 +564,7 @@ ssize_t ll_listxattr(struct dentry *dentry, char *buffer, size_t size) return rc; /* * If we're being called to get the size of the xattr list - * (buf_size == 0) then just assume that a lustre.lov xattr + * (size == 0) then just assume that a lustre.lov xattr * exists. */ if (!size) @@ -577,14 +577,14 @@ ssize_t ll_listxattr(struct dentry *dentry, char *buffer, size_t size) len = strnlen(xattr_name, rem - 1) + 1; rem -= len; if (!xattr_type_filter(sbi, get_xattr_type(xattr_name))) { - /* Skip OK xattr type leave it in buffer */ + /* Skip OK xattr type, leave it in buffer. */ xattr_name += len; continue; } /* * Move up remaining xattrs in buffer - * removing the xattr that is not OK + * removing the xattr that is not OK. */ memmove(xattr_name, xattr_name + len, rem); rc -= len; -- 1.8.3.1