Received: by 10.192.165.156 with SMTP id m28csp293399imm; Sun, 15 Apr 2018 23:29:09 -0700 (PDT) X-Google-Smtp-Source: AIpwx48KrMucRrnbHJAxr5Zbo/Curj1vYAUywCh8iHvTRH13kBaex4PUeGo2+TGITUMS7gQvlsca X-Received: by 10.98.99.4 with SMTP id x4mr20423575pfb.179.1523860149249; Sun, 15 Apr 2018 23:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523860149; cv=none; d=google.com; s=arc-20160816; b=wrOk4VYCRnZapVOxqGiEHySiqfSKn8f+9ImXNxq0mykthEB0gNJM69RqJpDg4qoCvy yNDnvZSYwSu0Xj3riUAXPZecaOzRP74yqH3Fscr+dUbXMKPctWe5F2k2BZp8a0kPkx2Q KfWI7/f4nI+hmVDSxcrM7xL23zFqyZyUPghKbdm9COZYEH0+flYuCyWVv7hzEvBGlPNN ooBEXiQDnYrzKlVZm6ROiLXSFx+nTIh54d2v2fWRL2gA+lybySbUfq4TVirsLbaMHMz+ YNpoH59CQXriffSiwg7b3ujR8ydNr4AlZIF60YLRN5IK6vrN6v4M1lcTgeOljPO5l+Cz 5NpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:mime-version:user-agent:date:organization:subject :from:cc:to:arc-authentication-results; bh=VCgo7x+bEMgP5QaUQa10jM0XJcQw0y9Qc2ANzOBRpe4=; b=Cw4SgM+h22KwAcBaIJWL0mTMi1yRkhkLtireFnlsdFaijFwk03YcU8trkPYSzXtz42 9wiayRTOoTJSS2ThbtEXqQfy67Q+5SDLmlkupucsXHAZY7Izx3sCnE5z+LOSoVy+FEnS ripx7/b7JGvaYikC2uVwUvm3fYes1HrxsiJPZ2M0rOp5nQ9ToqnYfUd3PCvKOssAe4aN lyEtAbRXdxFZgBuY+s3fAeOJd3bQmdZq0ajVJT49fvSuXAq0pxH7eo++sGEPqZ/Locjs U5qQbPhd7B8TVYmkYvmbj+5ygeLlomgG8mfGiOkA1KWBT2OgGAAKk20uMSQT54hAeQ5d DyOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4si1797365pgv.681.2018.04.15.23.28.55; Sun, 15 Apr 2018 23:29:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbeDPFvx (ORCPT + 99 others); Mon, 16 Apr 2018 01:51:53 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58810 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752982AbeDPFvw (ORCPT ); Mon, 16 Apr 2018 01:51:52 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3G5nmGl002584 for ; Mon, 16 Apr 2018 01:51:51 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hcdfjpwuk-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 16 Apr 2018 01:51:51 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Apr 2018 06:51:50 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Apr 2018 06:51:48 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3G5plBI52953148; Mon, 16 Apr 2018 05:51:47 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1BD9711C052; Mon, 16 Apr 2018 06:43:46 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DAE4111C04C; Mon, 16 Apr 2018 06:43:45 +0100 (BST) Received: from oc3784624756.ibm.com (unknown [9.152.212.204]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 16 Apr 2018 06:43:45 +0100 (BST) To: Christian Borntraeger , Linux Kernel Mailing List Cc: Martin Schwidefsky , Hendrik Brueckner , Heiko Carstens From: Thomas-Mich Richter Subject: Wrong module .text address in 4.16.0 Organization: IBM LTC Date: Mon, 16 Apr 2018 07:51:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18041605-0012-0000-0000-000005CB3D09 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041605-0013-0000-0000-000019477EFB Message-Id: <7e17e3b1-25c3-cb61-ae94-dcbb1bf3473e@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-16_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804160055 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I just installed 4.16.0 and discovered the module .text address is wrong. It happens on s390 and x86 platforms. I have not tested others. Here is the issue, I have used module qeth_l2 on s390 which is the ethernet device driver: root@s35lp76 ~]# lsmod Module Size Used by qeth_l2 94208 1 ... [root@s35lp76 ~]# cat /proc/modules | egrep '^qeth_l2' qeth_l2 94208 1 - Live 0x000003ff80401000 <---- This is the correct address in memory [root@s35lp76 ~]# cat /sys/module/qeth_l2/sections/.text 0x0000000018ea8363 <---- This is the wrong address [root@s35lp76 ~]# File /sys/module/qeth_l2/sections/.text displays a very strange address which is definitely wrong. It should be something like 0x000003ff80401xxx. Same on x86. I have checked file kernel/module.c function add_sect_attrs() and it calls module_sect_show() when the sysfs file is read. And module_sect_show() uses sprintf(buf, "0x%pK\n", (void *)sattr->address); and my sysctl setting should be correct: [root@s35lp76 linux]# sysctl -a | fgrep kernel.kptr_restrict kernel.kptr_restrict = 0 [root@s35lp76 linux]# I wonder if somebody else has seen this issue? Ideas how to fix this? Thanks -- Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294