Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Apr 2018 09:45:35 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Julia Lawall <julia.lawall@lip6.fr>
Cc:     Joel Stanley <joel@jms.id.au>, linux-aspeed@lists.ozlabs.org,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, Andrew Jeffery <andrew@aj.id.au>,
        kbuild-all@01.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: fix drm-get-put.cocci warnings
Message-ID: <20180416074535.GH31310@phenom.ffwll.local>
Mail-Followup-To: Julia Lawall <julia.lawall@lip6.fr>,
        Joel Stanley <joel@jms.id.au>, linux-aspeed@lists.ozlabs.org,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, Andrew Jeffery <andrew@aj.id.au>,
        kbuild-all@01.org, linux-arm-kernel@lists.infradead.org
References: <alpine.DEB.2.20.1804120752280.3559@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1804120752280.3559@hadrien>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
>  Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
>  drm_*_unreference() helpers.
> 
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
> 
> Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> tree:   https://github.com/shenki/linux drm-v1

This isn't an upstream tree (and the aspeed driver isn't in upstream
afaict), so no need for spamming mailing lists I think.

But thanks for doing all this, great motivation to put more of the drm
refactorings into cocci files.

Cheers, Daniel
> head:   9680ed7979d5d403c6bde36271a048d62c048180
> commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED
> GFX
> driver
> 
>  aspeed_gfx_drv.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
>  err_unload:
>  	aspeed_gfx_unload(drm);
>  err_free:
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
> 
>  	return ret;
>  }
> @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
> 
>  	drm_dev_unregister(drm);
>  	aspeed_gfx_unload(drm);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
> 
>  	return 0;
>  }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch