Received: by 10.192.165.156 with SMTP id m28csp379482imm; Mon, 16 Apr 2018 01:33:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx48hIV7Nx5DVanxtec8S9zxmTmKY8ouWFQxmhkvZ2dG2f8pDTzI7qvWIgnu7ApcDxCbjXrlD X-Received: by 2002:a17:902:128c:: with SMTP id g12-v6mr14224805pla.98.1523867592272; Mon, 16 Apr 2018 01:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523867592; cv=none; d=google.com; s=arc-20160816; b=lwouLOkDo9+jbeEWAqnUJfqlKRTQnfPnMzkSW/cjEjQFxoQa4NUEZwAGjFB/uPFlTM ANuDzGP3UjS2PQV8YiDPOC8jJKSj3Mlt99GTqDomFi/KLQis05j/8giCcJRRXj+tSZ8O 6d8pUCsA2hEnaBNt6YxoY09kldAnVaL72EfGb78lkHcLp7htmC2zizpXWWVbzSfkMmVz OnqyzNIt0DPGIRpGi/hYf/4Cwi0Cz+Z9e/aalc3s6CHQKPdJLmNkbxQlDBC6VxAUK98a p2Dp+hxiVEwvpJOi4TdrqDYRRiLXgvZMqdlXzhtsV+7FCRDwwXpLvM/s2Btp8w2F/1T3 IIJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=x9dDD2K/ACy8u0E93pZZ2/Ald+5tKSlHih9kzLohnX4=; b=jbAQNqNEj/au14NpFLGgXQZx+smp4GXvM07JgCuiy6pEzBuA0ivDa4PBglkkKZGF4g +s4MP1Voctoa/rCskjayhgyC3TX3+tukimTs0+0Pe87J+HRcfYHlLD5OlbLhe5xRYXzO on+wkiEyKFFGOuODdw1MsEQFRCKGF/FsGwryP6E42XSntF6vFFG6WTTkcQYySYgVc4id IL3pkRmuTISBj5wXVk5tLrW+zNEk/wYXSWwZCes+TSTXIJw5YVziPo2RvMYF0Q4zofNt p/cVI6EEExrKQjtzDS1SsO4+528XKoWNSgkvcFI23Nuaaq5TXqTc57El+Q6jwBXErDkX fh9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8-v6si10890674plt.254.2018.04.16.01.32.58; Mon, 16 Apr 2018 01:33:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbeDPI0b (ORCPT + 99 others); Mon, 16 Apr 2018 04:26:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40972 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbeDPI0a (ORCPT ); Mon, 16 Apr 2018 04:26:30 -0400 Received: from localhost (unknown [82.113.183.179]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E05DCD07; Mon, 16 Apr 2018 08:26:29 +0000 (UTC) Date: Mon, 16 Apr 2018 10:10:08 +0200 From: Greg KH To: Moritz Fischer Cc: atull@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Anatolij Gustschin Subject: Re: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state Message-ID: <20180416081008.GA31469@kroah.com> References: <20180415183308.31402-1-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180415183308.31402-1-mdf@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 15, 2018 at 11:33:08AM -0700, Moritz Fischer wrote: > From: Anatolij Gustschin > > If the driver module is loaded when FPGA is configured, the FPGA > is reset because nconfig is pulled low (low-active gpio inited > with GPIOD_OUT_HIGH activates the signal which means setting its > value to low). Init nconfig with GPIOD_OUT_LOW to prevent this. > > Signed-off-by: Anatolij Gustschin > Acked-by: Alan Tull > Signed-off-by: Moritz Fischer > --- > > Hi Greg, > > as discussed. Can you please take this bugfix for 4.17? > I rebased it against next. Is it also needed in any older kernel versions? thanks, greg k-h