Received: by 10.192.165.156 with SMTP id m28csp469375imm; Mon, 16 Apr 2018 03:31:55 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+0fVseKEJCsj5LHHohY0XclXwbIeT2hAQgOZbzrg9vmIMpxN1GV/c0T421TFSQ5qIzzfi7 X-Received: by 10.99.4.88 with SMTP id 85mr2786107pge.156.1523874715189; Mon, 16 Apr 2018 03:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523874715; cv=none; d=google.com; s=arc-20160816; b=AWrwx4pI5LjIXUXt1WamPRTUepyr3UgX4MU8t9E+z/QR0szbAKPP7Fh6ctjWC0Lo+3 O1HdD94iwBjneVf0NCDlgWugUDwmTTiZPeMqXDJJQzgUafo98EIzcjbbEcf/VC183EUz 80/VmHq6x6oYTg3CLC/y4wchV4KNUMiPBKtLqS85uGk7P8v6Q13JSfLjTLpXu8gUBtsg Et1yDic59CbwbrSsKBqvZEaOsvJkToRRbaw0t+Cnzt7472WXDxRhNect9q3iOOAlWlzb +T+XiAAZ8O0zq4CTXgQbizAIaiU+pdYlT837d4kxI+zCxNiBYnPPltChkmwrAGyMcFy/ J/0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ypcTtPijAa/0g+u4bmcJd2nceASy80dsLMMGqKiu/RM=; b=hir7R3G84zFLYE0+ZsjvvzGQLk92w2xLVjQan40T2acaXNbryqsYVvtFddkD8Az3MU WGS1uby/DEowr6D0BikUSJA2m9d4e/KKpZXUa3a+a4pWgR/p/7g1HN7gam27Zl8qVsNK p26xC1a0afWVLcKWCNgVA/Mf3TjRM2m7Wg2EK3a6/LrTrLyAKYOGrhr0wkrOQKbVAa+J S7i35WuEDduZZO8iLrhBiimqpow2RTr8wE+o/Q6MMb5nTJxbL+qx+gTF5SAjpV0uTl+b CQOWGa0rOMstAxx/G8FrPeGuKGy0QflWabnWBv1py9d0Ts8zQ+3Ci+OEFcte6v7+q9nw 78kQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7-v6si11564798plk.388.2018.04.16.03.31.41; Mon, 16 Apr 2018 03:31:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753AbeDPKaW (ORCPT + 99 others); Mon, 16 Apr 2018 06:30:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47426 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752201AbeDPKaV (ORCPT ); Mon, 16 Apr 2018 06:30:21 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BFF76EB703; Mon, 16 Apr 2018 10:30:20 +0000 (UTC) Received: from krava (unknown [10.43.17.145]) by smtp.corp.redhat.com (Postfix) with SMTP id 63C25111DCFA; Mon, 16 Apr 2018 10:30:18 +0000 (UTC) Date: Mon, 16 Apr 2018 12:30:17 +0200 From: Jiri Olsa To: Ravi Bangoria Cc: Masami Hiramatsu , acme@redhat.com, kstewart@linuxfoundation.org, tglx@linutronix.de, pombredanne@nexb.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, uneedsihyeon@gmail.com, kjlx@templeofstupid.com, ravi Bangoria Subject: Re: [PATCH 3/3] perf/buildid-cache: Support --purge-all option Message-ID: <20180416103017.GB23274@krava> References: <20180409110633.20767-1-ravi.bangoria@linux.vnet.ibm.com> <20180409110633.20767-4-ravi.bangoria@linux.vnet.ibm.com> <20180416182735.4399e94b3c7e6d190ec7dc3e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 16 Apr 2018 10:30:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 16 Apr 2018 10:30:20 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jolsa@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 16, 2018 at 03:10:40PM +0530, Ravi Bangoria wrote: > Hi Masami, > > On 04/16/2018 02:57 PM, Masami Hiramatsu wrote: > > On Mon, 9 Apr 2018 16:36:33 +0530 > > Ravi Bangoria wrote: > > > >> User can remove files from cache using --remove/--purge options > >> but both needs list of files as an argument. It's not convenient > >> when you want to flush out entire cache. Add an option to purge > >> all files from cache. > >> > >> Ex, > >> # perf buildid-cache -l > >> /tmp/a.out (8a86ef73e44067bca52cc3f6cd3e5446c783391c) > >> /tmp/a.out.1 (ebe71fdcf4b366518cc154d570a33cd461a51c36) > >> # perf buildid-cache -P -v > >> Removing /tmp/a.out (8a86ef73e44067bca52cc3f6cd3e5446c783391c): Ok > >> Removing /tmp/a.out.1 (ebe71fdcf4b366518cc154d570a33cd461a51c36): Ok > >> Purged all: Ok > > Hmm, for purging all caches will be done by > > > > $ rm -rf ~/.debug > > > > Are there any difference? > > No logical difference if you know it's ~/.debug where it goes. :) > I also used to do rm -rf earlier. > > This option is for a perf users. But I'm fine if it's not really needed. > Will drop it. I'd keep it.. as you said it could be configured at some other dir jirka