Received: by 10.192.165.156 with SMTP id m28csp546670imm; Mon, 16 Apr 2018 05:01:06 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+yYeXBqGKYsInHtmx1X6S4U4DK9PDU7QQykSrM8l7fZLhCMECP0gaehsaei4D0cyYV0XLv X-Received: by 2002:a17:902:d807:: with SMTP id a7-v6mr15574526plz.314.1523880066525; Mon, 16 Apr 2018 05:01:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523880066; cv=none; d=google.com; s=arc-20160816; b=DEyDIa07u/iM/hJlBOUfDlbl/GdsTfUxv4YIYN2girY/gwQcF8DOU5APkHPHBxIBHm D/ZDGiW4mVPllfVws/ZOGLvU0EIejaGbyxVQEn43oUeW/oFrjKiL7mw28L2GNloT0S0S z8gEWizedouzRCuzRGaPf78zotNNcjtaCsQpJ3FymVDI3yjTfcKMUKB4NCv35+kULuiH sxdJZRC1LO0g8fncUIh5g7TjTPJW9IpxWFdpDfO2DbsgSeMmVnlSqS9GIDgkeaNln7nS d9KqXAbRZ8eff4qnPb0ef0rlbMPU4uJGbjUprxxR5hNlvI6H1qBdFsGhJI+db13QsIb0 Vayg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=zWWcNAITyluVev0Jfmyf9NebzSL0Fsg9FudjNphemE8=; b=KUmYrP6gthNBb6y6FVbgnhPN2I4LJm8gCGeL8IXvUKuMeAbtC5WJaE33XbvJDkvLKV hhcR2aB5BcKN3nIJTgPpJ2GP7vThjLkH8dzrpiI2RbbzOqElhTrpiI3GIHsfxfq2Qq28 /fQegZOqBND3+c1H2sgO7mJj6B84vTjV7bTxq254wcwJQiKRLQn+P7r0Q6ILWRyN/2EV 1OMYDN1/AWroaELMts98sydsYtoCzxUp4eZU/OXpsvbloaAtzL9PiIbGOa0cuhkmHIgl jF8YgQUw3kgVJGvrAQuHb3XDGeQcEqSD8Sd99PE6SXX+bWIs0wyqX0zy4YxPFEwxlj19 q2oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8-v6si11868831plr.42.2018.04.16.05.00.48; Mon, 16 Apr 2018 05:01:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754351AbeDPJt6 (ORCPT + 99 others); Mon, 16 Apr 2018 05:49:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:56086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbeDPJt4 (ORCPT ); Mon, 16 Apr 2018 05:49:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 94E03AECE; Mon, 16 Apr 2018 09:49:55 +0000 (UTC) Date: Mon, 16 Apr 2018 11:49:54 +0200 (CEST) From: Jiri Kosina To: Robert Munteanu cc: Benjamin Tissoires , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard In-Reply-To: <20180411094953.12053-1-rombert@apache.org> Message-ID: References: <20180411094953.12053-1-rombert@apache.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Apr 2018, Robert Munteanu wrote: > Changelog: > > - v2: modifier keys work, some combinations are still troublesome > - v3: style cleanup, rebase on top of 4.14 > - v4: remove most debugging calls, make init info useful for user, > rebased on top of 4.15 > - v5: fix the HID descriptor as suggested by Benjamin Tissoires, > use existing USB vendor id, update comment style, add SPDX > license identifier, rename to hid-redragon, stop registering > two input devices, rebased on top of 4.16 This should contain the text that goes directly into the git commit changelog, therefore should instead contain something like "This adds a news driver for HW XX, that needs a specialized driver bacuse .... and things to specifically point out in implementation are ....". Could you please provide that, so that I can commit it? Thanks. -- Jiri Kosina SUSE Labs