Received: by 10.192.165.156 with SMTP id m28csp722486imm; Mon, 16 Apr 2018 07:43:09 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/QXDEHAUdCG6UfaMwlcZqww4uY4s0RHB3LHD/8lQLal5e8yJzbykXiKXtcK8TIEYOHTT/h X-Received: by 10.99.114.88 with SMTP id c24mr10562550pgn.453.1523889789048; Mon, 16 Apr 2018 07:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523889788; cv=none; d=google.com; s=arc-20160816; b=ZLtV7LkXZeF5lmIBbLSnzoIY+UJUi98ZMJwQhBcbyca/LT2LXpoxPgb1+NwlqfBzzk lC86KsqsC+QyRlAg9RFzZe0zr1Ur/q7PHqp5cPW2VPbuAJv5cCIOue9b3iI1r68MhHGf KKk3Nd8f9AKG3YBJJyGUo/wJYFCXof63/nLh9MHoCqT2unlMZqLkJctKojpXnbcF20hI tveDDtIW51lQ29a+HvbOxgPVLu2GJKs/9fYd3vJdK8fuYudL8zv05fd5vYIUmWCddfNs 5rovwwusGjqP/P9AXifKKzF/C/OpL9aOGKJSLUDhscm7lxw4LrqN++N9SIJWhD8u62Pk 6pbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=j3nETFHnmdAnqhiudjzHPqsMIxYc3TwYhXkwhqBbDPY=; b=MSSaA5xLhHEfuCabOMzET98UbVuWB4gARnWDORRIzD0oaT3yCNE+GTKhbZWGSL6MNw k/1mk9SlkBjtV+SQWQZwq8f2JAC9P75qxHo9znO+2K/1+nTq+Hg4pXHQZL8HkrDb6zlt y/cGiEjw8WF/2h+PjKB4xYJL3Lo1T+WpSPSbxqNw6criHc+tHmtgSuP153bq6F7DmYFQ aToXcUlxjBa5L4vcn0J4KmAZWs/ei3Lw4Q5BSxOkgeh97iEyP0sJ8KZzMlxyn+0mYrBT r+dWhuuhO9LlXCajSM3FWSq0NU0/bSctf0fM2dOYydn9UkSyDoxiVFYrAFTKSkhzp9QH HvSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RTLz0JE9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t12-v6si10197316ply.353.2018.04.16.07.42.55; Mon, 16 Apr 2018 07:43:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RTLz0JE9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751086AbeDPOiH (ORCPT + 99 others); Mon, 16 Apr 2018 10:38:07 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36233 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbeDPOiF (ORCPT ); Mon, 16 Apr 2018 10:38:05 -0400 Received: by mail-wr0-f196.google.com with SMTP id q13so23298915wre.3 for ; Mon, 16 Apr 2018 07:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=j3nETFHnmdAnqhiudjzHPqsMIxYc3TwYhXkwhqBbDPY=; b=RTLz0JE9vRuQshWP9mCP8bN/ek4v3BdsgLItO90MhLQ60nT18gojyf84I3jUmV6WOP ipDEYCh6aT62u2lA9HfxGbj1bIRm1mWgVJFPcqnP482fOvhq8c9uBO49cr3gEb0oXRt+ Qqs6SfDHmf3PFwSL6uwN49ZSbgvk5iDKBzpmw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=j3nETFHnmdAnqhiudjzHPqsMIxYc3TwYhXkwhqBbDPY=; b=THV4rSXYOwOyI5gCilssSCgJHFRZ21pJ7I6zcz/7apc0rDz84D5SDppJAI3VHc7a3t M7cxQYUZLHOOJHN8JBX0rQgNBUfEPmh389jg0DSw57wCuWqMX0VOZS3o783LWKm1p96B EGO3oY5ncALbm2R1RgsKgZ7doIl06fQnCS/+w4V7UpMRh9GPp5adWuq1dN6FV7uFZdTQ dkLVHECoZDEcjtoSWhuKDS7rmBtk+jVK2xrurN64nCWQSBvS0nIO5btm8zHd4LCcPpir nO/Kob9B6NBZpwYHEOUt8vP5uSkb/ZaXP8TdOzclB6LLu+OUJcXgbnRrqo0iyhkCwhk3 1tQA== X-Gm-Message-State: ALQs6tDnDup5uzjbTJQuFs1qi5xkiKSusBzySOJnHWh/clXzwfa/MsTZ Gq+iIOxUXBpfaS1E+pE94Tr1vQ== X-Received: by 10.223.160.91 with SMTP id l27mr10553318wrl.114.1523889484023; Mon, 16 Apr 2018 07:38:04 -0700 (PDT) Received: from dell ([2.27.167.70]) by smtp.gmail.com with ESMTPSA id w62sm7909789wmb.6.2018.04.16.07.38.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 07:38:03 -0700 (PDT) Date: Mon, 16 Apr 2018 15:38:01 +0100 From: Lee Jones To: Sebastian Reichel Cc: Sebastian Reichel , Milo Kim , Daniel Thompson , Rob Herring , Tony Lindgren , Jingoo Han , Mark Rutland , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCHv4 03/10] mfd: ti-lmu: use managed resource for everything Message-ID: <20180416143801.umzbwdmmiotnblxh@dell> References: <20180330172414.26575-1-sebastian.reichel@collabora.co.uk> <20180330172414.26575-4-sebastian.reichel@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180330172414.26575-4-sebastian.reichel@collabora.co.uk> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Mar 2018, Sebastian Reichel wrote: > This replaces all remaining unmanaged resources with device > managed ones, so that the remove function is no longer needed. > This makes the code slightly shorter and fixes two problems: > > 1. The hardware is disabled after the child devices have > been removed. Previously there was a potential race > condition. > 2. The hardware is disabled when mfd_add_devices fails > during probe. > > Signed-off-by: Sebastian Reichel > --- > drivers/mfd/ti-lmu.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog