Received: by 10.192.165.156 with SMTP id m28csp732339imm; Mon, 16 Apr 2018 07:53:38 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/i3wp0FMLix2EOOSccDFO9I8CJ/sW9a76J/Q8SYeo05uMLPpROrYl7vqEoUQXEMYz2ej0+ X-Received: by 10.98.252.149 with SMTP id e143mr5520748pfh.88.1523890418402; Mon, 16 Apr 2018 07:53:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523890418; cv=none; d=google.com; s=arc-20160816; b=qYqaDzv+MrqRLziEVCH1T4q43k2sRI9+ZTZaUGZUgCQHOYKBuVwl1fc5L61vQk8nlH q01JhQjjKaeE99+XKu6l4ytwNSpsj5NF1dWz1eZRnnwXprlSLJmHVuHu+Bl/FAP4AVOx yw+PXQIYNiXvYDMWGhopdo3eN+ZPQI4+Ng/FnP59dEvTM2kCMx5VtiP2cX381+Ig/2uR QjFSFnBXkw+iI0PtnH6mH0qeAZkW3Wu/niOBRWccuUh08Skpz9Qh8b/1zDLK+/rTiues OIeyBHgsCCiyXl3BNKXXulawVgOssTpfEb5JqXa+vivE86emqn4ENacV+uDP/g76KryD T0Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=ga60jGWxbPGmPD9XSjOHViw/czu3pVDQRuhnKiActa4=; b=Xj/DHzy72z7rHm0RQTECM7Gg6kLgHgtVq5PnLsYSQbKWTtAdYv2I8HNk8LWpzU7BSS 2k42fTcPtKqsxKTkQls3IhCcXYRx7EIz0hIqG9iRXgV0n3gNFhRzhgeWMVaZiM6dPAvN UczjOvKkkbSgUdiekv283rcoEVkG6wrBShhaTg0X2zA2rtvEA/JG//J/tedvBLQDR5X4 ysFHY+0s/WOhcN1e189yS1+2llFiu8qckiWw647+wh3V1CExiytwoAoFVmAQnpSXsJe5 So4mLsmS5gUhNVUUPZRjY9UTjQCCaXSPOoSA2DpCAyYSN3WujHUXF5l9lEP55QfDNBGS eprw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z73si9806110pgz.559.2018.04.16.07.53.24; Mon, 16 Apr 2018 07:53:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111AbeDPOvr (ORCPT + 99 others); Mon, 16 Apr 2018 10:51:47 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36698 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbeDPOvo (ORCPT ); Mon, 16 Apr 2018 10:51:44 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3GEpVYh140350 for ; Mon, 16 Apr 2018 10:51:43 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hcwa4a80m-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 16 Apr 2018 10:51:42 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Apr 2018 15:51:37 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Apr 2018 15:51:33 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3GEpWVt53215250; Mon, 16 Apr 2018 14:51:32 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3CD164203F; Mon, 16 Apr 2018 15:43:07 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89A5042047; Mon, 16 Apr 2018 15:43:06 +0100 (BST) Received: from oc3836556865.ibm.com (unknown [9.152.224.140]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 16 Apr 2018 15:43:06 +0100 (BST) Subject: Re: [PATCH v4 13/15] KVM: s390: configure the guest's AP devices To: Pierre Morel , Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1523827345-11600-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523827345-11600-14-git-send-email-akrowiak@linux.vnet.ibm.com> <2e7387b9-ceb4-cdca-56ac-f5344084e10a@linux.vnet.ibm.com> From: Halil Pasic Date: Mon, 16 Apr 2018 16:51:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <2e7387b9-ceb4-cdca-56ac-f5344084e10a@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18041614-0040-0000-0000-0000042F9383 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041614-0041-0000-0000-0000263398CB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-16_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804160139 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2018 03:05 PM, Pierre Morel wrote: >> +static void vfio_ap_mdev_release(struct mdev_device *mdev) >> +{ >> +    struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); >> + >> +    kvm_ap_deconfigure_matrix(matrix_mdev->kvm); >> +    kvm_ap_interpret_instructions(matrix_mdev->kvm, false); > > This call clears the apie in KVM. > This is only OK if we have a single device present until the end of the VM, > otherwise AP instructions in the guest will fail after the release until the end of the VM > or until a new device is plugged. I agree, this seems wrong.