Received: by 10.192.165.156 with SMTP id m28csp779843imm; Mon, 16 Apr 2018 08:35:52 -0700 (PDT) X-Google-Smtp-Source: AIpwx48+k6OUWl9RDah1K4G18RYs3HQcv/X3rYs4T0Qun5qlcvFGbGOKXql6cBmRiNRK+ox8IQNb X-Received: by 2002:a17:902:284b:: with SMTP id e69-v6mr4194411plb.240.1523892952730; Mon, 16 Apr 2018 08:35:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523892952; cv=none; d=google.com; s=arc-20160816; b=dDQH46JoqxoJIsFmOgYKTueL6iUJBGOi8L+OskUEqe4DUQQLsWgNcbVpWcYSYoletX LPBBNI+6nrBFlSzDq2F7qa2zyMKSmhgzTpteyUtTilShCUCUlI0JNJj+jaylO/s8RQlj /jzxk+IuKXyQHnqm9+8pM1yo9tu8DdGDNNOTjwsMRKZc38NGNx9pTEG/yZD7mV2VWCHT otW8iDSF1WGeeBnWJKqxOKQvbuYw9q8ddMEvELyCoK+M+o7hCXlcFmYIR/2oJEImBGsQ q/1wLrEAO3qRddeQ68/hHT5rhckMbGUXLyDHBgyd8tWRReoVcDPgQsszussCLR3EnU/m LJWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=oozxANMdWBcdwALT2WlhLJ6jhio16x9xwtmQfgR2FgM=; b=bvvvqK3NyVHA0/2lBv3VD/gKuEjXlG10jQIvAZfxryPcrQfCB9O5OvE/uHmMvxS2Qj 3RKidsSzJxxxrECadAM1Y/zpQwXhWYCyrv0FdUPClCLESsnVlpYNQ2DJDr8Nqr5REzlY GUZY23kkS6iFtPr5/onmB37DAX9eW2tuyHzY/ZKDyw9OKL8foRmHAhAn9DF6PaJ1a4ZA xG72DSblf32GsV5EISQ+A+6xAsC/9n/FDSg2gCKdBhuvOqyvF7cjdDfG0+Un16s6iOpy xMDAetgJWG5Gdz5tJ88kGo8ZcUTUrasTWH26wdEy23U3Bi7SMieRlWOLnNdv0XElMkLL J5FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=bq6sOx/v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b186si9748938pgc.569.2018.04.16.08.35.38; Mon, 16 Apr 2018 08:35:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=bq6sOx/v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbeDPPcj (ORCPT + 99 others); Mon, 16 Apr 2018 11:32:39 -0400 Received: from 8bytes.org ([81.169.241.247]:36014 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbeDPPZr (ORCPT ); Mon, 16 Apr 2018 11:25:47 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id E13D1976; Mon, 16 Apr 2018 17:25:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1523892339; bh=YLajBYb95/bW7K4AtgTulTsrUWPZZoPrW8LWskEt/eI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bq6sOx/v1gVS+NhRGvhg7QRx2fVPtwKtva6djNM7KPznCBYz+/MAqLDaEq7KaFtS9 aGLoJM+9mw17iXlB7KVxIKEN908AlbEqf2/uv/Rjq6MHulZqm5XX3r7UuIeMZmnVbh 2ddTeX785TrFwQoVwWpKl/iEfk9H2b4J3LTRVNMQokp45G5kkZK4R3JU1keBI79Y6L pgcvX3mlP6Qy1E1owhTLbPctoaqr9GpDQPBVnWYDlKkZyAGzPtwA3SO9oPnaMx/1xf WN4TRs6mzyAUR4a1hAZZGslo10mbG1rZZqTnOqY2rB/+M9GJskaaY9JJeECMOWLac9 W1Lgvjv7lEE4A== From: Joerg Roedel To: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , aliguori@amazon.com, daniel.gruss@iaik.tugraz.at, hughd@google.com, keescook@google.com, Andrea Arcangeli , Waiman Long , Pavel Machek , "David H . Gutteridge" , jroedel@suse.de, joro@8bytes.org Subject: [PATCH 18/35] x86/pgtable: Move pgdp kernel/user conversion functions to pgtable.h Date: Mon, 16 Apr 2018 17:25:06 +0200 Message-Id: <1523892323-14741-19-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523892323-14741-1-git-send-email-joro@8bytes.org> References: <1523892323-14741-1-git-send-email-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Roedel Make them available on 32 bit and clone_pgd_range() happy. Signed-off-by: Joerg Roedel --- arch/x86/include/asm/pgtable.h | 49 +++++++++++++++++++++++++++++++++++++++ arch/x86/include/asm/pgtable_64.h | 49 --------------------------------------- 2 files changed, 49 insertions(+), 49 deletions(-) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 5f49b4f..3055c77 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -1150,6 +1150,55 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, } #endif +#ifdef CONFIG_PAGE_TABLE_ISOLATION +/* + * All top-level PAGE_TABLE_ISOLATION page tables are order-1 pages + * (8k-aligned and 8k in size). The kernel one is at the beginning 4k and + * the user one is in the last 4k. To switch between them, you + * just need to flip the 12th bit in their addresses. + */ +#define PTI_PGTABLE_SWITCH_BIT PAGE_SHIFT + +/* + * This generates better code than the inline assembly in + * __set_bit(). + */ +static inline void *ptr_set_bit(void *ptr, int bit) +{ + unsigned long __ptr = (unsigned long)ptr; + + __ptr |= BIT(bit); + return (void *)__ptr; +} +static inline void *ptr_clear_bit(void *ptr, int bit) +{ + unsigned long __ptr = (unsigned long)ptr; + + __ptr &= ~BIT(bit); + return (void *)__ptr; +} + +static inline pgd_t *kernel_to_user_pgdp(pgd_t *pgdp) +{ + return ptr_set_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline pgd_t *user_to_kernel_pgdp(pgd_t *pgdp) +{ + return ptr_clear_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline p4d_t *kernel_to_user_p4dp(p4d_t *p4dp) +{ + return ptr_set_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline p4d_t *user_to_kernel_p4dp(p4d_t *p4dp) +{ + return ptr_clear_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); +} +#endif /* CONFIG_PAGE_TABLE_ISOLATION */ + /* * clone_pgd_range(pgd_t *dst, pgd_t *src, int count); * diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h index c863816..9934115 100644 --- a/arch/x86/include/asm/pgtable_64.h +++ b/arch/x86/include/asm/pgtable_64.h @@ -132,55 +132,6 @@ static inline pud_t native_pudp_get_and_clear(pud_t *xp) #endif } -#ifdef CONFIG_PAGE_TABLE_ISOLATION -/* - * All top-level PAGE_TABLE_ISOLATION page tables are order-1 pages - * (8k-aligned and 8k in size). The kernel one is at the beginning 4k and - * the user one is in the last 4k. To switch between them, you - * just need to flip the 12th bit in their addresses. - */ -#define PTI_PGTABLE_SWITCH_BIT PAGE_SHIFT - -/* - * This generates better code than the inline assembly in - * __set_bit(). - */ -static inline void *ptr_set_bit(void *ptr, int bit) -{ - unsigned long __ptr = (unsigned long)ptr; - - __ptr |= BIT(bit); - return (void *)__ptr; -} -static inline void *ptr_clear_bit(void *ptr, int bit) -{ - unsigned long __ptr = (unsigned long)ptr; - - __ptr &= ~BIT(bit); - return (void *)__ptr; -} - -static inline pgd_t *kernel_to_user_pgdp(pgd_t *pgdp) -{ - return ptr_set_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline pgd_t *user_to_kernel_pgdp(pgd_t *pgdp) -{ - return ptr_clear_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline p4d_t *kernel_to_user_p4dp(p4d_t *p4dp) -{ - return ptr_set_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline p4d_t *user_to_kernel_p4dp(p4d_t *p4dp) -{ - return ptr_clear_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); -} -#endif /* CONFIG_PAGE_TABLE_ISOLATION */ - /* * Page table pages are page-aligned. The lower half of the top * level is used for userspace and the top half for the kernel. -- 2.7.4