Received: by 10.192.165.156 with SMTP id m28csp808972imm; Mon, 16 Apr 2018 09:03:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/WcxhOjZX6T3qj86DYJeiGsor16FzcANNGRlzG1Pzl/ApM9eos2Wlze+1s3AbrQbPRFvd/ X-Received: by 2002:a17:902:b707:: with SMTP id d7-v6mr16062345pls.188.1523894582221; Mon, 16 Apr 2018 09:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523894582; cv=none; d=google.com; s=arc-20160816; b=Y3YzAyznCK+K5waZ+FDT8g/EYJ5SNZqpG9t+4oXYcMx2+HqNwfSXLLty+/jAr+LiMQ OTWoYCa/dWR0tcsuQvaG0jhXSxqE+YRtTn97BongvDPPyXt1I3lEY1093e995/djklA2 bC9w4kKnDEaF+sgvOEM2EMVPU9Ygr2F8lQIW22nT0E1aiZRTrlKHzLlFWG3askiNCAz8 swRLwl8C+QLqTuLuAoVRQgahe5btP/JKAHJujHOjxnc6GkYrfcCOmomZhWiF3FeX2drl dchPRrlUIOyVC+IMsrHUZ3mboGebYRykmPPGH3x64v7oHGhBG9ZqIEGsLfDxcuAYHy1t zwBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=RRJVsr3WAkWC8rJS190twtEt07530x5YOhDvI5X52SY=; b=OWTGPizWohc41t4WxH+sOlqliq7hWOl9axRu1HDvOhjaezqEc243qW0vKiqlleJfO9 2F8PZVneAhUrYtOPHpGZSdYErPKA4kc4AFbXbt0E9IpfmzHo1EDClajMjDI+OE+rn/aH H49yNHNtyumwARZLgt/WDHFm+FFfAea39AyBSWGpX85+96fPcH8wCpsiG9IFdUiBFtTC 5auXadGweqO+8K7owQ9rFh3ZGX9X3skGvUyQjWED5JBSjnnVabd0Hbx5CKd+viaw+LrK 1g03YXZxgYULzXQLj/k87mQOOoalnMPQzrHW/sMb2vPE4Pz/YGWI3EVbEFG3q8ErDlCP qwVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si4305253pgq.436.2018.04.16.09.02.47; Mon, 16 Apr 2018 09:03:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbeDPP7q (ORCPT + 99 others); Mon, 16 Apr 2018 11:59:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49818 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751149AbeDPP7o (ORCPT ); Mon, 16 Apr 2018 11:59:44 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3GFtEAF059995 for ; Mon, 16 Apr 2018 11:59:44 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hcvpgfpnq-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 16 Apr 2018 11:59:43 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Apr 2018 16:59:41 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Apr 2018 16:59:38 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3GFxbjH25231450; Mon, 16 Apr 2018 15:59:37 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B9BE84203F; Mon, 16 Apr 2018 16:51:11 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37D5742049; Mon, 16 Apr 2018 16:51:11 +0100 (BST) Received: from [9.152.224.146] (unknown [9.152.224.146]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 16 Apr 2018 16:51:11 +0100 (BST) Subject: Re: [PATCH v4 01/15] s390: zcrypt: externalize AP instructions available function To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1523827345-11600-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523827345-11600-2-git-send-email-akrowiak@linux.vnet.ibm.com> From: Pierre Morel Date: Mon, 16 Apr 2018 17:59:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523827345-11600-2-git-send-email-akrowiak@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18041615-0040-0000-0000-0000044E2819 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041615-0041-0000-0000-000020F26AC3 Message-Id: <83bd1b8f-f3c0-328f-4b3d-6972d82b3662@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-16_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804160146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/2018 23:22, Tony Krowiak wrote: > If the AP instructions are not available on the linux host, then > AP devices can not be interpreted by the SIE. The AP bus has a > function it uses to determine if the AP instructions are > available. This patch provides a new function that wraps the > AP bus's function to externalize it for use by KVM. > > Signed-off-by: Tony Krowiak > Reviewed-by: Pierre Morel > Reviewed-by: Harald Freudenberger > --- > arch/s390/include/asm/ap.h | 7 +++++++ > arch/s390/include/asm/kvm-ap.h | 23 +++++++++++++++++++++++ > arch/s390/kvm/Makefile | 2 +- > arch/s390/kvm/kvm-ap.c | 21 +++++++++++++++++++++ > drivers/s390/crypto/ap_bus.c | 6 ++++++ > 5 files changed, 58 insertions(+), 1 deletions(-) > create mode 100644 arch/s390/include/asm/kvm-ap.h > create mode 100644 arch/s390/kvm/kvm-ap.c > > diff --git a/arch/s390/include/asm/ap.h b/arch/s390/include/asm/ap.h > index c1bedb4..7773bfd 100644 > --- a/arch/s390/include/asm/ap.h > +++ b/arch/s390/include/asm/ap.h > @@ -120,4 +120,11 @@ struct ap_queue_status ap_queue_irq_ctrl(ap_qid_t qid, > struct ap_qirq_ctrl qirqctrl, > void *ind); > > +/** > + * ap_instructions_installed() - Tests whether AP instructions are installed > + * > + * Returns 1 if the AP instructions are installed, otherwise; returns 0 > + */ > +int ap_instructions_installed(void); > + > #endif /* _ASM_S390_AP_H_ */ > diff --git a/arch/s390/include/asm/kvm-ap.h b/arch/s390/include/asm/kvm-ap.h > new file mode 100644 > index 0000000..84412a9 > --- /dev/null > +++ b/arch/s390/include/asm/kvm-ap.h > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Adjunct Processor (AP) configuration management for KVM guests > + * > + * Copyright IBM Corp. 2018 > + * > + * Author(s): Tony Krowiak > + */ > + > +#ifndef _ASM_KVM_AP > +#define _ASM_KVM_AP > + > +/** > + * kvm_ap_instructions_installed() > + * > + * Tests whether AP instructions are installed on the linux host > + * > + * Returns 1 if the AP instructions are installed on the host, otherwise; > + * returns 0 > + */ > +int kvm_ap_instructions_installed(void); > + > +#endif /* _ASM_KVM_AP */ > diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile > index 05ee90a..1876bfe 100644 > --- a/arch/s390/kvm/Makefile > +++ b/arch/s390/kvm/Makefile > @@ -9,6 +9,6 @@ common-objs = $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/async_pf.o $(KVM)/irqch > ccflags-y := -Ivirt/kvm -Iarch/s390/kvm > > kvm-objs := $(common-objs) kvm-s390.o intercept.o interrupt.o priv.o sigp.o > -kvm-objs += diag.o gaccess.o guestdbg.o vsie.o > +kvm-objs += diag.o gaccess.o guestdbg.o vsie.o kvm-ap.o > > obj-$(CONFIG_KVM) += kvm.o > diff --git a/arch/s390/kvm/kvm-ap.c b/arch/s390/kvm/kvm-ap.c > new file mode 100644 > index 0000000..1267588 > --- /dev/null > +++ b/arch/s390/kvm/kvm-ap.c > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Adjunct Processor (AP) configuration management for KVM guests > + * > + * Copyright IBM Corp. 2018 > + * > + * Author(s): Tony Krowiak > + */ > +#include > +#include > +#include > + > +int kvm_ap_instructions_installed(void) > +{ > +#ifdef CONFIG_ZCRYPT if you do this take care that ZCRYPT may be a module ;) > + return ap_instructions_installed(); > +#else > + return 0; > +#endif > +} > +EXPORT_SYMBOL(kvm_ap_instructions_installed); > diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c > index 35a0c2b..9d108b6 100644 > --- a/drivers/s390/crypto/ap_bus.c > +++ b/drivers/s390/crypto/ap_bus.c > @@ -210,6 +210,12 @@ int ap_query_configuration(struct ap_config_info *info) > } > EXPORT_SYMBOL(ap_query_configuration); > > +int ap_instructions_installed(void) > +{ > + return (ap_instructions_available() == 0); > +} > +EXPORT_SYMBOL(ap_instructions_installed); > + > /** > * ap_init_configuration(): Allocate and query configuration array. > */ -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany