Received: by 10.192.165.156 with SMTP id m28csp863389imm; Mon, 16 Apr 2018 09:54:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/5PJLM0UwV3QALguVZyAl4TIX4X2oAcDCwCSSWvlAvkEew6D1hTMEwHxwrlWGSB2T4baY2 X-Received: by 2002:a17:902:2b84:: with SMTP id l4-v6mr16122212plb.65.1523897676097; Mon, 16 Apr 2018 09:54:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523897676; cv=none; d=google.com; s=arc-20160816; b=KL3+wClFG2LJGQO4vklqCDNjfe9VNKIDE8ytrpG+mprvSB6dQWZ+RFbzQTXojiqF08 2l9XU3SR7ThK7fzxMyvE0dmGzmy83GPlFvOJWIMaQMIz5jzHglE8z0Tjz5xquQekMw20 4w+MxOVBoCo7zAaezyhmdudRYw+GWFgBXHxIeDHjurK1M7ZGN4l0/chWNs6tvxMxvW3M ZgWPdq3nbn6aDuU5xoOOBhHTjD0mIJDiqwNoq4ExDdyrosksYF+PaEdyn7mG17xvbb5a vVSO0j3OFSUiA2oDhZlL2bkMpTns0gdSP+SWyPdH51qUajsPwAkD8VSGbBH0YkecNrop /Auw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=64ixPkmoFxx/v33/Kf01Raz22jJJ7N8XAY/wvoG2Om0=; b=mmitFHWz4caPOJJWylwYnJd8XsOx2KET0OQQyYc4MEi4a5GABi9oLHfsIhO0JOulo6 J7fWLAPiRCkiUT+HLy93PX+Tu6ea1zkEx9ELvztEfjRmj7LbwuOC1I1H2CGaEtk+ryPZ IvVdCNbTBuWSgWcsrlI3tgndVDOdQkcNGfn0blZbjnD52CyxP731O/HCN4XUUlY6VhMQ Hg8Izl7/na7f5JcndSpUejvnYgpGKThpOf3S6K1xPsZYsNLkBcpMq5qfYyzJeWUx7f5A xYbTx1Ts5na8tOTc782fgyPMAhPUCajgQxVZtBa4A9hWg7QHkWOyUtKwS3nGv9io7ieg g4CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=epBG59mJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g28-v6si6205992plj.529.2018.04.16.09.54.12; Mon, 16 Apr 2018 09:54:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=epBG59mJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbeDPQwS (ORCPT + 99 others); Mon, 16 Apr 2018 12:52:18 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:45536 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbeDPQwR (ORCPT ); Mon, 16 Apr 2018 12:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=64ixPkmoFxx/v33/Kf01Raz22jJJ7N8XAY/wvoG2Om0=; b=epBG59mJoEKUM7YkHfx9VZ0gD fRndn7ZItKTq6f6hBcT2vkcYghb6zZsGwqd3HxjeMO+S7i7OAKh9t0nbqNMT/O8vhg5hamCd6MPgy cg1BU5smttLphg1F/CAjmnrXFtTyAlGq4giv60YzmN/xzRMJkzFVxq0hvKa/2pIX+Rlnk=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f87MN-0005r3-Jh; Mon, 16 Apr 2018 16:52:07 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f87MM-0001ra-Nf; Mon, 16 Apr 2018 17:52:06 +0100 Date: Mon, 16 Apr 2018 17:52:06 +0100 From: Mark Brown To: Kirill Marinushkin Cc: Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Pan Xiuli , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v4 2/3] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Message-ID: <20180416165206.GE20726@sirena.org.uk> References: <20180404041939.23317-1-k.marinushkin@gmail.com> <20180404041939.23317-3-k.marinushkin@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Rgf3q3z9SdmXC6oT" Content-Disposition: inline In-Reply-To: <20180404041939.23317-3-k.marinushkin@gmail.com> X-Cookie: No lifeguard on duty. User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Rgf3q3z9SdmXC6oT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 04, 2018 at 06:19:38AM +0200, Kirill Marinushkin wrote: > + /* clock gating */ > + if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED) > + link->dai_fmt |= SND_SOC_DAIFMT_GATED; > + else if (hw_config->clock_gated == > + SND_SOC_TPLG_DAI_CLK_GATE_CONT) > + link->dai_fmt |= SND_SOC_DAIFMT_CONT; I'll apply this but the above would be better written as a switch statement - could you please send an incremental patch changing it? --Rgf3q3z9SdmXC6oT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrU1LUACgkQJNaLcl1U h9AJHwf/VRXvj6wUgqNsOgl9BTNAgjrI542w0m0iTZLOCRoDi8215Dyu7VLL4eyX URweWYD0bpeXfGYGwAiEFZu5hQzWUOBwCInt29HoCNuEo9pwLySKZ1F0QHy9HFuQ jOoxHUHz8sa0iOiqw8w78pAlrNfOqF9FRkG92+By6ub8ygIfcM5N07AcS4ObNCHB Kdux0S0jyg1mztoaOQygdf1cta1WipWf+UphdGT9HgoCP++a8AWJ1kMzcxvCarIC /jmYmiG1spafa7wVYD8laLKmd2d8mquIDlwDe0pF9N4WkNbE7pfgbOoaU2/6CXOz LGtvCxqxqDkwHwa/cBd/4bUKlcPF+g== =ll/R -----END PGP SIGNATURE----- --Rgf3q3z9SdmXC6oT--