Received: by 10.192.165.156 with SMTP id m28csp916764imm; Mon, 16 Apr 2018 10:45:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/I3zuZ/n64QTPzfUnbpTFZWPKnW+gStCU+yk8tyngzXD2cWA9E3H4zFk34XO0hLTjWckeX X-Received: by 10.99.176.8 with SMTP id h8mr108339pgf.448.1523900721326; Mon, 16 Apr 2018 10:45:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523900721; cv=none; d=google.com; s=arc-20160816; b=nA62e/v6iYhV8K7KqKLeNdprIYoxqyq6v421yBStDnaohyM9FpTfZnVarzyN/+g+Qf Ewd8TzF1JObuidIuwjxc4HTovIPF7RXu8+EHDHcQDrZ8ICOaij6xezhTWXSNJTXr0Rtr yXk/W52H/hpvTE95Y9WK00L0X1ZWuRY9a/VgA0zA3hxZiiOcxHh8yhCQYrBe1xqWsZmm YY1NntaEx+h+vODOZs7SVwS69c/v8cEulshfx1xAXRpFZD0ViYFMYX+2zugf0yFHy9NC MfbZXXLChGeg1VtkXifF94/ITxP2V1jDD3ioNyMShS3lv0cKCR+J+6Ogzvy0PTONjbYy BIyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=KYxWA6eypEC8QxN77McJIygL/2k71tS2ItdCwpZZn6o=; b=0AuPL5PEfOUZXGFPtj7aM67DJ80qywca6jzKjAZUGgRwYHzJJIuDqtbvOJ6lKrwpE6 GPt5Z1Zp+DtCVY4KN2CXjNU9hwLsHSbmCyEk4Ekry4nwdqAN0EYQxUR5/eTs7+UW4oaY EUQ656YXpRQtxQaXZTS90Rvx+0KDXsF4RYNvHukt89d/SYMcXw1vnbm6KITQXmSABOaw 9faM93w7NkVdyacCo9It6HsQJGppTlPOK7uEC9nSoPF0pLbqQItQ5jFaRSW7mBRHaSic WQz+0KLxnArrY1vMdS+ZdmSmUy4YIsaGVdwqFwCCS2RHKsUNCBR921PhYjP1mhRGh8Uf lWEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si1470102plb.574.2018.04.16.10.45.07; Mon, 16 Apr 2018 10:45:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbeDPRnj (ORCPT + 99 others); Mon, 16 Apr 2018 13:43:39 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbeDPRnh (ORCPT ); Mon, 16 Apr 2018 13:43:37 -0400 Received: from localhost (pool-173-77-163-229.nycmny.fios.verizon.net [173.77.163.229]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DA5D1142CDE11; Mon, 16 Apr 2018 10:43:36 -0700 (PDT) Date: Mon, 16 Apr 2018 13:43:33 -0400 (EDT) Message-Id: <20180416.134333.1584175683168282946.davem@davemloft.net> To: ryder.lee@mediatek.com Cc: sean.wang@mediatek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] net: mediatek: use of_device_get_match_data() From: David Miller In-Reply-To: <9bf87205f84062580934168774d690d4cd2bf26b.1523347340.git.ryder.lee@mediatek.com> References: <31f944ab8dfcc1d7b6f03b35657a2a34825b5246.1523347340.git.ryder.lee@mediatek.com> <9bf87205f84062580934168774d690d4cd2bf26b.1523347340.git.ryder.lee@mediatek.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Apr 2018 10:43:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ryder Lee Date: Mon, 16 Apr 2018 10:33:41 +0800 > The usage of of_device_get_match_data() reduce the code size a bit. > > Also, the only way to call mtk_probe() is to match an entry in > of_mtk_match[], so match cannot be NULL. > > Signed-off-by: Ryder Lee Applied to net-next.