Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261455AbTHSUAi (ORCPT ); Tue, 19 Aug 2003 16:00:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261322AbTHSTVd (ORCPT ); Tue, 19 Aug 2003 15:21:33 -0400 Received: from lopsy-lu.misterjones.org ([62.4.18.26]:37386 "EHLO young-lust.wild-wind.fr.eu.org") by vger.kernel.org with ESMTP id S261185AbTHSTTm (ORCPT ); Tue, 19 Aug 2003 15:19:42 -0400 To: Greg KH Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EISA bus update Organization: Metropolis -- Nowhere X-Attribution: maz Reply-to: mzyngier@freesurf.fr References: <20030819174208.GA4992@kroah.com> <20030819183537.GA5297@kroah.com> From: Marc Zyngier Date: Tue, 19 Aug 2003 21:19:13 +0200 Message-ID: In-Reply-To: <20030819183537.GA5297@kroah.com> (Greg KH's message of "Tue, 19 Aug 2003 11:35:37 -0700") MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 37 >>>>> "Greg" == Greg KH writes: >> Well, there is nothing to do in this function, because that's what the >> whole driver does: nothing. It just presents a range of IO ports to be >> probed to the main EISA code, and nothing else. Greg> But it exports something in sysfs, right? Any reason you just Greg> don't dynamically create it? It's real hard to get static Greg> allocation of struct device correct. Indeed, it registers a platform device. On the dynamic vs static subject, it shouldn't matter here. Could switch to dynamic allocation if needed. Greg> Will this code ever be able to be built as a module? If so, Greg> this will not be correct. No, it won't ever be a module. It woudn't make sense. Most of the time, it is needed to boot the system... >> Once it has registered as an EISA bus root, it doesn't get called >> anymore, the core code does it all by itself. Greg> So the release function never gets called at all then? Why Greg> would this be needed at all? The only case in which it is called is when registration to the EISA framework fails (because there is no EISA mainboard, or some PCI/EISA bridge has registered before, with the same IO range). Thus we call plateform_device_unregister, which calls the release function. And this only happens at init time. Never after. Thanks, M. -- Places change, faces change. Life is so very strange. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/