Received: by 10.192.165.156 with SMTP id m28csp1133247imm; Mon, 16 Apr 2018 14:50:00 -0700 (PDT) X-Google-Smtp-Source: AIpwx49aoWeVhRXxWPJYiN/Jdvh+Hb2I7nOeRZy/Pq0gUNScSyN9xaGtjjx7XIzTMWy5apyB7SFc X-Received: by 2002:a17:902:28a6:: with SMTP id f35-v6mr17010754plb.204.1523915400307; Mon, 16 Apr 2018 14:50:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523915400; cv=none; d=google.com; s=arc-20160816; b=hk4pY+cPbJ38NjX/llgUF8qoL0b3TZPQmwAsmNfPUtJixAxneabRj9vCAPUwcTNtQ1 d/TTyc9xjyybUuBK4SCrzcrnEGTN44uZRbI4D5pUKaZU+CtPapFTLCZauGwSNMpuKFnQ IaP9wwiS9WT6FPs5tZenvFhv30BZSLj0TGQ2LF5/uSI+7bBrO2s6wyrZwdSUu4AsnKyp fphMtNFG3BPmBPxICy3BkNfFi8vlba3YrFJ7phru+eupLrP5ojh1rG+sa+oDB0w3Ob8k egXz9Nv1sckyg532T6tufwmANYSXqqq0rk+SN6ZKDjagkCYhu7CjEz+v6Rmv6wO655h6 SdlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=5F5KExpWO7nKZF1iHi8+j3VkysEEKaeWGvkZ2bqZ1Ko=; b=bioPBk+3w7DU2MeJebKOUDTbJpGsf4Mxc3M2LDH4Iig60pMg/cOkXcc2BeCc1om42T LGRMTafrUFQCAKx12/Yg13PPOmShH4q3fInOqB4jb/8Gcg+2XWBeYW8pATHnUDapfXhi CV0iOPJ8N41cQUWQO4gVmXUBDrigM/IuoMnZd1cO5LsbztT7AgaRveha0ibZMav4/f/7 EwAOEK0GKrZhp2P8RLXMqe5I/X84FhpPxAOZ9fgZokXlFTZdw9fcvwdCMX/8aYzhCcGW A7ZRZOn2IvL92vVupGQ03ukmgi0aSnK549K3pTbfyLXkUYmQwXXuJTSHPugbZ1gaRwbk 5DCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=LvKyRchE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c87si8139264pfk.53.2018.04.16.14.49.46; Mon, 16 Apr 2018 14:50:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=LvKyRchE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbeDPVsR (ORCPT + 99 others); Mon, 16 Apr 2018 17:48:17 -0400 Received: from mail-yb0-f178.google.com ([209.85.213.178]:42213 "EHLO mail-yb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbeDPVsN (ORCPT ); Mon, 16 Apr 2018 17:48:13 -0400 Received: by mail-yb0-f178.google.com with SMTP id t8-v6so7629885ybo.9; Mon, 16 Apr 2018 14:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5F5KExpWO7nKZF1iHi8+j3VkysEEKaeWGvkZ2bqZ1Ko=; b=LvKyRchEYET+T6ZSP3x0M9FJlrpYvHAev0UAzqPtXeQ/9Oji/mD40CNxY6I4BfOnG1 j6HoxYDmoMClFRUwiNgNo+0rE5GYR2kkpDFAFDcY0WyQeR4OhhpmJpskvmjcuCOfow+s Sjc4yNVGHZkv5WE8eVbHmzEtcHoyFqgkLRo6EhZ6m/yEwuCd/hzq9CrP7vwwITEsFBWw AQ6YwjPF+0sE6oJwT5yKpF7vAeWPmeyDfbfJ1BVXDg7ceaX9z6Kv/q2zf8ONuBk2sAzS Ns74MMCI/JTV54uBJOknVM5u2qM0P6ieq16Vqn+dJHGLLqzyBYYAne1zJXdm+U9cHbHe jTug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5F5KExpWO7nKZF1iHi8+j3VkysEEKaeWGvkZ2bqZ1Ko=; b=EVtAucGuYzJQn5w/k/N1jIxtgO/WgMN2cpLjpk/UyTZyQ7XdTiWh+n/liRMlVFANlN iKMnm3pV4pIzeErEMwqBzkcYIwLjT3IFpen5rmWWR+Puk26lSJHcUpXuUavdWLJ5QyDo rI+H873657xYdXNO7uK+nShCq7EGtPt6VVGIWzlu2+14/h7p1CoUynrkh5rieFTLfp9T B2Eh+98J3DPJZwWJb5nbtsvs/FqVBASG/I68UIPz+PLjFS41jWoOGFtxVZFz2om4eCr8 //THPwDJbCJXXx7j7Ehc0jpBlYqOCxtjbhd5+OqmVncbytstx9yMgheqGBIXY88B+0Rf 1piA== X-Gm-Message-State: ALQs6tAbCjgvBVZEvVCgQhAYXd0DXplXxVptO/OE8BJbeXbG3LJg7+Kx H3MOjrl+4J0oJerAR7Ld1WtnicXv X-Received: by 2002:a25:bc54:: with SMTP id d20-v6mr10086123ybk.470.1523915292765; Mon, 16 Apr 2018 14:48:12 -0700 (PDT) Received: from localhost ([2620:10d:c091:180::1:fa74]) by smtp.gmail.com with ESMTPSA id c23sm1570944ywa.26.2018.04.16.14.48.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 14:48:11 -0700 (PDT) Date: Mon, 16 Apr 2018 14:48:10 -0700 From: Tejun Heo To: Gaurav Kohli Cc: gregkh@linuxfoundation.org, nborisov@suse.com, akpm@linux-foundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] percpu_counter: Remove debug_object_free call twice Message-ID: <20180416214810.GF1911913@devbig577.frc2.facebook.com> References: <1523612103-15071-1-git-send-email-gkohli@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523612103-15071-1-git-send-email-gkohli@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2018 at 03:05:03PM +0530, Gaurav Kohli wrote: > During percpu_counter destroy, debug_object_free is calling > twice which may create race. So removing once instance of call > from debug_percpu_counter_deactivate. I don't quite follow. Can you please elaborate how it can be called twice? Thanks. -- tejun