Received: by 10.192.165.156 with SMTP id m28csp1165898imm; Mon, 16 Apr 2018 15:27:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/45D+PfhDaMBnbaHxXjrf1zYIJitWMaRyeyrAxLqEMaiH43VVNg9tDoQCssl20lhxK9Vss X-Received: by 2002:a17:902:f24:: with SMTP id 33-v6mr17331943ply.242.1523917648307; Mon, 16 Apr 2018 15:27:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523917648; cv=none; d=google.com; s=arc-20160816; b=xXDQD2aiUJbyW0D0gWJAe2xCZINfacTYqGkh9X5JZA2kEJftOym8M6y8sO2L//3k8h fMzRx++1sR7oo0qMMt/MuTA+9y/EAMnvmIxsxSLg8oEq3KVX9C3jTKb17E5S5UBwaHnv 0rGmDWmcvMEF+4JDYguJE0+znFx0s3IwCyeQDkcrpMHut4tobN4eUM0jiaCSgzXGUq5I Z07EwU8bRhbel2JsxRA1vGbxbD3RrK0T9kEq3WCEwwgebTNqBc5FCykQYFIeTciQssGq L4ovbeiwhCDhcaE/NUgXZL2bsAMzWupatQ8InDk+UOmb285w6lSIGYRD0VPMTsNwUGtU ofqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=XLM3XNRLqTt91Am8vIGvCLq9nMkzugNTurkeYqa+iYA=; b=HTEuEb2HY2ARcHH7tvFRrw/D0YLuvOhnok+BDCveQMAiFNVDuRruuo2F64v14Bj69W 8v+aHbEdRraZlglpNa3c7r+ddlNYO9SOxQeEhnhv0qE9pwbNJwD7sj7oknswlVfXc95s xsiE4DhGz6bf1LL2iip3kKJzucntSefpgfYUosBNvuliXOCMI6Xqiqqjqwcxrx2O+JGf 23NM6kSk/icX7ALg9i18EQStOVVLFQ9FZJpTmwGpLiGt5VKAogKgkgLCjYj6p/JV4w2y bR/CqPAwFZAReDMkrkqv6EleoSsQXzinZMWRedvawuYu+Uv2u/G/5V4xZ5ZV3gYmhhlD jhfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KY439Ld5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p186si2020411pfb.171.2018.04.16.15.27.14; Mon, 16 Apr 2018 15:27:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KY439Ld5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbeDPWZp (ORCPT + 99 others); Mon, 16 Apr 2018 18:25:45 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:32807 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbeDPWYu (ORCPT ); Mon, 16 Apr 2018 18:24:50 -0400 Received: by mail-io0-f169.google.com with SMTP id s14so3273976ioc.0 for ; Mon, 16 Apr 2018 15:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XLM3XNRLqTt91Am8vIGvCLq9nMkzugNTurkeYqa+iYA=; b=KY439Ld5ZzaNTsxlnUw+n4CyiQJz/P4Mi6qW+WIAcYzQ7fVKP3uViAWEBO5pqAzKsZ Aicdw00KNhYrhytgdd43JCyD32VYaaJoFV077TUIy28pRR6y4h93DJRQnYBzOrNswi3L zue54lhc6QzchkzrJSL9IrbtJaPfz5cjTn3MCqfvyzjFshTs7bw5AfsWIfA3mzJT+Q8L Q8QC3gOR0TEIG+s2+t0j7rGcRKZawIbptWfqzkpjWLe1KDVcU03p4erdjZET+w9VjLJ8 zl2d4XjvksE/++Fgn6W6432sulTdGXcSubjUkSnHXLfj0KoGaRtFjkdAtkdpag7bFy7T rakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XLM3XNRLqTt91Am8vIGvCLq9nMkzugNTurkeYqa+iYA=; b=rgRT60fMnFX5SpSnSu6eoUFlVYb0Yv+yhC6xaq1Z/+TIbrpFQa0Pi5jzyZywTWcEe8 Aq+Shu2Rqp7ymHUzYs9M/IB8/wtPa06uaHp4uJyCqn9vnM/syeuDfz5d+SEEljtp8WCY jEpeINSK4mDtm8vOPNFGEqQp1p8G2zk6217e83bRsCnzvPNHvPyZcniH5p7w6DmJGhzk gyFXTeY+v3XtuZVfeYDFITLdTSVfGQL8zb0zmGmLDA5L0aLQbTgHlWZjyyNgoXOFjgWp Dsy0ROGw7m6spQ52BbCbqJYZECyPrVLobfSbfKNOAC6Evm+75l/6muqbwFPU3EyZUnkf X/qQ== X-Gm-Message-State: ALQs6tCbJ3Lk97VA1MDzcKQpvYjjSFLY7wMwHjliVDYBwJGsDGteT2SX qo9VoylZpUzpwWcMQ7eYqbafRcS6 X-Received: by 10.107.19.161 with SMTP id 33mr9739865iot.9.1523917489359; Mon, 16 Apr 2018 15:24:49 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id x139-v6sm5095360itb.3.2018.04.16.15.24.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 15:24:48 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Cc: andresx7@gmail.com, gregkh@linuxfoundation.org, mcgrof@kernel.org, alexdeucher@gmail.com, ckoenig.leichtzumerken@gmail.com, kvalo@codeaurora.org, arend.vanspriel@broadcom.com Subject: [PATCH 5/8] firmware: print firmware name on fallback path Date: Mon, 16 Apr 2018 18:24:24 -0400 Message-Id: <20180416222427.29683-6-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180416222427.29683-1-andresx7@gmail.com> References: <20180416222427.29683-1-andresx7@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d". However, with the new firmware_request_nowarn() entrypoint, the message outlined above will not always be printed. Therefore, we add the firmware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index ecc49a619298..e5b0a96ae781 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -669,6 +669,6 @@ int fw_sysfs_fallback(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + dev_warn(device, "Falling back to user helper for %s\n", name); return fw_load_from_user_helper(fw, name, device, opt_flags); } -- 2.14.1