Received: by 10.192.165.156 with SMTP id m28csp1229453imm; Mon, 16 Apr 2018 16:53:51 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/pvOq6UK7v1ZRM5MuIyhe4KQu9MAfz/IVBojNvB868xtTlTs0d75MHF5z5JP2w7aDE4bZy X-Received: by 10.98.102.65 with SMTP id a62mr23491574pfc.68.1523922831348; Mon, 16 Apr 2018 16:53:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523922831; cv=none; d=google.com; s=arc-20160816; b=OTSCD+qcFR4xQOPYQCDVRTgeyigI7kj7erldaN58j3M+aZBT466+S49OGxf7wvBMC7 qyJ0rvi3JAEdCBFop40xV6RQ9ewAbtdsypOiJz9w0pDwzzKa7tuead7LTPm1ATneGn7q U/gLpiMlhoarXrbNcW+vQbYDt/hky1ictrqbmiVcpk5XQ7wUIc6ccW+IBId5ZsYWVeiI VmKh4xUcOiJHhZ/gfDe3RU67loEoNFMeb5famJoyLA9MbrdTCWhGI04Lsg6SFtZSg74L l8Ny7U2Ho0U+dwjTK67jZjl1FdQTXaF21upLH94ubcUfeCWz3ZT1MaQ+vqhkKiwxYTq3 xUTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=bclxoIjMxxHC4iWmnh/YiUWJlSfzOPPOzTH/WFCZ62Y=; b=JSDbOBjMnHovXAwncn4uAJK20f9d+GLqjp0V42XA1b4/EvLzGqWfrwTGkFF0gm5gLW BtMr08RxiO+Q13uxQVv4y55sdtls7UNYUSsnkaSbcKFJy/lUjktMo3GTUdzB1fBsI5Ow vp3tVGf8djqSolJjTa8ydkb0vg32xJykC2wHmn0UQFsHEll9KKeAMh4QTiXDPG9Cazkn +pIjcRgEI6ZjV2QUJaKYg+8adrcLfD2nIrbedr8zpAIQvo3x4YjoPKQn2gA9lUF7i8lU UrR4zo78kSMzRrVNCVvuuyo0WTt3oJC0r8vs9W2Bnrykezg3IPD3PFe9t8KKSujZ8N3w hDRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sl/4+EYO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x189si6025632pgb.384.2018.04.16.16.53.37; Mon, 16 Apr 2018 16:53:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sl/4+EYO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbeDPXwB (ORCPT + 99 others); Mon, 16 Apr 2018 19:52:01 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:43093 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbeDPXv7 (ORCPT ); Mon, 16 Apr 2018 19:51:59 -0400 Received: by mail-pf0-f193.google.com with SMTP id j11so4734422pff.10; Mon, 16 Apr 2018 16:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bclxoIjMxxHC4iWmnh/YiUWJlSfzOPPOzTH/WFCZ62Y=; b=sl/4+EYOLMhlyXRT+jfcBs5jcl+0BnnKzpSBFbl+hmrlppKU0x87aAMztJuCaM0tlB qxYPc9eVL/ZOqWCYBoE2L3vzLB+xQEsiiZTeEmOSwH+uJGQWehmIshGHwwu4D93U2Ekw n5310d/9IsTiys/z3cw3kxuV+U6EIC8K9iNZWEaKBSiQ8VP2UZ/PP7qWl/MCkIuc9ZGJ mkoVG6Owqfjndc07a4n8/BsdYO0dhBJqPCtTL6cUZnTL4mMOc5e31+gfgiKS7TSxq+qn wWexxnHm9+PAFYAIswy2ZHccRBmj+NV4p+DRHI+ymlmPhqvCRaYT1YaD74QX7Lr3tG65 6o9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bclxoIjMxxHC4iWmnh/YiUWJlSfzOPPOzTH/WFCZ62Y=; b=SOhj/mWDwVtDFir0hWGSlsEMH3GhUqrytQH0hmS+PVHCxw7kQXZZhjegIsgEzsRUy3 2USVTqP/RnRksvAmISD5YPgfcA6A+CONhh6UxMpL+Fv6C+K7Tb0aDwM9fVR7gZtGJH8Y 2qR0QCK6DWo5SUqSPlWrG4zfcn5WJdyVqGsoGo3KVYuGGpnPqzaDCNH4ab9gWChLifGA zuIVeA0dgwADLojs6dj/v61z5O2nEOWzrmsuwSku75f8pgSP3i1c//Rp9hr2mQ9jCKLe 9e/cJ/4f/Dvi3OLgUsz15oGVt9Nj8BSddltfN/jsLMOWXgLPIopAyvQBRJ49T/5sR/0p gwqA== X-Gm-Message-State: ALQs6tADRtDN32R/9wCWq3xhI6BwlMS5PFJDtehAOReS6FQlz8h4WYct PRoimn/T+qT9BrGTu+Bk2P0= X-Received: by 10.101.68.205 with SMTP id g13mr14117241pgs.387.1523922718944; Mon, 16 Apr 2018 16:51:58 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1511:8de6:27a8:ed13:2ef5]) by smtp.gmail.com with ESMTPSA id y5sm12806691pfm.117.2018.04.16.16.51.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 16:51:58 -0700 (PDT) Date: Mon, 16 Apr 2018 16:51:56 -0700 From: Dmitry Torokhov To: Peter Hutterer Cc: Benjamin Tissoires , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found Message-ID: <20180416235156.GE77055@dtor-ws> References: <20171208142818.15156-1-benjamin.tissoires@redhat.com> <20171208142818.15156-3-benjamin.tissoires@redhat.com> <20171210222926.GB11027@jelly> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171210222926.GB11027@jelly> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 08:29:26AM +1000, Peter Hutterer wrote: > On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > > This is something that bothered us from a long time. When hid-input > > doesn't know how to map a usage, it uses *_MISC. But there is something > > else which increments the usage if the evdev code is already used. > > > > This leads to few issues: > > - some devices may have their ABS_X mapped to ABS_Y if they export a bad > > set of usages (see the DragonRise joysticks IIRC -> fixed in a specific > > HID driver) > > - *_MISC + N might (will) conflict with other defined axes (my Logitech > > H800 exports some multitouch axes because of that) > > - this prevents to freely add some new evdev usages, because "hey, my > > headset will now report ABS_COFFEE, and it's not coffee capable". > > > > So let's try to kill this nonsense, and hope we won't break too many > > devices. > > > > I my headset case, the ABS_MISC axes are created because of some > > proprietary usages, so we might not break that many devices. > > > > For backward compatibility, a quirk HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE > > is created and can be applied to any device that needs this behavior. > > > > Signed-off-by: Benjamin Tissoires > > Acked-by: Peter Hutterer So what is happening with this series? I think we should get it them in; there is really no reason for bumping ABS_MISC till it gets into ABS_MT_* range on some devices that are out there. FWIW Acked-by: Dmitry Torokhov Thanks. -- Dmitry