Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180412224111.35216-1-swboyd@chromium.org>
In-Reply-To: <20180412224111.35216-1-swboyd@chromium.org>
From:   Evan Green <evgreen@chromium.org>
Date:   Tue, 17 Apr 2018 00:08:27 +0000
Message-ID: <CAE=gft5Wo0JDk0+yN4LuEg-=xXXPecKxF8if9ksAXZrh+08QLA@mail.gmail.com>
Subject: Re: [PATCH] soc: qcom: cmd-db: Make endian-agnostic
To:     swboyd@chromium.org
Cc:     Andy Gross <andy.gross@linaro.org>, linux-arm-msm@vger.kernel.org,
        linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        msivasub@codeaurora.org, Lina Iyer <ilina@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 12, 2018 at 3:41 PM Stephen Boyd <swboyd@chromium.org> wrote:

> This driver deals with memory that is stored in little-endian format.
> Update the structures with the proper little-endian types and then
> do the proper conversions when reading the fields. Note that we compare
> the ids with a memcmp() because we already pad out the string 'id' field
> to exactly 8 bytes with the strncpy() onto the stack.

> Cc: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Evan Green <evgreen@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---

> Changes from inline patch:
>   * Fixed magic
>   * Made function for memcmp()
>   *

>   drivers/soc/qcom/cmd-db.c | 116 +++++++++++++++++++++-----------------
>   1 file changed, 65 insertions(+), 51 deletions(-)

> Sent by a computer through tubes


Reviewed-by: Evan Green <evgreen@chromium.org>