Received: by 10.192.165.156 with SMTP id m28csp1536543imm; Tue, 17 Apr 2018 00:35:31 -0700 (PDT) X-Google-Smtp-Source: AIpwx4913G+r6f4B/GpCxoCTJCKnQhMGEGHoUR/s3D/OMohv0OFF1OnW+5JeNe7slgtPOaSrs8tQ X-Received: by 10.99.107.65 with SMTP id g62mr908826pgc.180.1523950531294; Tue, 17 Apr 2018 00:35:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523950531; cv=none; d=google.com; s=arc-20160816; b=qMJjZR961rTGkTmy2lNRkfawlMOPfnDJk+DHbpgoKSXqROHp7GooaGWgX+vyV+nNB/ /tmry+hNeIherk78LrDJNNvGZVwW/30BPYW9hn+bhKw0r0XYEGmKHfXIWACVS33H2Z4h TPyABKRWCLazAmTiJivQZQ6Kj3G6phpE72y0gzpeHA3UBhGLB175qWwo1G/iKQbJNP1x KSKo/W/vt3EWBLvK5Enc2u4fdOUxFKLkeQrfPlcr7yyBNZVQI5A+0XySVnrQ2po5mUyl LHEuTIaK8YSPu+VEANgrfJ/vqFYBE52maGrxv/rlyzDLbmyFKnQ9t6Pr3kNcc12zzZ4v R0VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=4G49RiMKjNzsJMCdo4x06EX9Z9nVktrUfmNZXLNWAlk=; b=F5qfWijq4zOEcxk5xoI0tFKbbfTylMKrvGxxl7klWJ+niewDjQPAU6pUxTDW5QDbD7 eQwReSEoyadgVWpzcTDYyBbeAvPZhlT7CGHRJm+1jqUq2lOQhy/PWrgNZJw9hUvEPIwj i+n0LoSlaZerVqfrnSsOLcFVjonFJ/P2i4bwVXldisY3+UkmUtK5SW38lxwAF+qBmuxk vKHJBnxqm+27+6aDRRGN8GgY/T9P6bbhq52+heV8ac3jkhdiV+okrJ8KNWhhJLT1Mk2S J912kignNW0A1FFAksu6iLl2aVGYNX8sYqaegvmQNDQTZsMMAgBdmOb0x7elBbDsywPG lk6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m63si11450011pgm.302.2018.04.17.00.35.17; Tue, 17 Apr 2018 00:35:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbeDQHdj (ORCPT + 99 others); Tue, 17 Apr 2018 03:33:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:40294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbeDQHdi (ORCPT ); Tue, 17 Apr 2018 03:33:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3BF0EAD91; Tue, 17 Apr 2018 07:33:37 +0000 (UTC) Subject: Re: [PATCH] xen: xenbus_dev_frontend: Really return response string To: Simon Gaiser , xen-devel@lists.xenproject.org Cc: Boris Ostrovsky , linux-kernel@vger.kernel.org References: <20180315030803.27781-1-simon@invisiblethingslab.com> From: Juergen Gross Message-ID: <8eb5cb63-c733-a543-be6d-cf7348f5092a@suse.com> Date: Tue, 17 Apr 2018 09:33:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180315030803.27781-1-simon@invisiblethingslab.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/18 04:08, Simon Gaiser wrote: > xenbus_command_reply() did not actually copy the response string and > leaked stack content instead. > > Fixes: 9a6161fe73bd ("xen: return xenstore command failures via response instead of rc") > Signed-off-by: Simon Gaiser Reviewed-by: Juergen Gross Juergen