Received: by 10.192.165.156 with SMTP id m28csp1573992imm; Tue, 17 Apr 2018 01:27:19 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/DSQ0zBP8GAT4jPBjpZhdrMSYpNWt2NbkWEL3ZeW4t4UCeF3tZ6vvEvbyrPSiwA/rt+05j X-Received: by 2002:a17:902:f24:: with SMTP id 33-v6mr1219007ply.242.1523953639420; Tue, 17 Apr 2018 01:27:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523953639; cv=none; d=google.com; s=arc-20160816; b=H3yh1WGdVd6bK/rB1vKxjJ29Pl/E7De5AMtE09lY17vfxCkcOmSCryLJG0B9f17Y6P qe4I/aq9E57ao8W30nt0VKxBh4Tvr+4kF+xRKV1ONdmJp9VdRumVh/87/Ldx032eu2yo jUfJ1VisEt8SgxjLvAOsjpAcGcrgIjcFHpgi14g8jfZYF7b4azbl6MyEY0g4E+eKYY8r mzn+e3bfqViE6wFERokbWtLWWwyhd6bnL2caHjmdFG8Xbq1Zkb0StUghESQmZa8sEoqI ifEyRZ8E5Li9c2GxDqCKgc+sW74Z15fiHklZjZRor5vbf3LFs9FWjHTFYv6IDwxcXOlD +lmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=yuBGwUMxSSx6ydJKOPHNc3h4arAcEQgR+dfWOd3vU0A=; b=DcWxq7AGZYUS92rYWWZboucoe914iABD5pQxKhMQs8OnDHL9CfYsaVSwASDyM5BIyY Vb+5CV4h08CUR1hjVjxqI9Bbvg2gKDSzKfKuH7p+ltZIkcFWrq1CNNj/vPQmK+SyX8sH NX/mlplFDeKl+FTukP0oY1sLfO9LqwYPGIb8NnvVDpzLd1S67yGVg9MGdioBfMRp+62W TCCa74EM3YPSxTHVPrMj9QDY8UqiTF2VsMQqotTJWWo2orS03MJz7T6XDsMd0tyyvXxp g9jqATsjgIuiubTynjCX4NLVORGmv0GgWB+xqHh7ohgUhKX+tEAO5cohzWNLa8EmacDo KTTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si13216189pff.24.2018.04.17.01.27.05; Tue, 17 Apr 2018 01:27:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbeDQIZa (ORCPT + 99 others); Tue, 17 Apr 2018 04:25:30 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:6186 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbeDQIY7 (ORCPT ); Tue, 17 Apr 2018 04:24:59 -0400 X-IronPort-AV: E=Sophos;i="5.48,462,1517900400"; d="scan'208";a="13885648" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Apr 2018 01:24:57 -0700 Received: from [10.159.245.112] (10.10.76.4) by chn-sv-exch02.mchp-main.com (10.10.76.38) with Microsoft SMTP Server id 14.3.352.0; Tue, 17 Apr 2018 01:24:57 -0700 Subject: Re: [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1 To: Romain Izard , Felipe Balbi , Greg Kroah-Hartman , Alexandre Belloni , Ludovic Desroches CC: , , References: <20180416093405.16612-1-romain.izard.pro@gmail.com> From: Nicolas Ferre Organization: microchip Message-ID: Date: Tue, 17 Apr 2018 10:24:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180416093405.16612-1-romain.izard.pro@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2018 at 11:34, Romain Izard wrote: > The use of GPIO descriptors takes care of inversion flags declared in > the device tree. The conversion of the Atmel USBA UDC driver introduced > in 4.17-rc1 missed it, and as a result the inversion will not work. > > In addition, cleanup the code to remove an include left behind after > the suppression of the support of platform_data to declare USBA > controllers. > > These changes have not been tested on any hardware, as I do not have > a board that needs to use inverted GPIOs. > > Romain Izard (3): > usb: gadget: udc: atmel: GPIO inversion is handled by gpiod > usb: gadget: udc: atmel: Remove obsolete include > usb: gadget: udc: atmel: Fix indenting To the whole series: Acked-by: Nicolas Ferre Thank you Romain. Best regards, Nicolas > > drivers/usb/gadget/udc/atmel_usba_udc.c | 22 ++++++++++------------ > drivers/usb/gadget/udc/atmel_usba_udc.h | 1 - > include/linux/usb/atmel_usba_udc.h | 24 ------------------------ > 3 files changed, 10 insertions(+), 37 deletions(-) > delete mode 100644 include/linux/usb/atmel_usba_udc.h > -- Nicolas Ferre