Received: by 10.192.165.156 with SMTP id m28csp1647145imm; Tue, 17 Apr 2018 03:04:01 -0700 (PDT) X-Google-Smtp-Source: AIpwx49YZpLZ/AQgGyZrBHZkx8n6qCMfMz/nAzCV4Pj/WHMJFCU9LV331ah4uhgt+W0IRCqje3aH X-Received: by 10.98.69.142 with SMTP id n14mr1421375pfi.42.1523959441180; Tue, 17 Apr 2018 03:04:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523959441; cv=none; d=google.com; s=arc-20160816; b=HfoJdmtJGWsAHW9uOqrwW9Xc9xe671HwWPIbH2d/Iqgh9ce+hYT22i+FlNMWoLYIlg /CTZT5S+yVQRVGl4RCgS7GK8vh09mjHBjYbixKKYstSpVnF9H9nVe4D7Ic27EQ+Hu/lm aoDC5VtSl9GjQXbs1oTZOQsVdzGAWriNjCkIcvAfQFZCDdDLow6uasySu5Hs5E/FSqsh /g3sjFB8BXobO87zQQP60UI+fsMweMNvvqYz2cogzxSAZuaAYOKWDxQ1yqmRrt4frHnJ TLmDu8mLLJakdv8XOfcd07O0iyOTlMCyaE4aX6H++EbzvoEo9j5VS6Doi5W139Z9okb+ hllQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject :arc-authentication-results; bh=fE9MBSkQUaGpPVu41IXUfTRD2Rac2Dy7I76yD/sSi9M=; b=pG1cQPj1el/M9cwPCyLmTJQKg0LvyCLvJH5lAT4LQec6pihEzSkwRNaO7hqfG6jRVn 5NCG6GA/msyesyhLMeAqJM8GkuRlma+kWd8M6X0T8Y/N6emmEzs/axJSVtVHs8038xIr /c7geQu+DgJkusw/xKDPzXF//EDS/d/EbAXQXUL0oVcN4Rr7K0QBitcq5pXZADMZX32j Pl4wccMbSiW0ooCHq86L0+oqFI2OVS+dyh7QBp+7eH5fw92baYuj9NNcQLP/iqHWJl5m ZIJUtazP5j4oTU0Ys3wQn3m50Ep38RyELAqBqI1iUOjMkgRmbW433FI7SOAL0llaemIU td3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b123si12554559pfb.189.2018.04.17.03.03.47; Tue, 17 Apr 2018 03:04:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbeDQKC1 (ORCPT + 99 others); Tue, 17 Apr 2018 06:02:27 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43262 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbeDQKCY (ORCPT ); Tue, 17 Apr 2018 06:02:24 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3H9xWx6076245 for ; Tue, 17 Apr 2018 06:02:24 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hde8dsp1n-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 06:02:23 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 04:02:21 -0600 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Apr 2018 04:02:17 -0600 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3HA2GAi10813760; Tue, 17 Apr 2018 03:02:16 -0700 Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC7C87803F; Tue, 17 Apr 2018 04:02:16 -0600 (MDT) Received: from jarvis.ext.hansenpartnership.com (unknown [9.85.138.139]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTPS id DEA6078037; Tue, 17 Apr 2018 04:02:11 -0600 (MDT) Subject: Re: usercopy whitelist woe in scsi_sense_cache From: James Bottomley To: Kees Cook , Oleksandr Natalenko , Jens Axboe , Bart Van Assche , Paolo Valente Cc: David Windsor , "Martin K. Petersen" , linux-scsi@vger.kernel.org, LKML , Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , linux-block@vger.kernel.org Date: Tue, 17 Apr 2018 11:02:08 +0100 In-Reply-To: References: <10360653.ov98egbaqx@natalenko.name> <2864697.7uzmEJovl2@natalenko.name> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18041710-0012-0000-0000-0000160E3E42 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008870; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000257; SDB=6.01019158; UDB=6.00519913; IPR=6.00798399; MB=3.00020614; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-17 10:02:20 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041710-0013-0000-0000-00005252D917 Message-Id: <1523959328.3250.11.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-17_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170090 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-04-16 at 20:12 -0700, Kees Cook wrote: > I still haven't figured this out, though... any have a moment to look > at this? Just to let you know you're not alone ... but I can't make any sense of this either. The bfdq is the elevator_data, which is initialised when the scheduler is attached, so it shouldn't change. Is it possible to set a data break point on elevator_data after it's initialised and see if it got changed by something? James