Received: by 10.192.165.156 with SMTP id m28csp1654001imm; Tue, 17 Apr 2018 03:12:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+2Cq2Mkv9HxiPr8+5ipjPIlAh8WbdcMesz2biq/TBTzYZLcmhSSKZMQp8QeMt5JhRNR0w3 X-Received: by 10.98.104.199 with SMTP id d190mr1405859pfc.111.1523959933187; Tue, 17 Apr 2018 03:12:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523959933; cv=none; d=google.com; s=arc-20160816; b=YainHML9pgUG/MrTIaGbaNw0jQoo1CgUADICO9iEiQUEb23uWCvHwtk6rSxForWiiX x9Yrm4p2OzVTFDHt5WNBW3b+AuBukXe5zCeG80jkiJZJXjPWK2mUmJlmvDWhG1WC/xYy +lBmj31VimTH3MNXQ2js+8Xub76jKaKI8I2ebLQDXQRM4WYq/zIrvCLIpoPysY3x6A3g +PWpCrbdBIdD8ZaWsVBnknjkL/1vkMujEYK3/UYHdM8opLivinx2msaqFt4GN8wbkdfU w3hp+PjWSYgI9gseE7yvfwVjNEEkfOdjECno06ZHiI6/0bWRnZYOpJLBIx0j9SZsJt4X S6ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=8W22CP/jWiZ87GvfL1q1IsVGM9BqWZV9iiJ6tcxpALc=; b=z0kbkEfaAO4nFvF1FndDM0xwWtdOxX3CQPG4evWuPyZDXz0Br9aTMtjoQ3LyWhaflL VheU2aUgsS3p9/Gpk6MKzX+1YF3gM74r/WDseJ1hjwNODpVpWsoQa3gEyvYx5gdsRUvM WEINSCqwMqYXrSKBVpPn7RURdFNbB6Xfkju/9BV/ZPwj+PEEvkuDL2Z4q5yChLIUJFGo VaOkNwaua1UJgJqbJXBqb2/pPOiQxMKyDPHzmEBOUNgumKk2Ai4QI14czHGE/XnL6/SL gHyzB7Sp94VNqikL+3g//v3ngCBhePw5trfpmSBOOVHHzgLOcWGb0T0WlFCghd18zZd5 DJWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j23si6551193pfn.63.2018.04.17.03.11.58; Tue, 17 Apr 2018 03:12:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbeDQKKv convert rfc822-to-8bit (ORCPT + 99 others); Tue, 17 Apr 2018 06:10:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752086AbeDQKKu (ORCPT ); Tue, 17 Apr 2018 06:10:50 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 81500406EA4F; Tue, 17 Apr 2018 10:10:49 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77DC82166BAE; Tue, 17 Apr 2018 10:10:46 +0000 (UTC) Date: Tue, 17 Apr 2018 12:10:44 +0200 From: Cornelia Huck To: "Harald Freudenberger" Cc: Pierre Morel , Tony Krowiak , alex.williamson@redhat.com, alifm@linux.vnet.ibm.com, berrange@redhat.com, bjsdjshi@linux.vnet.ibm.com, borntrae@linux.ibm.com, fiuczy@linux.vnet.ibm.com, heicars2@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, kvm@vger.kernel.org, kwankhede@nvidia.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, mjrosato@linux.vnet.ibm.com, mschwid2@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com, pbonzini@redhat.com, "Reinhard Buendgen" , thuth@redhat.com Subject: Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization Message-ID: <20180417121044.5c8f2182.cohuck@redhat.com> In-Reply-To: References: <1523827345-11600-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523827345-11600-4-git-send-email-akrowiak@linux.vnet.ibm.com> <4fb50a31-1893-5cfb-0f35-fb2501c2afa8@linux.vnet.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 17 Apr 2018 10:10:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 17 Apr 2018 10:10:49 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Apr 2018 09:49:58 +0200 "Harald Freudenberger" wrote: > Didn't we say that when APXA is not available there is no Crypto support > for KVM ? [Going by the code, as I don't have access to the architecture] Current status seems to be: - setup crycb if facility 76 is available (that's MSAX3, I guess?) - use format 2 if APXA is available, else use format 1 From Tony's patch description, the goal seems to be: - setup crycb even if MSAX3 is not available So my understanding is that we use APXA only to decide on the format of the crycb, but provide it in any case? (Not providing a crycb if APXA is not available would be loss of functionality, I guess? Deciding not to provide vfio-ap if APXA is not available is a different game, of course.)