Received: by 10.192.165.156 with SMTP id m28csp1711912imm; Tue, 17 Apr 2018 04:21:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx49AgrbK09c1RtfPMolxUAR7ksN6alk7EB+WBsmNsBpj4tkjs6f2OBnCnyYhLrgF/O7d5tCF X-Received: by 10.98.32.80 with SMTP id g77mr1611712pfg.216.1523964073393; Tue, 17 Apr 2018 04:21:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523964073; cv=none; d=google.com; s=arc-20160816; b=DhFuwn96hkdpTpdWMOlh5CuezasRC9tMYzy2m5sFEXzJLtjLihsjzznBd9AKRS2o1f LGflk+w+VV+rKyRQeuQyIOyoqJtAxNYjYMZGpDeyqJwf2wlIky/SLPXxhro7Y7a9bpJF awlmP1BlST0nW9s0MnOPe7Hil+zNwoJPSZbkSxfVaeE+XfcUpkKdrZ1SD+6cuVp+8GfT NE1l50b2z73gdZx6yUVv0ljTm19Sq4n16COY61DfaBF5H4aQRKmizz304OoPQxTXKfAY 8dvMAdhM8duyv2LefOQ9D4+NAedtJUUSr9DEtdL5Bl2jnVlqDyNsoVsydurNsHYh8Dd2 0LjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=TNnKZ8VQI9oZGvFDNHqvCCKcn3zl+MnPTJYLlE1Sdd4=; b=up6Yb6dJQ41uDVIL/dYwM297V7nWOj3UBE/MTBapD5NVmYEhxejKTf2x6Kl86+RpX7 xAxVMLDggZ66RDR7P4JFKlyLtHVnu/GkmMbmMfIoIEtBChpixjCRQG8K1ea5TsF4t0nQ 6F1gozgE4lTlaB8uKhVSjMSiiXKQzeLBhrk8Q9ZJ++Jtx1dpMjlLEW4nXbq+Pm+iSj3t 6q9L4qm3dWAiX5mAskGaSHYauZE0qPphN+h4e/8cab2Jc/8Gt/jEd7hRkLG4gyM850KK QPpw5vSoVTyvt92Hm2QYCaBGaE4RHcs18Lc/L1S0/s0mnk3cbTIm3WU/veSPskgzH5Vq 19XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si2246757pgv.186.2018.04.17.04.20.58; Tue, 17 Apr 2018 04:21:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbeDQLTQ (ORCPT + 99 others); Tue, 17 Apr 2018 07:19:16 -0400 Received: from mail.bootlin.com ([62.4.15.54]:54783 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbeDQLTO (ORCPT ); Tue, 17 Apr 2018 07:19:14 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 9EE1720D97; Tue, 17 Apr 2018 13:19:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 6DBE520893; Tue, 17 Apr 2018 13:19:02 +0200 (CEST) Date: Tue, 17 Apr 2018 13:19:02 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: =?utf-8?Q?Myl=C3=A8ne?= Josserand , Russell King , Marc Zyngier , Mark Rutland , Rob Herring , Simon , Geert Uytterhoeven , Magnus Damm , "open list:ARM/SHMOBILE ARM..." , devicetree , LABBE Corentin , Quentin Schulz , Thomas Petazzoni , linux-arm-kernel , linux-kernel Subject: Re: [PATCH v6 08/11] ARM: sun9i: smp: Add is_sun8i field Message-ID: <20180417111902.4u6d3mxehxjqibe4@flea> References: <20180416215032.5023-1-mylene.josserand@bootlin.com> <20180416215032.5023-9-mylene.josserand@bootlin.com> <20180417075233.f2z6wxcazwqheoib@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mgjhdnizrdjxc2v3" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mgjhdnizrdjxc2v3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 17, 2018 at 03:57:07PM +0800, Chen-Yu Tsai wrote: > >> @@ -697,6 +700,8 @@ static int __init sunxi_mc_smp_init(void) > >> break; > >> } > >> > >> + is_sun8i =3D sunxi_mc_smp_data[i].is_sun8i; > >> + > > > > Do we really need to cache it? Can't we just have a pointer to the SMP > > data structure and use that instead? >=20 > I recommended that. We don't need any of the other fields in the SMP > data structure once we're past the init phase. This saves a dereference > or two. Fair enough. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --mgjhdnizrdjxc2v3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrV2CUACgkQ0rTAlCFN r3QFRw/+JjrjBNJt+HNnDm8GaE7ITOndVszG5cE5okgfzSBft3JehFRr3mfM6d0I 9dhnN4pMpELEyf6ElSqCd60wKPpVaEzLZ/XvOHIHKi12SqoZbSJ05A0DcDLwolyv FD7KRCd4336kERulK+tGnxkv3FOR2q9mPvqXtpehwVoI0z3rNu2HxnpDnfbKyXyD PTYNtFCU+04O+hY4WNZPdW0bBFevzKqxCI0ZLpAfx9UILeHh6Mdd3WBXINnPpffw B/XJ1m9vhtsQtnUiIpXF9+B6nJ6UPInU/gzmyIHEUetV26rN0eUm6beOPHOgiuLu Et5JDY0MNwqQWf5R76OqFJ7RtqkUZ9jiJM/g5RJdXSf3NUTesKRqOYWXnAMVowRy tO6y/KYhqoyZ4nUQ+kA0wx7spNUoVFjU4Tc8/SfZBGjKFjczWaax83m7/JgjZrk6 ItAvTWcR7EhtBrD6gMUspHssLX0/0czjzMflEdgFVteSWiWHxbE0T4B1GWA5AKpM 8TofCx0JKMcJ2kugCI2h4CPs+8Od0DbzLzhzAltc/+H4wU0oIyRiH+HDDy0g2wBA UB8s8aJWofnKwHRzhyW+wZDqYYHPwo1LdG0Y7fZRnGKZMWCk+JmjD42ZDfv9jtb7 zM/XN6mdfXvsHw+VYBop1IoNF896m83Q85LVrXDdZGQCLnSFWqA= =2G36 -----END PGP SIGNATURE----- --mgjhdnizrdjxc2v3--