Received: by 10.192.165.156 with SMTP id m28csp19466imm; Tue, 17 Apr 2018 05:57:47 -0700 (PDT) X-Google-Smtp-Source: AIpwx485H66VYgUMel1wnXezubVB7HQKxxSnBrcuFZPYqj1J8D6bgHxMCLJb3Lwd7a+wd06lLSW2 X-Received: by 10.99.126.88 with SMTP id o24mr1750341pgn.325.1523969866972; Tue, 17 Apr 2018 05:57:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523969866; cv=none; d=google.com; s=arc-20160816; b=aASK81SPDrowU1JXLaSyOc0Nu+DRRaO24c8XCLtSI1yAgz12W5skWlbD78tL4N6syQ F9w2XAOrg5OeEBVXVeKBRtuEeLYfV/dpBbSsY3kPDCpExgQOP+1CUudwPlh0Um/awTS6 U1HvFW1tB/eoKg6m83G8FL2ibZYKJQPGE/O2nrHlt84ex7CiPKO4g2HUCRy4cr3kclEe BNiVj0/kcLVeZdIyEjihb/TQtG5vcQr3VFbPfwhkxQ2RyQGS6nWi+IgN6tMIC6PY7FRI efgwZg386pEjOA5DU1U3gBbWHKRCUPe5rVyuiBeDATkmx2Di4tI/TVODwrqAOYSYRb05 Mhmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:arc-authentication-results; bh=MR3ZG0PF/qt8SAXA1u9GaSZurAYmSqsi9I2YJbOdXUs=; b=hPU5/IM6caZm103EqH45XI8DBD3OD8eMuFTxH4U3Vjg6PXziHAq4IQe2pwSFIR+OCK 4gA+KVLPA1LEsXcA8f8VTXgxb+jBvTgqHmppQYJbv44SygfalJEBunUVfo6Y4m1txvjU hIV7ibMMZP1y5Kbfd93D0TckPysJJf3lGCdiJom7O1XUGef7yYZlzc+2lyDsHX/Zd3i1 6uB9zmW3SM+G0TG1xg7DGH3Sa1bRKZS6XYqEddyAZRcQoklMs0xmP7CO+rUop3x470Zs YUh6lc32xTiGd6KKX5YRpmGoleORL2/YUBONw17qn03AVPy+0UcxubYghQ/FwG/gn5pf rG5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n76si13039767pfi.122.2018.04.17.05.57.32; Tue, 17 Apr 2018 05:57:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbeDQM4G (ORCPT + 99 others); Tue, 17 Apr 2018 08:56:06 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:33109 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbeDQM4E (ORCPT ); Tue, 17 Apr 2018 08:56:04 -0400 Received: by mail-qk0-f173.google.com with SMTP id d206so20069301qkb.0 for ; Tue, 17 Apr 2018 05:56:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MR3ZG0PF/qt8SAXA1u9GaSZurAYmSqsi9I2YJbOdXUs=; b=OHcfywX/t2sdmGnS2O5EuzdgBMg5+wdYy7y2ssLWGTBo6SFfZBoAFbOEREexf0AtV4 qegMXw86VAYSQMZNpjfr+kuSAKZpSOVPQfb/QLxVB1xjO26tAU1Evg07FyHt4d08qye6 YPATW/y7q0eZuacw54klR1mSL59a+lSK2telOd2/7k7SBsBInMCeTPn5dmkbpaeg5Yq3 mUX85gS5ddeiFqcSzR2oLddBslMEjStY7//j9JlU3Kny3uEIkmhBwMALC9xn5v7o3loY P9kswt5t8KkAtdffzmE3xO/grQozw0JtxmV4PqcekjdyWfQbriGxbOtbpKu1tXGsfDHH vH7g== X-Gm-Message-State: ALQs6tD4mtIBZJjb9zGB8+cfO34NC0T+++G7x2/S5FDh8zgOs2vzA8tG OQYdvGK5T/273Xd9/jk9V9wT0ft1PmA+5QIwlyQtNA== X-Received: by 10.55.80.6 with SMTP id e6mr2242491qkb.191.1523969763680; Tue, 17 Apr 2018 05:56:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.22.131 with HTTP; Tue, 17 Apr 2018 05:56:03 -0700 (PDT) In-Reply-To: References: <20171208142818.15156-1-benjamin.tissoires@redhat.com> <20171208142818.15156-3-benjamin.tissoires@redhat.com> <20171210222926.GB11027@jelly> <20180416235156.GE77055@dtor-ws> From: Benjamin Tissoires Date: Tue, 17 Apr 2018 14:56:03 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found To: Jiri Kosina Cc: Dmitry Torokhov , Peter Hutterer , "open list:HID CORE LAYER" , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 17, 2018 at 2:11 PM, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > >> So what is happening with this series? I think we should get it them >> in; there is really no reason for bumping ABS_MISC till it gets into >> ABS_MT_* range on some devices that are out there. >> >> FWIW >> >> Acked-by: Dmitry Torokhov > > Sorry, I somehow lost this one. Now queued for 4.18. Thanks Jiri, and thanks Dmitry for the reminder. Jiri, BTW, I have 2 patch locally that should mitigate the negative impact from this patch if there is any, While trying to merging hid-multitouch into hid-core, I came to realize that hid-generic should probably split the HID collections by applications. If a device has a joystick and a mouse collection, there is no point merging these two collections together. This is the most common use case for reusing the same ABS_X value in one device. I'll try to post the patches today, though I have some internal deadline :( Cheers, Benjamin