Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261306AbTHSWmg (ORCPT ); Tue, 19 Aug 2003 18:42:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261307AbTHSWmg (ORCPT ); Tue, 19 Aug 2003 18:42:36 -0400 Received: from zero.aec.at ([193.170.194.10]:21766 "EHLO zero.aec.at") by vger.kernel.org with ESMTP id S261306AbTHSWlt (ORCPT ); Tue, 19 Aug 2003 18:41:49 -0400 To: "Pallipadi, Venkatesh" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH][2.6][2/5]Support for HPET based timer From: Andi Kleen Date: Wed, 20 Aug 2003 00:41:20 +0200 In-Reply-To: ("Pallipadi, Venkatesh"'s message of "Wed, 20 Aug 2003 00:20:12 +0200") Message-ID: User-Agent: Gnus/5.090013 (Oort Gnus v0.13) Emacs/21.2 (i586-suse-linux) References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 31 "Pallipadi, Venkatesh" writes: > /* > + * Default initialization for 8254 timers. If we use other timers like HPET, > + * we override this later > + */ > +void (*wait_timer_tick)(void) = wait_8254_wraparound; It would be much cleaner to just poll the generic monotonic time source here, not add more special cases. > diff -purN linux-2.6.0-test1/arch/i386/kernel/time_hpet.c linux-2.6.0-test1-hpet/arch/i386/kernel/time_hpet.c > --- linux-2.6.0-test1/arch/i386/kernel/time_hpet.c 1969-12-31 16:00:00.000000000 -0800 > +++ linux-2.6.0-test1-hpet/arch/i386/kernel/time_hpet.c 2003-08-18 20:22:06.000 000000 -0700 Shouldn't that be in arch/i386/kernel/timers/hpet.c ? Also I suspect it should be made an generic timer object there with a timer_ops structure. If some hook for that is missing it could be added to timer_ops and timers/timer.c When there is already a generic framework to add new timers it would be a shame not to use it. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/