Received: by 10.192.165.156 with SMTP id m28csp81309imm; Tue, 17 Apr 2018 06:55:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx48UpSDdN1/1bJQm2GVXFF3fHKccAnxSTQfipABhKUq1C49vZJk/HUKwsNYY/69T7evtITdT X-Received: by 10.98.109.66 with SMTP id i63mr2072616pfc.233.1523973312789; Tue, 17 Apr 2018 06:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523973312; cv=none; d=google.com; s=arc-20160816; b=fk5kuqo4ubWr/nTrqy4WjmVKn8Yb+/MVAOcXKMToNhUsijMGUEAifnNrxgTl8GGFYw z5lGJzqpSHMNm0SmN1eRUMZRHmjwFVTcp+zLzQwaivd2dPIm8szfx08R+7gg6yTwLrGG 7XRAfrAmPFeAG1XsKOlhJmlOy9EcpFcZ5Nstljoqht4nHCH/fZedWfkyP3Kow76U64x1 iZT3f4uhELfo1UCC5vjF/lac3eZV3nJCSidEWJZaRmnfIVlH38OwQ6a3wuvliGWgDboj 8+6GN/HmidpNQU+2C+3BpduuICAEr0IhIMMmqZMQY4qveZqxkk2l5OPBmCIzwBoZt9f6 MaIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=jj5kpehnkBhQgr+wOz5AGqf2jrCO4uE/9C97+oqZy3U=; b=SQmB77dc3sZzAdiuSfsZdckd2Ufu2MyLaaiusC6jBs4W/ah9FTmer0HbIoIo4P6lMU GOAuzZZzUfm1YYq4/4TO29+U0CUERjmOTVmolzOD0rkCyPYfLAxJRaEsvN0gqFN9pcdg sf/VcdfXyk2r44QUu3TlPSJj7aBIomwLuzMXOJ3kKjSxfkVayRfwKxNStX2SThX2w+CB Hg7NP5qYOLT73QJHXim7mCCF250/wUB/phrLndc4BOxDVhBvfAg2oRDSR4+z0lnQUEuK hihMqgyhNDCit9ah1Jdurrh6CYHGURhN59QjhyWddJYpFB3CUH4s02NbbrNWWQt1VZgo sVzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si13808963plz.279.2018.04.17.06.54.58; Tue, 17 Apr 2018 06:55:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703AbeDQNxg (ORCPT + 99 others); Tue, 17 Apr 2018 09:53:36 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55380 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753636AbeDQNxe (ORCPT ); Tue, 17 Apr 2018 09:53:34 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 548DF141714F8; Tue, 17 Apr 2018 06:53:33 -0700 (PDT) Date: Tue, 17 Apr 2018 09:53:32 -0400 (EDT) Message-Id: <20180417.095332.47355231483878538.davem@davemloft.net> To: rafalo@cadence.com Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, piotrs@cadence.com, ltyrala@cadence.com Subject: Re: [PATCH 0/3] Receive Side Coalescing for macb driver From: David Miller In-Reply-To: References: <1523739187-20077-1-git-send-email-rafalo@cadence.com> <20180416.110855.61732218036810337.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Apr 2018 06:53:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafal Ozieblo Date: Tue, 17 Apr 2018 08:59:35 +0000 > If IP supports RSC and skb has 2B reserved for alignment we end up > with none packets receive correctly (2B missing in the each skb). > We can either leave few customers without support in Linux driver or > let them use the driver with decrease performance. You probably want to find a way to memmove() the headers to be aligned in this case, and then point the data afterwards into SKB page frags.