Received: by 10.192.165.156 with SMTP id m28csp113836imm; Tue, 17 Apr 2018 07:23:37 -0700 (PDT) X-Google-Smtp-Source: AIpwx49qLBVdEBi6ubOXQ7y4nmOA55ss4xfzBvvOmtKk6PKmEh1wU006w9npWJil5x+Lm0bTrqSM X-Received: by 2002:a17:902:9042:: with SMTP id w2-v6mr2241992plz.34.1523975017639; Tue, 17 Apr 2018 07:23:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523975017; cv=none; d=google.com; s=arc-20160816; b=N2viw2B8nC/FEEiFmQnHYBVgjGtPGYGaY+JcoSLwHoNLqFbyTAtZSISWMm5vcfWALH re9nk+8TNKTpRx6F2lfcOLswPIMsgkxip+xR6YxmUJoKz8f9LCOdu4gbiOaybvtyNQzS oGxrKEN+gxePKQOSNtr1vD34BGooW4esvRZgV35PcWzksEdAgFwS5354BAABxq9Oh4s3 Arec40BXqfg0G+QW5dyeKk1MOd+N615ZQcCN0hAdVyBw23EEFcRYdRrDwm26I+2O0qob UMUaRoENLf3lygnUz4h6vR6pr2O3HOFF7JPoWmwj9V6jDZUSdkw0JsZODe97HSikNN5W +bsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=NIKG0JO+7siHQM+VXTtVerkatFOUTAHv5yQDTae82Wc=; b=UR98jVamlBJpO2FARl548oQ3Rz5SDtji00XXizo+5UMHrl5xjxLPJhaVYpg8St4lfR equOfSKHG5Beyonc8jtKn6eGX4kuPnthA5FN9NS9SEC1fIxdMEhr66ea0W/4IEeHqdeF S0wVx8nT6BhC+rO54Qf5/MXMgbhf99qc9ENigLn9GUxDicdCY+cSgXCMH6wJrusf/tz6 x2N1eR9UXezjOAayOZo/ArEGDPKsXBoHQqXdh1bU2XbIquaRZNYQc8wi6BlWEoiZIG8l oxZsLgrOMjFkPPZ5A+bJWwvppIZDTF1/wVCAF9nYY9dyWJxV2UJYZsvtixZWNciX31nD H8oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj11-v6si14377900plb.480.2018.04.17.07.23.22; Tue, 17 Apr 2018 07:23:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbeDQOVf (ORCPT + 99 others); Tue, 17 Apr 2018 10:21:35 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40912 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751270AbeDQOVd (ORCPT ); Tue, 17 Apr 2018 10:21:33 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0014E44B5; Tue, 17 Apr 2018 14:21:32 +0000 (UTC) Received: from localhost (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 795181C4C3; Tue, 17 Apr 2018 14:21:29 +0000 (UTC) Date: Tue, 17 Apr 2018 22:21:25 +0800 From: Baoquan He To: Bjorn Helgaas Cc: Philipp Rudo , Michael Ellerman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman , Thiago Jung Bauermann , Dave Young Subject: Re: [PATCH v1 0/2] kexec: Remove "weak" annotations from headers Message-ID: <20180417142125.GE1750@localhost.localdomain> References: <152355706051.36693.9856090891621551967.stgit@bhelgaas-glaptop.roam.corp.google.com> <20180413110820.662d4879@ThinkPad> <20180413092908.GB2119@localhost.localdomain> <20180417140714.GF28657@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417140714.GF28657@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 17 Apr 2018 14:21:32 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 17 Apr 2018 14:21:32 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/17/18 at 09:07am, Bjorn Helgaas wrote: > On Fri, Apr 13, 2018 at 05:29:08PM +0800, Baoquan He wrote: > > Hi Bjorn, > > > > There are changes I have made to solve 5-level conflict with > > kexec/kdump and also interface unification task, they will involve x86 > > 64 only changes on these functions, I don't think we need remove them if > > without any obvious impact or error reported. > > Removing the weak attribute from the declaration in the header file > does not prevent you from defining a weak function later in the .c > file. OK, sounds good to me. Then I have no concern to this, thanks. Will see if other people have comments. Thanks Baoquan