Received: by 10.192.165.156 with SMTP id m28csp114851imm; Tue, 17 Apr 2018 07:24:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/TEMTHA1rDhmtIv0UaSbKcKXGrN4QrHcjq/xNc3bhk+pwYN+t10ZbS9VePFpnoEgd5AB+m X-Received: by 10.99.62.201 with SMTP id l192mr1955911pga.318.1523975070028; Tue, 17 Apr 2018 07:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523975069; cv=none; d=google.com; s=arc-20160816; b=m4vTCpOc1lXphgtwMNCxhdqSZggeKx3HQ82ZqKZOF57nXV0/41qsrarBk0yTLCzeNB E62yIb7Uzz65McXUUqlrI9YV77fNO7Q8jWdTTYt2uHCAZl8QFiLBRfMmJFmqeUjezQJd NEURg3Soqt1jGQJq/6kcF8g0jMicMZjPMKGZhopKyrLagarYPkuiPbZDwo1Oxy0QxTUi LBKbx/grPyhRLSGpcDG3h3mkg2s/5mSqhDHEn6EVkJZOsjYCYvAtR/2ytUoAbPxLsh71 zNYq0uU/LTFGT/4qzrCOAA4FVA5UKpZyZKEF1+8mAK4bz2RzptjZjeI4LEVVcIop/Z07 O2hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=UJtgYIOooRtTO+CF3HdSkcwoP2ZwQnfAyY6YJ3g19j8=; b=NI/0hbmQ6sb/sFyrdf70CWkgPDfzaSBZvETGdqEcAuogV4zNs7qlUxqibH1G24imAC n8p5/r4EloAYJ/XMcbxxECMy7OuMUDxUwaWNxfZyuXtRTTmHcKskzYroDy/U6JZSAdFP wzutJpRue3BnZ9rFCplgHVCdVmigHW+VhCmBC6/FJl9y1w+wTQkxbHNVdSB9nKs6kFAV gU9zNMeGQD2hbznFXIZVr5kSqqM1APfWvpGa3twqdZy8W/gpxYs5EvdPaEmuyIMZrcwq RtQCxbzWT2OXIMXwuBVBww6iXuLmhEzYYXizgDLnj1gdT31shYnMJIEEP0uHTBw2bT0K IDkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1-v6si14711896plr.391.2018.04.17.07.24.15; Tue, 17 Apr 2018 07:24:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbeDQOWz (ORCPT + 99 others); Tue, 17 Apr 2018 10:22:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:54333 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbeDQOWw (ORCPT ); Tue, 17 Apr 2018 10:22:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EF873AC9F; Tue, 17 Apr 2018 14:22:50 +0000 (UTC) Date: Tue, 17 Apr 2018 16:22:46 +0200 From: Michal Hocko To: Sasha Levin Cc: Petr Mladek , Greg KH , Pavel Machek , Steven Rostedt , Linus Torvalds , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Vlastimil Babka , Peter Zijlstra , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , Byungchul Park , Tejun Heo Subject: Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes Message-ID: <20180417142246.GH17484@dhcp22.suse.cz> References: <20180416161412.GZ2341@sasha-vm> <20180416122244.146aec48@gandalf.local.home> <20180416163107.GC2341@sasha-vm> <20180416124711.048f1858@gandalf.local.home> <20180416165258.GH2341@sasha-vm> <20180416170010.GA11034@amd> <20180417104637.GD8445@kroah.com> <20180417122454.rwkwpsfvyhpzvvx3@pathway.suse.cz> <20180417124924.GE17484@dhcp22.suse.cz> <20180417133931.GS2341@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417133931.GS2341@sasha-vm> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 17-04-18 13:39:33, Sasha Levin wrote: [...] > But mm/ commits don't come only from these people. Here's a concrete > example we can discuss: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c61611f70958d86f659bca25c02ae69413747a8d I would be really careful. Because that reqiures to audit all callers to be compliant with the change. This is just _too_ easy to backport without noticing a failure. Now consider the other side. Is there any real bug report backing this? This behavior was like that for quite some time but I do not remember any actual bug report and the changelog doesn't mention one either. It is about theoretical problem. So if this was to be merged to stable then the changelog should contain a big fat warning about the existing users and how they should be checked. Besides that I can see Reviewed-by: akpm and Andrew is usually very careful about stable backports so there probably _was_ a reson to exclude stable. -- Michal Hocko SUSE Labs