Received: by 10.192.165.156 with SMTP id m28csp122420imm; Tue, 17 Apr 2018 07:31:43 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/RTM11VLXMlSoFkFtIIq5JvqL+voJBJxvgC1StSMUVsHpzCSJ2nfyxWX/gxhFfvFvBgPjl X-Received: by 10.101.73.68 with SMTP id q4mr2023567pgs.424.1523975503608; Tue, 17 Apr 2018 07:31:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523975503; cv=none; d=google.com; s=arc-20160816; b=AoH8ySrBCLqOTli+jiGO9sodWysZyfduJWPzI+X3jXuX4YdGuc8TtW4aD8AurWIvJh 0l4Pb79pZtr1fh7iCLV6IpZdL+VYIlhxRNFgkuMyUiRCKMlMztCVK7CEfRYWZGUuLLoD 8QGpvtq2CpB9+JNrfCyQ1hIhNrseKIiGEBH80jbaZGHO72ROpmgpMV50wPjiVZwW7eP6 2GOBWP1gWWVQNPztOXcAmVAa85qmd1LcXYRazaFll/A70+s5E0hwOEnMEspqzf1EwpEx KrtKjETcL/lbSgaKPEcg+c1jt5umFxycYZhTUZjEp6FW91JGhv14WMI4bwNRbLN2jY2p jFaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=CNiByh3SjNpKQs0gCjdpsV+vkcnCwvZNUGW+Hn72Z5w=; b=sY4zmQqNXgX5tiPlwF3gy1fk4d5Dr9rAADkYQM4RKbba2Okf1RGFvT+6wQPin4CYmz 6jQnfpRXz8MZ2E3BehRHM0w99UMOGd6ZypAl8KHo+Vbe+ujrZS3uJwp7UoB3huDivhPE ZnuZ79mfSvLkKCUa6EtT0GaEei+TL9euLl4UHBAHPHDU0HFrmq6bE7PYeFDRmS5n1qsZ UEu66GajXnnRwnP/2eyGjREmhA8F0N5TrCZzcWuD6NrUx4nnfraBKtPKIWfcPnUuvDy3 AcA8bhG7GogQJYsiQd+q6YBPzrmmca2hNho/Hh5kOSp6djA9MjKUzwCb+YfqevmTGfrf 0+Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si13686771plb.253.2018.04.17.07.31.29; Tue, 17 Apr 2018 07:31:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765AbeDQO37 (ORCPT + 99 others); Tue, 17 Apr 2018 10:29:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40642 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752634AbeDQO3v (ORCPT ); Tue, 17 Apr 2018 10:29:51 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3HESton089081 for ; Tue, 17 Apr 2018 10:29:50 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hdjb21kmf-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 10:29:48 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 15:29:46 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Apr 2018 15:29:42 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3HETfqG55771250; Tue, 17 Apr 2018 14:29:41 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6AA9FAE04D; Tue, 17 Apr 2018 15:19:31 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD14CAE053; Tue, 17 Apr 2018 15:19:30 +0100 (BST) Received: from oc3836556865.ibm.com (unknown [9.152.224.140]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 17 Apr 2018 15:19:30 +0100 (BST) Subject: Re: [PATCH v4 02/15] KVM: s390: reset crypto attributes for all vcpus To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1523827345-11600-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523827345-11600-3-git-send-email-akrowiak@linux.vnet.ibm.com> From: Halil Pasic Date: Tue, 17 Apr 2018 16:29:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1523827345-11600-3-git-send-email-akrowiak@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18041714-0008-0000-0000-000004EC4FF5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041714-0009-0000-0000-00001E8054AF Message-Id: <41496d07-54b3-5cc6-8803-a935f6d821ee@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-17_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170131 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2018 11:22 PM, Tony Krowiak wrote: > Introduces a new function to reset the crypto attributes for all > vcpus whether they are running or not. Each vcpu in KVM will > be removed from SIE prior to resetting the crypto attributes in its > SIE state description. After all vcpus have had their crypto attributes > reset the vcpus will be restored to SIE. > > This function will be used in a later patch to set the ECA.28 > bit in the SIE state description to enable interpretive execution of > AP instructions. It will also be incorporated into the > kvm_s390_vm_set_crypto(kvm) function to fix an issue whereby the crypto > key wrapping attributes could potentially get out of synch for running > vcpus. > Wasn't this 'issue' reported by me by any chance? I agree with Connnie, we don't need the forward reference to ECA.28. Regards, Halil > Signed-off-by: Tony Krowiak