Received: by 10.192.165.156 with SMTP id m28csp191270imm; Tue, 17 Apr 2018 08:35:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/EjKpwAHuanRoQCuL4kPkU9NDCiflkrOut+FNgpk40sP373ECxaWOaIoH1D9BTF7ohZtZl X-Received: by 10.98.138.68 with SMTP id y65mr2391427pfd.110.1523979302149; Tue, 17 Apr 2018 08:35:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523979302; cv=none; d=google.com; s=arc-20160816; b=X58dcBNVDfaY55gt28n4OSV0jTFS/q3bzMSMalXxWzmMltaWuMgYxpDdTVy1hkKbjA gv0L45rMXBR5BvkRq5Umh4hnOwWoCglg1RwnqxWzG1PYrQsF83Qz4ez5S4TlxgEvBJNu j/dh4VElqrR0Cf1C+NykpyP0rNIiFpp+qqSpbPT/pQv5WQTbjEL+ElIcGx2EBaZTp6mP 30gMAW6Qkgn9Kib5xMpDrZFYrUBl2m+3ygGfIXux3GAd7enRoB+HrOwl65g1tFlM1PmD 2S5W4sw+zuzWBOiR6CFYtV7PEy1ywL5QFdAwxKKwFa48mIcfr5sQwgV16l7Lt4GpahWa DHCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=e15DLo0GSUSfMzx0TppIlleLefyjfwHgcd4FYi/vIYSmsCyFnOn/QLW5MANw5B2Z1+ +cccdRMPJGzYrLjAW2ujTCrgbqJylGmcGdsOg7IUdWIi7QcuxpsnJYnYY5UihnM3ikkR PkkkLTZb0oh9Qwbmo2eHJhcLbt0MFYVyaxg8xOnYVH09fh9hmCmtA37wyQ+9ypQs6lVs tVQfsktDae9yfy1ju5c/nSIFVnBcq7h2AzZ9YUvVJxLP6cOaMCbZRJ5aIK8PcBEV9Ans J29KBM6UcBioZ5bE26KzIbhgvpkyCWQ5x/GhTQMGE3YmnkaNScG/Hav++cBRXCzYGufw 9rTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YhtQ6A9a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si13926806ply.119.2018.04.17.08.34.47; Tue, 17 Apr 2018 08:35:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YhtQ6A9a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbeDQPd0 (ORCPT + 99 others); Tue, 17 Apr 2018 11:33:26 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:42105 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbeDQPdX (ORCPT ); Tue, 17 Apr 2018 11:33:23 -0400 Received: by mail-io0-f171.google.com with SMTP id d5so22862300iob.9 for ; Tue, 17 Apr 2018 08:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=YhtQ6A9at65LeEyFYMJRkw7MdpdA1DZ3meJAWc4urW86fVXzbbxiOBpHfiwKOfJ3bC LEI9kPgKK8aiOBK1XyfkVpS5eBHeZ5zNiI7MsvdFbOgUMUSv3Y38Wus+j1/kRsePXZnH 9vH4z/fBaIfHxwF6WrPU7OHd2aGtnlnuDlPi11R8c3GwL31eQJFxMfDdB3sIB6nESo5l FIuucMn47fIVDdv8RsJ7Xbb5nEsgrlVLv4duJzq8LPuegTXQB4Qevr/zvSz2ellqx9JZ QXqcus/0vKpYKol6AttkrNyWhxUuDGNaLrvyDuy9RbeSYfGMyE31eczCDPzybj9g4daD fzXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=nMzglLl/nYTMedbkkIqv7XP1Zi46YyFLiA0o7ENkcmbdG9Hh67ELYSsImSsXWtQMgk 3Fph1oLAdnFv7nEOfd3L1wokGwQRn5N4fHdjTTnD2HLHsMYxF9bWZaccs0gd9AOb4piA n0JW1EECMnACNbN+L6ZEVLcLCKqO2pEoNQK0ZIkuz5BZTda3AIsSwKjaOKD9yiS6CD66 /U8eqGF95I3fvj6TdTGsgqQ0SxB95hqCGr2ymRlGNX7lAL03a4IMEqBZv8tw6qv8QTsR aXjFcYb8Pr2K92V1/SADMeI02BeffUmRt8EznMUoxdrR+tTja/DtVQUG4q0wEV1ZOz9Q xlUw== X-Gm-Message-State: ALQs6tAi5fnE33TA9ZcuB8A+ngeVnJvM7ewW4OsSKo4XlNjiGQ8q4UNV OxYOQUGTmSV77vhiLIZXXMta/1cz X-Received: by 10.107.157.75 with SMTP id g72mr2625221ioe.240.1523979202715; Tue, 17 Apr 2018 08:33:22 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id y20sm7474131ioy.27.2018.04.17.08.33.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Apr 2018 08:33:22 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Cc: andresx7@gmail.com, gregkh@linuxfoundation.org, mcgrof@kernel.org, alexdeucher@gmail.com, ckoenig.leichtzumerken@gmail.com, kvalo@codeaurora.org, arend.vanspriel@broadcom.com Subject: [PATCH 6/9] firmware: print firmware name on fallback path Date: Tue, 17 Apr 2018 11:33:04 -0400 Message-Id: <20180417153307.3693-7-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180417153307.3693-1-andresx7@gmail.com> References: <20180417153307.3693-1-andresx7@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d". However, with the new firmware_request_nowarn() entrypoint, the message outlined above will not always be printed. Therefore, we add the firmware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index e75928458489..1a47ddc70c31 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -669,6 +669,6 @@ int fw_sysfs_fallback(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + dev_warn(device, "Falling back to user helper for %s\n", name); return fw_load_from_user_helper(fw, name, device, opt_flags); } -- 2.14.1