Received: by 10.192.165.156 with SMTP id m28csp193068imm; Tue, 17 Apr 2018 08:36:46 -0700 (PDT) X-Google-Smtp-Source: AIpwx48Dvlw0dTCOpTpiaCJPz4VOII+gzRitT+ectCt4uwRCBzdUIBiryNso70OMqo/r14wKkMF7 X-Received: by 2002:a17:902:684c:: with SMTP id f12-v6mr2507140pln.139.1523979406306; Tue, 17 Apr 2018 08:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523979406; cv=none; d=google.com; s=arc-20160816; b=dh58dwu+FlXE+dpYCNPX52YjTalJuMxShGlyLRCcXFhE9qNOE9mZtuLG+Z6vEEo/+w zdGA8bkeQwRhNRMLSVsAbpstV5f4LTeWmTxYMkwBcfhGbXWb4IYUtILDfkoSjjhWYPTM LoTIw2sktHsesEP/6zUqRFSiWnIFjZMVLvYBONb5Gn2C0y4HVqrULTRvSBKDomS03skE cNf2z0JwhIJT9HvuBjV/fFlM/i8IKpxkrNeoOamNTn1EuYzABlWNdCLVbAX66mLb2rZG BB7sD+k0kakA6ePakXRmezn/Cgc8qvFAPqSECmHoN1ni+rfnC7yJld6yqnTwGD/WXkOl mNMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=u/sDUCrQLQOgyVq6L7Ulu0kCtuLbvxmaQJ/1Nsyl/cw=; b=nPygycQh6qAVwpn7nWeb5U4JDE1DizSNC+gIcwbuPSpef4fU5J6lINyLdenslitIUd dp5iuzeOCegyRMfI4QVms8kLWQ11pUZ+JNXsk5NK7aL/y3EGyLRlU5pAd5IYeHiywcxU MGRGG+RAN71e3ab6mXuS6+W8LRmWSVkr5LA1ZWJItcBNzAWzIctBtP902kxF/L5noEz+ MZBsRcyYJhdiN9RzZ0xV+64dof7H1t7yd87dlIHBdzn4rv6AlJ4BIpJxcyJTW32/8tQO wdE+dc6yZGg9RpVdniT53BBno1IZ2I50Tm/6J/U8ZNXS0DuQxzkTqpiN+qeIM7kr104x y2zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nqYrCGhx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az2-v6si13476231plb.540.2018.04.17.08.36.32; Tue, 17 Apr 2018 08:36:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nqYrCGhx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbeDQPet (ORCPT + 99 others); Tue, 17 Apr 2018 11:34:49 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:39638 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796AbeDQPdV (ORCPT ); Tue, 17 Apr 2018 11:33:21 -0400 Received: by mail-io0-f194.google.com with SMTP id v13so22867952iob.6 for ; Tue, 17 Apr 2018 08:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u/sDUCrQLQOgyVq6L7Ulu0kCtuLbvxmaQJ/1Nsyl/cw=; b=nqYrCGhxniP06p/ZvFWHStyR7TixElbqS10UY8Z+PayYnF9AeuJ/yFTJuse+y/R3vu Obe59kCvsAmJtI9vbP4zw9cttiFs7r3JRPpRNRbowtWMhnz8024ZHo0nQSnhNyQAn5yi 0B2TjBRb0bpV4L288u4H9OVdkY6p36++0DJTYkKKC2lE4hROfXsCIuEgGrm2km9RwB6F sRrKpeqdsrWv4yqBwcqiMXjs7zm20S9+2NKiqSjwsgjiQ2yoMsdmpXAj4dP1BdQsVV7m 75xPbGmXCVAj5Pd0Qc2X0k+e8t1rCez0kFWS5ydUisyY/KSLhmkbCF7OG5zb3BvMsPUY VfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u/sDUCrQLQOgyVq6L7Ulu0kCtuLbvxmaQJ/1Nsyl/cw=; b=URB05Vi+gFLTYFnjLxxyxkHOwF1fF45z+/g9XBZTqEt4pxJEvK9wd2ZlX5P82qpfih 7VePiyPxczBwGV7gX2NlRduhiRZdbJHzMAr4UpJxdzr49lJuo+VJgSxiE5PBAjeKz2/I uwf88s4zn5u0NCo6FZ55B9EwyMxObPQqxVoKTr3NDe1Lx9trBpRj8MaaVa4JX5EP1GA+ CUob818IvjLE05HcY4pXpU24S+jvyqgyAxmNH/aDUB+m/vfUeIoRTs4KD8+ODW2DHOQn 4w1nejVRzRqKDtr5Js7/XJk8cXSuBRY8QN8BwaAnzT0rocR/J0dtZi5OSnwwn4Qymppb 6g3g== X-Gm-Message-State: ALQs6tDjLsY9ccxqkS3yMgj4yvpkcc9VtqTHdisW3zpeBtdU3bpS1RyJ V7l89Jo8+1oWLRoiwOabEz2NXDdp X-Received: by 10.107.176.71 with SMTP id z68mr2465125ioe.124.1523979200532; Tue, 17 Apr 2018 08:33:20 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id y20sm7474131ioy.27.2018.04.17.08.33.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Apr 2018 08:33:20 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Cc: andresx7@gmail.com, gregkh@linuxfoundation.org, mcgrof@kernel.org, alexdeucher@gmail.com, ckoenig.leichtzumerken@gmail.com, kvalo@codeaurora.org, arend.vanspriel@broadcom.com Subject: [PATCH 4/9] firmware: use () to terminate kernel-doc function names Date: Tue, 17 Apr 2018 11:33:02 -0400 Message-Id: <20180417153307.3693-5-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180417153307.3693-1-andresx7@gmail.com> References: <20180417153307.3693-1-andresx7@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 8 ++++---- drivers/base/firmware_loader/main.c | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index ecc49a619298..e75928458489 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -124,7 +124,7 @@ static ssize_t timeout_show(struct class *class, struct class_attribute *attr, } /** - * firmware_timeout_store - set number of seconds to wait for firmware + * firmware_timeout_store() - set number of seconds to wait for firmware * @class: device class pointer * @attr: device attribute pointer * @buf: buffer to scan for timeout value @@ -238,7 +238,7 @@ static int map_fw_priv_pages(struct fw_priv *fw_priv) } /** - * firmware_loading_store - set value in the 'loading' control file + * firmware_loading_store() - set value in the 'loading' control file * @dev: device pointer * @attr: device attribute pointer * @buf: buffer to scan for loading control value @@ -430,7 +430,7 @@ static int fw_realloc_pages(struct fw_sysfs *fw_sysfs, int min_size) } /** - * firmware_data_write - write method for firmware + * firmware_data_write() - write method for firmware * @filp: open sysfs file * @kobj: kobject for the device * @bin_attr: bin_attr structure @@ -536,7 +536,7 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, } /** - * fw_load_sysfs_fallback - load a firmware via the sysfs fallback mechanism + * fw_load_sysfs_fallback() - load a firmware via the sysfs fallback mechanism * @fw_sysfs: firmware sysfs information for the firmware to load * @opt_flags: flags of options, FW_OPT_* * @timeout: timeout to wait for the load diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 5baadad3012d..d028cd3257f7 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -597,7 +597,7 @@ _firmware_request(const struct firmware **firmware_p, const char *name, } /** - * firmware_request: - send firmware request and wait for it + * firmware_request() - send firmware request and wait for it * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -632,7 +632,7 @@ firmware_request(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request); /** - * firmware_request_direct: - load firmware directly without usermode helper + * firmware_request_direct() - load firmware directly without usermode helper * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -657,7 +657,7 @@ int firmware_request_direct(const struct firmware **firmware_p, EXPORT_SYMBOL_GPL(firmware_request_direct); /** - * firmware_request_cache: - cache firmware for suspend so resume can use it + * firmware_request_cache() - cache firmware for suspend so resume can use it * @name: name of firmware file * @device: device for which firmware should be cached for * @@ -681,7 +681,7 @@ int firmware_request_cache(struct device *device, const char *name) EXPORT_SYMBOL_GPL(firmware_request_cache); /** - * firmware_request_into_buf - load firmware into a previously allocated buffer + * firmware_request_into_buf() - load firmware into a previously allocated buffer * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded and DMA region allocated @@ -713,7 +713,7 @@ firmware_request_into_buf(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request_into_buf); /** - * firmware_release: - release the resource associated with a firmware image + * firmware_release() - release the resource associated with a firmware image * @fw: firmware resource to release **/ void firmware_release(const struct firmware *fw) @@ -755,7 +755,7 @@ static void firmware_request_work_func(struct work_struct *work) } /** - * firmware_request_nowait - asynchronous version of firmware_request + * firmware_request_nowait() - asynchronous version of firmware_request * @module: module requesting the firmware * @uevent: sends uevent to copy the firmware image if this flag * is non-zero else the firmware copy must be done manually. @@ -824,7 +824,7 @@ EXPORT_SYMBOL(firmware_request_nowait); static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain); /** - * cache_firmware - cache one firmware image in kernel memory space + * cache_firmware() - cache one firmware image in kernel memory space * @fw_name: the firmware image name * * Cache firmware in kernel memory so that drivers can use it when @@ -866,7 +866,7 @@ static struct fw_priv *lookup_fw_priv(const char *fw_name) } /** - * uncache_firmware - remove one cached firmware image + * uncache_firmware() - remove one cached firmware image * @fw_name: the firmware image name * * Uncache one firmware image which has been cached successfully @@ -1042,7 +1042,7 @@ static void __device_uncache_fw_images(void) } /** - * device_cache_fw_images - cache devices' firmware + * device_cache_fw_images() - cache devices' firmware * * If one device called firmware_request or its nowait version * successfully before, the firmware names are recored into the @@ -1075,7 +1075,7 @@ static void device_cache_fw_images(void) } /** - * device_uncache_fw_images - uncache devices' firmware + * device_uncache_fw_images() - uncache devices' firmware * * uncache all firmwares which have been cached successfully * by device_uncache_fw_images earlier @@ -1092,7 +1092,7 @@ static void device_uncache_fw_images_work(struct work_struct *work) } /** - * device_uncache_fw_images_delay - uncache devices firmwares + * device_uncache_fw_images_delay() - uncache devices firmwares * @delay: number of milliseconds to delay uncache device firmwares * * uncache all devices's firmwares which has been cached successfully -- 2.14.1