Received: by 10.192.165.156 with SMTP id m28csp234217imm; Tue, 17 Apr 2018 09:14:49 -0700 (PDT) X-Google-Smtp-Source: AIpwx48THpgWjSaUfPZ3RHeflsscxerpy7ZT5udDyrDbJm2aEFUs2+yrSq1/4lawHcLG5jOOAvH+ X-Received: by 10.167.128.217 with SMTP id a25mr2549701pfn.132.1523981689706; Tue, 17 Apr 2018 09:14:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523981689; cv=none; d=google.com; s=arc-20160816; b=tJbPyUeBfKsroREFbTxU40OTBJlGtUnvHo5RqfSq1PUBCWJZhbs2J6aaEZqH+/hkVE B1tnW9y82QIi/3FW9RoW5TzZDZWIDEn9nIRS9LJqDM4ssbXF5GI3ex/eOVoEuAp31B51 7wqePj00y3Xt2LEMDqPn3h6XWu1Ta641WGGDqfosNI4yz4zGQxwsNeX60CRPk3gXk2MD WN2DfMifEgOA8jLAOxt6P1jonYNQyc8op1G2aVU3ic05U1siLHgO86/0pQ8VKcnpK0Mb X9z4RlMiC0799mOS7LkEB2WrPTCAHE0+CmzZrmlG1f14TYnee/0/3Z756W8mAx5dCMCa HXWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=W1juMNupwVkEBg/QTD7CYBQtg1+5/pqLRyz/ssseAYA=; b=fd6Z0OUIgJtMOt9BaaNmutCsEKJmQ/QLZ13kKhilMpRmm0hLoWNhM17q0JmkEA0Lqb SMMoPrao6uzro7OZCc0bxMfig0loksihEVsNMjtpXLqYG8aZ8cyi80DHW7+GAYldRRvr YRGy08t9Kvk0NSQBdc07Qc81+nE/Uwc1MmM9UlgtFuswS1udvAjK5cGgqapTD0eY+MMz bW7Ob8UidTdzwH2hBMggKmTF1cP5ywPNZYEhT0sb/oRjZ6H8xwVtPZQDKXyUVUR1CwKu E+c+64fLhwjJ5K/uc3yehG6bM9KWmaeppDvorTZ1OQZqrdPwznqITjagrf/gfhKKpJFI 3q7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si7686094pgu.535.2018.04.17.09.14.35; Tue, 17 Apr 2018 09:14:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755839AbeDQQMt (ORCPT + 99 others); Tue, 17 Apr 2018 12:12:49 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:32852 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755653AbeDQQMn (ORCPT ); Tue, 17 Apr 2018 12:12:43 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3HGBrcM107068 for ; Tue, 17 Apr 2018 12:12:43 -0400 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hdjs2n9e1-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 12:12:43 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 12:12:42 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Apr 2018 12:12:38 -0400 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3HGCbeJ55574560; Tue, 17 Apr 2018 16:12:37 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41D5512403F; Tue, 17 Apr 2018 13:14:39 -0400 (EDT) Received: from oc8043147753.ibm.com (unknown [9.85.136.174]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id E73EA12403D; Tue, 17 Apr 2018 13:14:37 -0400 (EDT) Subject: Re: [PATCH v4 13/15] KVM: s390: configure the guest's AP devices To: Halil Pasic , Pierre Morel , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1523827345-11600-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523827345-11600-14-git-send-email-akrowiak@linux.vnet.ibm.com> <2e7387b9-ceb4-cdca-56ac-f5344084e10a@linux.vnet.ibm.com> From: Tony Krowiak Date: Tue, 17 Apr 2018 12:12:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18041716-0056-0000-0000-0000043FF4E9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008871; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000257; SDB=6.01019282; UDB=6.00519985; IPR=6.00798523; MB=3.00020619; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-17 16:12:41 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041716-0057-0000-0000-00000883F947 Message-Id: <80a8ddcc-6536-060b-0f34-616b7dcaf620@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-17_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170142 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2018 10:51 AM, Halil Pasic wrote: > > On 04/16/2018 03:05 PM, Pierre Morel wrote: >>> +static void vfio_ap_mdev_release(struct mdev_device *mdev) >>> +{ >>> + struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); >>> + >>> + kvm_ap_deconfigure_matrix(matrix_mdev->kvm); >>> + kvm_ap_interpret_instructions(matrix_mdev->kvm, false); >> This call clears the apie in KVM. >> This is only OK if we have a single device present until the end of the VM, >> otherwise AP instructions in the guest will fail after the release until the end of the VM >> or until a new device is plugged. > I agree, this seems wrong. As I think about this more, you may be correct. I believe that one can remove a VFIO mediated device via a sysfs file descriptor. I suppose that could happen while the guest is still running, which would mean AP instructions executed on the guest would meet with an operation exception. I will have to explore this some more.