Received: by 10.192.165.156 with SMTP id m28csp242819imm; Tue, 17 Apr 2018 09:23:05 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+7eaZO/s3CdBBl8eIiCqoNydfO0+5s7mZsrBrBQcPLzhagbdmJsI0G7WqAg731l9kg9sAi X-Received: by 10.98.217.221 with SMTP id b90mr2561725pfl.113.1523982185015; Tue, 17 Apr 2018 09:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523982184; cv=none; d=google.com; s=arc-20160816; b=sn541UitVf4Al7sI6YzncGpcnmTfJlAoekIJgX2HlPFzLXwP1yBjax9w5kAKD+ohyP 8TF3blOapau7cqW9fP9Zg3ZSlLkKiybI0r3Actwj8xXGv83iJukMcj84+WRvMAe2BFwI tG/+7QlZfpw7XJ18NdFoKFqkyX7C+4J3ZpTsoChp5f4CH8ItF5n1LIz1PIzqzcLSivTS pOOoizPn4f3LV874givwdKzRQYJ+4U0Zh8GSjKIWWGuU5zVt4sonvv6ihsgw6NT2plVF u9HZBY5oIE9mCnD2+XtEZLK6gBHUsQhcHXMxmHnLZxbENmXKw6j0pbxSYjBz16rGcGb9 PP/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=RYRs53b01d3K2vFSPna4W8tqcZNmT6PDzJC2d+9Insw=; b=tW7f9qzuFqIcNd6B+uQHDSnbSe1k37qwTwIeqc/vqS9YtTBPwnxlhL8inw0Tvq31GW P9uMXiLkilsENFlYtqe0fDE7DVBrnWYDug22KQzvEsMKVKW0WndTQ4qXBVSaNrapDeM9 +kdgRRCSajZxta45oo9rVXe2gbJFpTeTAJ04IkDTfVF7IYomZ6sLVaIV0dK26CYbLDZN GcYQlLzh3lAxvh0DPI9G6bQ7g4W8RCGfUCciQJhznmo8RQp/iAeVFJFmKAP6+UlDsPRb PTzDzwFKkV2i4pycRS8/bsWkSTdk1ts4uFnBKCVfyUIGQoz7LGgrohCQUgEZV3tf/wkI UUrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y72si13204471pfi.46.2018.04.17.09.22.50; Tue, 17 Apr 2018 09:23:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755903AbeDQQVD (ORCPT + 99 others); Tue, 17 Apr 2018 12:21:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36310 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755776AbeDQQKL (ORCPT ); Tue, 17 Apr 2018 12:10:11 -0400 Received: from localhost (unknown [46.44.180.42]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 92D3BD20; Tue, 17 Apr 2018 16:10:09 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavlos Parissis , Lei Chen , Maxime Hadjinlian , Namhyung Kim , Adrian Hunter , Jiri Olsa , David Ahern , Peter Zijlstra , Wang Nan , kernel-team@lge.com, Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.9 52/66] Revert "perf tests: Decompress kernel module before objdump" Date: Tue, 17 Apr 2018 17:59:25 +0200 Message-Id: <20180417155648.152933169@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180417155645.868055442@linuxfoundation.org> References: <20180417155645.868055442@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman This reverts commit 7525a238be8f46617cdda29d1be5b85ffe3b042d which is commit 94df1040b1e6aacd8dec0ba3c61d7e77cd695f26 upstream. It breaks the build of perf on 4.9.y, so I'm dropping it. Reported-by: Pavlos Parissis Reported-by: Lei Chen Reported-by: Maxime Hadjinlian Cc: Namhyung Kim Cc: Adrian Hunter Cc: Jiri Olsa Cc: David Ahern Cc: Peter Zijlstra Cc: Wang Nan Cc: kernel-team@lge.com Cc: Arnaldo Carvalho de Melo Cc: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- tools/perf/tests/code-reading.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) --- a/tools/perf/tests/code-reading.c +++ b/tools/perf/tests/code-reading.c @@ -224,8 +224,6 @@ static int read_object_code(u64 addr, si unsigned char buf2[BUFSZ]; size_t ret_len; u64 objdump_addr; - const char *objdump_name; - char decomp_name[KMOD_DECOMP_LEN]; int ret; pr_debug("Reading object code for memory address: %#"PRIx64"\n", addr); @@ -286,25 +284,9 @@ static int read_object_code(u64 addr, si state->done[state->done_cnt++] = al.map->start; } - objdump_name = al.map->dso->long_name; - if (dso__needs_decompress(al.map->dso)) { - if (dso__decompress_kmodule_path(al.map->dso, objdump_name, - decomp_name, - sizeof(decomp_name)) < 0) { - pr_debug("decompression failed\n"); - return -1; - } - - objdump_name = decomp_name; - } - /* Read the object code using objdump */ objdump_addr = map__rip_2objdump(al.map, al.addr); - ret = read_via_objdump(objdump_name, objdump_addr, buf2, len); - - if (dso__needs_decompress(al.map->dso)) - unlink(objdump_name); - + ret = read_via_objdump(al.map->dso->long_name, objdump_addr, buf2, len); if (ret > 0) { /* * The kernel maps are inaccurate - assume objdump is right in