Received: by 10.192.165.156 with SMTP id m28csp247689imm; Tue, 17 Apr 2018 09:28:19 -0700 (PDT) X-Google-Smtp-Source: AIpwx48k+qtin4Dm0vSSc7HkVFYJv59EYt7+Yl8yKO9rEvMOn3TuQuFsO5LRphOiigWMlK/oIQde X-Received: by 10.98.181.20 with SMTP id y20mr2609480pfe.102.1523982499196; Tue, 17 Apr 2018 09:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523982499; cv=none; d=google.com; s=arc-20160816; b=MkVqVNnrt+utg3ElYELxd9R5m3rNLh1u49+6v7r0a8HlD6eHDAdk99cVusgBtn2muw exndztTel1ff96rpu/SFEl4s1979+EX6njIvwbmUAW4AVWAl7nzHTGRJbiSt1QdOwFAg Jmd3v1+n0r4YrkTYhjp1ikDaLF20KgRcPzmKZPge9Re59uh6OJTycYz2uU+2/B2PQzP3 gH4FQHjcnPpn5fjqG8/IeOFeKRwg4pLk9D2rbcbob/weLB5Id3P7un4Yg9vQT9u0vQWC hdP+cZgpC5f5qXYEIsMhvU7pBcWAKfAL2xl2V7RwH47a0k2NrA4AfCs8g/WdO5z9YCFs se+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BooBWPwnE7TV6B5YN7ajZ3GMpEhhv1uPxisHS+BpG5Y=; b=uHO1xjr7Qf2Yuma1gnH7iPX3rP+mUZ4SIIBThV8yfoZ4uCRdpyzAGiMk6YMDf9RAn7 /DslBCSTAQxYRoPScGjW+Bou8Uo5hNhGYO5DV25r7EnCsBQRGCKWMVM6gn1PSMY1Tm2i ie1aW/Pm+ZSPVkvw8xsecV0lcyBYb3WxXsXITtPVQUynGJGHCm2WV0bR86XjUxGKb4IW tuWfdiveGZEpLmH6EPtQapulWpET0G1N9Zlvm1IPgGq8jNer2BqFAZWRJ5isFl12Ez2m BSzqN5TORrSFTWiGy9FPpuWmweZcO7M0TOfme58Mqyc3vx91F9zOTC7wQ/skM7Nw5dRu nksQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g15-v6si1670648pln.526.2018.04.17.09.28.05; Tue, 17 Apr 2018 09:28:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755556AbeDQQJA (ORCPT + 99 others); Tue, 17 Apr 2018 12:09:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35624 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755514AbeDQQI6 (ORCPT ); Tue, 17 Apr 2018 12:08:58 -0400 Received: from localhost (unknown [46.44.180.42]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8FB1FC98; Tue, 17 Apr 2018 16:08:57 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Marc Zyngier , Will Deacon , Catalin Marinas , Greg Hackmann , Mark Rutland Subject: [PATCH 4.9 28/66] arm64: KVM: Use per-CPU vector when BP hardening is enabled Date: Tue, 17 Apr 2018 17:59:01 +0200 Message-Id: <20180417155647.089298589@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180417155645.868055442@linuxfoundation.org> References: <20180417155645.868055442@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Rutland From: Marc Zyngier commit 6840bdd73d07216ab4bc46f5a8768c37ea519038 upstream. Now that we have per-CPU vectors, let's plug then in the KVM/arm64 code. Signed-off-by: Marc Zyngier Signed-off-by: Will Deacon Signed-off-by: Catalin Marinas [v4.9: account for files moved to virt/ upstream, use cpus_have_cap()] Signed-off-by: Mark Rutland [v4.9 backport] Tested-by: Greg Hackmann Signed-off-by: Greg Kroah-Hartman --- arch/arm/include/asm/kvm_mmu.h | 10 ++++++++++ arch/arm/kvm/arm.c | 9 ++++++++- arch/arm64/include/asm/kvm_mmu.h | 38 ++++++++++++++++++++++++++++++++++++++ arch/arm64/kvm/hyp/switch.c | 2 +- 4 files changed, 57 insertions(+), 2 deletions(-) --- a/arch/arm/include/asm/kvm_mmu.h +++ b/arch/arm/include/asm/kvm_mmu.h @@ -223,6 +223,16 @@ static inline unsigned int kvm_get_vmid_ return 8; } +static inline void *kvm_get_hyp_vector(void) +{ + return kvm_ksym_ref(__kvm_hyp_vector); +} + +static inline int kvm_map_vectors(void) +{ + return 0; +} + #endif /* !__ASSEMBLY__ */ #endif /* __ARM_KVM_MMU_H__ */ --- a/arch/arm/kvm/arm.c +++ b/arch/arm/kvm/arm.c @@ -1088,7 +1088,7 @@ static void cpu_init_hyp_mode(void *dumm pgd_ptr = kvm_mmu_get_httbr(); stack_page = __this_cpu_read(kvm_arm_hyp_stack_page); hyp_stack_ptr = stack_page + PAGE_SIZE; - vector_ptr = (unsigned long)kvm_ksym_ref(__kvm_hyp_vector); + vector_ptr = (unsigned long)kvm_get_hyp_vector(); __cpu_init_hyp_mode(pgd_ptr, hyp_stack_ptr, vector_ptr); __cpu_init_stage2(); @@ -1345,6 +1345,13 @@ static int init_hyp_mode(void) goto out_err; } + + err = kvm_map_vectors(); + if (err) { + kvm_err("Cannot map vectors\n"); + goto out_err; + } + /* * Map the Hyp stack pages */ --- a/arch/arm64/include/asm/kvm_mmu.h +++ b/arch/arm64/include/asm/kvm_mmu.h @@ -313,5 +313,43 @@ static inline unsigned int kvm_get_vmid_ return (cpuid_feature_extract_unsigned_field(reg, ID_AA64MMFR1_VMIDBITS_SHIFT) == 2) ? 16 : 8; } +#ifdef CONFIG_HARDEN_BRANCH_PREDICTOR +#include + +static inline void *kvm_get_hyp_vector(void) +{ + struct bp_hardening_data *data = arm64_get_bp_hardening_data(); + void *vect = kvm_ksym_ref(__kvm_hyp_vector); + + if (data->fn) { + vect = __bp_harden_hyp_vecs_start + + data->hyp_vectors_slot * SZ_2K; + + if (!cpus_have_cap(ARM64_HAS_VIRT_HOST_EXTN)) + vect = lm_alias(vect); + } + + return vect; +} + +static inline int kvm_map_vectors(void) +{ + return create_hyp_mappings(kvm_ksym_ref(__bp_harden_hyp_vecs_start), + kvm_ksym_ref(__bp_harden_hyp_vecs_end), + PAGE_HYP_EXEC); +} + +#else +static inline void *kvm_get_hyp_vector(void) +{ + return kvm_ksym_ref(__kvm_hyp_vector); +} + +static inline int kvm_map_vectors(void) +{ + return 0; +} +#endif + #endif /* __ASSEMBLY__ */ #endif /* __ARM64_KVM_MMU_H__ */ --- a/arch/arm64/kvm/hyp/switch.c +++ b/arch/arm64/kvm/hyp/switch.c @@ -50,7 +50,7 @@ static void __hyp_text __activate_traps_ val &= ~CPACR_EL1_FPEN; write_sysreg(val, cpacr_el1); - write_sysreg(__kvm_hyp_vector, vbar_el1); + write_sysreg(kvm_get_hyp_vector(), vbar_el1); } static void __hyp_text __activate_traps_nvhe(void)