Received: by 10.192.165.156 with SMTP id m28csp304612imm; Tue, 17 Apr 2018 10:23:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+26ztuUWRMJ4feh8Nr/dO0E1QYB/AduqymUyeZ4YdMK0RQHopZ15/YpekXASxMdk6Dfp55 X-Received: by 2002:a17:902:292b:: with SMTP id g40-v6mr1805945plb.303.1523985822018; Tue, 17 Apr 2018 10:23:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523985821; cv=none; d=google.com; s=arc-20160816; b=gLLgZK+SuKOT4im/zhrfzFzFS1MBfP3O36ZcHTw+wa5df7C/Ku9j59+XFUu1bmyn0f KthJSVY9w36DSLtOf5u1sTZzBtHt5uiDMxu4/AiYWRvm/NircP4OLww4RAHXYpvgJZjC GsjH+9BfwEiJuAz/NGi9Ul8AXWAyDA7ED0+jkNWKIvsDnd0UyejqLJljNy5PTOHyIsfK kUiqr13MTs2K5Kdd/OQxnFdwre/Bx2eiroBFNC+8AiNiO8FRZSuI3V0HhrPYiEJqwjJS kwB1eSUN8yB5wX+jndoEP835TDzBgVtfKrWDXz6JVe82s9s6ri2exwSffonhm3Xk/nod WjuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:subject:message-id:date:from :mime-version:dkim-signature:arc-authentication-results; bh=IOu0DWT6Th/e4ZuxBwoUAuIR0/YsBywkYzbVBJmjeCc=; b=IzWq95nrUf/NpEvrST32QD70YV+QNCDAr1tigfDSljyGd9Rk5j2tHH+d4Zrzt47ASQ gvkaBDj0Hzf5t+KWOpDqUgvX/ffdA49Fu3mj4azxO0spv/2DSjj3KaEM5Cw8yKskbEvT N3TUWSQOQaQiv+oUxPcoA3KJx+UJfmZHSPpBFRqPa/yCvtQRePxxIPGHBn37ogkOSOAv hlXozKZbv8CKVJSpOimc3Hhlk/Qg0wJ+mwNKRrFDm7i4uD3+40UprNvmPElVFZhvHqy0 e74E5iDsIxYMShKL58eg02bS5/6i65qKlzmjz2w4Zl7MVn74xNdVle4zL9cOc5Qrfk6A hBtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UClTasOB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w67si3736107pgb.447.2018.04.17.10.23.26; Tue, 17 Apr 2018 10:23:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UClTasOB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbeDQRVr (ORCPT + 99 others); Tue, 17 Apr 2018 13:21:47 -0400 Received: from mail-qt0-f171.google.com ([209.85.216.171]:36008 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbeDQRVq (ORCPT ); Tue, 17 Apr 2018 13:21:46 -0400 Received: by mail-qt0-f171.google.com with SMTP id q13so4687609qtl.3 for ; Tue, 17 Apr 2018 10:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=IOu0DWT6Th/e4ZuxBwoUAuIR0/YsBywkYzbVBJmjeCc=; b=UClTasOBqajde//BzPaMh69YUJ9PqV7D6+/1lerjPa/5gP9Nd7VqgiMSNUvQJ5MSHY XnDpIHZjzO96GOAWPnFJvS5LBQvIN9VZL9iBb83LAIIDlnl8IRqKfrcqxqvgOLB+TMMQ /TwWHt7ieJRV8dzs8QeqPcnxmUc1Bv7IIG5JWOXRmZzXSxOVNRB7P1s/ERsGVYVitagz nBmK/LwTCIfMtw3G6A67higBeo9tUKFC+maEIKV5n9S/WcXOBv7xhP2bgJEFWisY50ZW 4Rn+oJDaHeCy3i7z9CMsqwQ7WReacciPXn8vh306JVzkjzwSpGcGFIFgf4RXYD9/gQBs Q8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IOu0DWT6Th/e4ZuxBwoUAuIR0/YsBywkYzbVBJmjeCc=; b=h25c8Yi0AdyKhiWvJUO4U6Mzsda9M9H0oqPnp8L/YCxeRfF/WmlHY2cSQ2kbPB7v8z cVtFTsEouQ3UmHxSeAhobfdCTWVEiZs1ke1B+pihkJ6o1eU6W6XraTn0FNmi8sJh1q49 9fdd4BUq7PVChOPCr6pz3uEjQ4V5kF6aj6FZ/N6+4sD7vZYoiD9Q4qzivFIU6OriPO2r yW/E43/OhMLfqRRfw0ua1eUaLsjuWN/M6Dmn0n3A5c5E82Go9TI/w4Q0Li5mntYLG2SQ 1Y5KsnbVFPOSWVoZYaD5XEtt3WDFbhzEtEXciIcSr/msqhxFO649+cNkT4udRO6FJOte I/vQ== X-Gm-Message-State: ALQs6tCVE6dbwj3yecG8uJ8RNoUbihGLwRMmXyV7LyXMBh9L0VPmi2qZ RWX4H6FBaMKZmUY/iIx3SfKrZ754U2bfn7EWXaWKgoUK X-Received: by 10.200.44.67 with SMTP id e3mr3077507qta.21.1523985705171; Tue, 17 Apr 2018 10:21:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.35.175 with HTTP; Tue, 17 Apr 2018 10:21:44 -0700 (PDT) From: Sebastian Kuzminsky Date: Tue, 17 Apr 2018 11:21:44 -0600 Message-ID: Subject: fix for bnx2x panic during ethtool reporting To: linux-kernel@vger.kernel.org Content-Type: multipart/mixed; boundary="001a113ada8899ae69056a0e92ca" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --001a113ada8899ae69056a0e92ca Content-Type: text/plain; charset="UTF-8" "ethtool -i" on a bnx2x interface causes kernel panic when the firmware version is longer than expected. The attached patch fixes the problem by simplifying the string handling in bnx2x_fill_fw_str(). It applies cleanly to 4.14 and 4.17-rc1. -- Sebastian Kuzminsky --001a113ada8899ae69056a0e92ca Content-Type: text/x-patch; charset="US-ASCII"; name="0001-bnx2x-make-fw-str-in-a-non-crazy-way.patch" Content-Disposition: attachment; filename="0001-bnx2x-make-fw-str-in-a-non-crazy-way.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jg3xqlgz0 RnJvbSA3NmFkN2E0MWU4NDY3NDUxOWQyZDVmNDdlNDJjODQ2OTdlYTNmMjNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWJhc3RpYW4gS3V6bWluc2t5IDxzZWJAaGlnaGxhYi5jb20+ CkRhdGU6IE1vbiwgMTYgQXByIDIwMTggMjM6MjQ6MDcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBi bngyeDogbWFrZSBmdyBzdHIgaW4gYSBub24tY3Jhenkgd2F5CgpUaGlzIGZpeGVzIGFuIHVudGVy bWluYXRlZCBzdHJpbmcgYnVnIHdoZW4gdGhlIGZpcndtYXJlIHZlcnNpb24KKGJwLT5md192ZXIp IGlzIGxvbmdlciB0aGFuIHRoZSBwYXNzZWQtaW4gYnVmZmVyIChidWYvYnVmX2xlbikuCi0tLQog ZHJpdmVycy9uZXQvZXRoZXJuZXQvYnJvYWRjb20vYm54MngvYm54MnhfY21uLmMgfCA2ICsrKy0t LQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9icm9hZGNvbS9ibngyeC9ibngyeF9jbW4uYyBi L2RyaXZlcnMvbmV0L2V0aGVybmV0L2Jyb2FkY29tL2JueDJ4L2JueDJ4X2Ntbi5jCmluZGV4IDY3 ZmUzZDgyNjU2Ni4uNTUzNGNlZTBhYWI4IDEwMDY0NAotLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5l dC9icm9hZGNvbS9ibngyeC9ibngyeF9jbW4uYworKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9i cm9hZGNvbS9ibngyeC9ibngyeF9jbW4uYwpAQCAtMTUwLDkgKzE1MCw5IEBAIHZvaWQgYm54Mnhf ZmlsbF9md19zdHIoc3RydWN0IGJueDJ4ICpicCwgY2hhciAqYnVmLCBzaXplX3QgYnVmX2xlbikK IAkJcGh5X2Z3X3ZlclswXSA9ICdcMCc7CiAJCWJueDJ4X2dldF9leHRfcGh5X2Z3X3ZlcnNpb24o JmJwLT5saW5rX3BhcmFtcywKIAkJCQkJICAgICBwaHlfZndfdmVyLCBQSFlfRldfVkVSX0xFTik7 Ci0JCXN0cmxjcHkoYnVmLCBicC0+ZndfdmVyLCBidWZfbGVuKTsKLQkJc25wcmludGYoYnVmICsg c3RybGVuKGJwLT5md192ZXIpLCAzMiAtIHN0cmxlbihicC0+ZndfdmVyKSwKLQkJCSAiYmMgJWQu JWQuJWQlcyVzIiwKKwkJc25wcmludGYoYnVmLCBidWZfbGVuLAorCQkJICIlcyBiYyAlZC4lZC4l ZCVzJXMiLAorCQkJIGJwLT5md192ZXIsCiAJCQkgKGJwLT5jb21tb24uYmNfdmVyICYgMHhmZjAw MDApID4+IDE2LAogCQkJIChicC0+Y29tbW9uLmJjX3ZlciAmIDB4ZmYwMCkgPj4gOCwKIAkJCSAo YnAtPmNvbW1vbi5iY192ZXIgJiAweGZmKSwKLS0gCjIuMTEuMAoK --001a113ada8899ae69056a0e92ca--