Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Apr 2018 13:51:15 -0400 (EDT)
Message-Id: <20180417.135115.342004798174126821.davem@davemloft.net>
To:     sam@mendozajonas.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        openbmc@lists.ozlabs.org
Subject: Re: [PATCH RESEND net-next] net/ncsi: Refactor MAC, VLAN filters
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180417042323.27941-1-sam@mendozajonas.com>
References: <20180417042323.27941-1-sam@mendozajonas.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Date: Tue, 17 Apr 2018 14:23:23 +1000

> The NCSI driver defines a generic ncsi_channel_filter struct that can be
> used to store arbitrarily formatted filters, and several generic methods
> of accessing data stored in such a filter.
> However in both the driver and as defined in the NCSI specification
> there are only two actual filters: VLAN ID filters and MAC address
> filters. The splitting of the MAC filter into unicast, multicast, and
> mixed is also technically not necessary as these are stored in the same
> location in hardware.
> 
> To save complexity, particularly in the set up and accessing of these
> generic filters, remove them in favour of two specific structs. These
> can be acted on directly and do not need several generic helper
> functions to use.
> 
> This also fixes a memory error found by KASAN on ARM32 (which is not
> upstream yet), where response handlers accessing a filter's data field
> could write past allocated memory.
 ...
> Reported-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>

Applied to net-next, thank you.