Received: by 10.192.165.156 with SMTP id m28csp456410imm; Tue, 17 Apr 2018 13:08:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+Y1v/uQSJfOTaNe+xt5kUG05ybUG8+f92yucbVGHXXKDcNf/VtRFV9ixlblPqxYFB7Bd2q X-Received: by 2002:a17:902:bd95:: with SMTP id q21-v6mr3360949pls.150.1523995708658; Tue, 17 Apr 2018 13:08:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523995708; cv=none; d=google.com; s=arc-20160816; b=F9wL2/IFkRDYgavLfUllz0ihbLtZKXywM5WVvtcUflV67lPdT7puIHakdAzZoZmsa5 CwG8iOc5v6yB6a5XNmY+fCMRxcq2edqIOP6L3V+RAGHbpinlo0NzhJMQ626f3F7Sbp94 I48WkOeQjr+361jAypLzRr0Arbez4HzZKajB/xGrKXKtrPRLB8xqEya1+/dViotHPpC9 PC1Q52gZnV/O9EqCqXmaQ+FMsqNyQ6evGDCTgP8wjz23XuCxk/WfpP+L/fuoW9V+u+0v tsqqwxRjU5RzNKTXIXYjS7q4deZM26xAmWreZEEcWBuht6+S172/CpDENYhcSzjci1Em HgHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=jVWlV8LjrYRKU9lCB5MXBb3fQDPKFzFaU9ZBrr6mGzk=; b=AtV0czFtUKfij1CEpHPGGGjMinqrHFhW1ZHd7BNMi8FSujuHxjgq6N3sLFOxP+/3On wyQgUUXxSNQrILI/0fTuNSOonhLYaKe+hOGiUriJlbLcyY3H0z6JLxlez68AXv48fr7I +Wt7enY1k9eksZn29EOfOXzo65j1JlnGu9niargBBZdA73Jg8VdDpJxoGMa1Lvv+Yady Acu89ll4U6U9HhYSGB4qeKRmVJNXPpxwe8riqkppvZfRRG6R/2oSSwPhvW0M2xUvvQI/ flzjrOhXf8Wlh1CBuTqHTm0drVQiDK2nN4l5xwPjRF4UxSjBszYI0kqk1qn2IylIk4z0 zYpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=RXlvN/MO; dkim=fail header.i=@chromium.org header.s=google header.b=H5F818Vl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id be3-v6si14166995plb.75.2018.04.17.13.08.13; Tue, 17 Apr 2018 13:08:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=RXlvN/MO; dkim=fail header.i=@chromium.org header.s=google header.b=H5F818Vl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbeDQUHC (ORCPT + 99 others); Tue, 17 Apr 2018 16:07:02 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:41849 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbeDQUG7 (ORCPT ); Tue, 17 Apr 2018 16:06:59 -0400 Received: by mail-vk0-f65.google.com with SMTP id i75so7850798vke.8 for ; Tue, 17 Apr 2018 13:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jVWlV8LjrYRKU9lCB5MXBb3fQDPKFzFaU9ZBrr6mGzk=; b=RXlvN/MOXjrFKELvQdSAUXTobQNVDNiju79Xxt+bRSGAAO+UD57OcW3pkr+59kgmkY XsuCkS0emrNxOuTXSGQhhDqC6ESOf/49AcF57+CqToVHBf0AwZgl7hdpLe8GLrdIgDMA CFUNLqqQXQuj9uT5Aa4CRNG2AwlUOr/YZTujjEJR7F3H+J+F4Q6PtX0rU2O2vhxruQZu 3Zzu0Olat9cJfNlUmdUuYBCnDfG9ag8XdnXkP6cHeOF1WWeE8inqzI/M6KT1QW5SOlXl Q0WWO507dITB9viuo9rLyzg8bq4hc4aIn1C1j3+K/dWSoDVQz1fMEsXa+lzxSBe0grna YezA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jVWlV8LjrYRKU9lCB5MXBb3fQDPKFzFaU9ZBrr6mGzk=; b=H5F818VlViudyQanISRGvdSOXqNt9FMBoHuRjauWdpsB/vNAvzN/R6s/mSX6wjztXK IEi7qGEo4taXOjzk6dP8wi0FwLwSM7pjbzfCVrWQG1hYjkmJDFb6WiIkzxI5SPRUXOqv URXsLiXJ0wJaM/Cj7nP8bDl4iYM+sL+Bc63Rk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jVWlV8LjrYRKU9lCB5MXBb3fQDPKFzFaU9ZBrr6mGzk=; b=Kk1YGaNwPRyDRv6MxjtzuXT9NQw1ZAzrTUWQWu0QyLnebKLSrBD1oNHujXr/LXjnWY tG3mvqOjpIY7Ih/Gg7qYs+m+cSRbbaeq3XEnlw9UUrjGo7waGtDM8gx/ujrpnHBVVuU5 iPqH7kHuAq+reMFvbeOewRkJoWLgJnYFQ9UZ2h4x+kMVNUC+adk0B+hwwoL9Oz1j4yyS 4lNhdk0NSQpumbVXbYM6vw4wL8aGU3VrIpPfVqu0xqwNp59jRU0YYmEgR2IV4mgz1tuJ Xr9fLUXTx0jOJmTjyCfonlauGaN0MojMZCG/uznGQTE/TZRc/xyxvXd2lfGitm+ReR9z veCQ== X-Gm-Message-State: ALQs6tA5DfztVhFux+Ume3jLTOGTJ6IVzUnWiprRLmE6YDpgUlJefspA nNOatcg1hcMmxB7qMq/h9jVfIXyQ1ssznTvZ7RC2Tw== X-Received: by 10.31.37.199 with SMTP id l190mr2527233vkl.169.1523995618321; Tue, 17 Apr 2018 13:06:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.137.13 with HTTP; Tue, 17 Apr 2018 13:06:57 -0700 (PDT) In-Reply-To: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org> References: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org> From: Doug Anderson Date: Tue, 17 Apr 2018 13:06:57 -0700 X-Google-Sender-Auth: dxbqW3AYA25lNto5cUQo9-HV5ho Message-ID: Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings To: David Collins Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Apr 13, 2018 at 7:50 PM, David Collins wrote: > Introduce bindings for RPMh regulator devices found on some > Qualcomm Technlogies, Inc. SoCs. These devices allow a given > processor within the SoC to make PMIC regulator requests which > are aggregated within the RPMh hardware block along with requests > from other processors in the SoC to determine the final PMIC > regulator hardware state. > > Signed-off-by: David Collins > --- > .../bindings/regulator/qcom,rpmh-regulator.txt | 207 +++++++++++++++++++++ > .../dt-bindings/regulator/qcom,rpmh-regulator.h | 36 ++++ > 2 files changed, 243 insertions(+) I noticed that "qcom,rpmh-resource-type" is now gone. Not needed anymore? Oh, I see. Stephen said to add it when it's needed. OK, fine. > +=============================== > +Second Level Nodes - Regulators > +=============================== > + > +- qcom,regulator-initial-voltage nit: regulator framework tends to include "microvolt" in the name to make it really obvious in the device tree what the units are. Can you do that too? > +- qcom,drms-mode-threshold-currents Could use microamp in the name of the property too... > + qcom,allowed-drms-modes = > + + RPMH_REGULATOR_MODE_HPM>; > + qcom,drms-mode-threshold-currents = <10000 1000000>; optional nit: to make it match downstream drivers, does it make sense to change this to: <9999 999999> ...so if a driver used to request exactly 10000 mA that it will end up with the same mode (no idea if drivers actually do that). -Doug