Received: by 10.192.165.156 with SMTP id m28csp482066imm; Tue, 17 Apr 2018 13:38:51 -0700 (PDT) X-Google-Smtp-Source: AIpwx48jwhy1K8o35TJ5bo5PTqG98cekGQ7D30SOW7tAZJuzzHcyDsKw5jNQsHMxLZ5+KRN3ih1W X-Received: by 10.99.9.66 with SMTP id 63mr3001999pgj.103.1523997530932; Tue, 17 Apr 2018 13:38:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523997530; cv=none; d=google.com; s=arc-20160816; b=Oo36bB7HzBiTyzpGr89hllmNtn9d10X4L/WPwJbkGv8YPqR5nzsNP1ORU2ugiG4Rjv bN+rqIH5yQTuLMNrz/UjDCBPJ4c0hZr8fnch810CeEgpMnTFwkXb1k0VCaS/efUuFH+E 0wBpo/WMo/jZa1mXJbVfDHBGimKcexRYju0uJgDax4ZY+auNJCGMAU2i92t6mYJn2ELg pQUJOLqg31LvC8ZIPYkW5FYY3oZfj5fLGR6c/WekQV+eO3hlFn5XqPs79rBoigM4ol6s G0gZ6M0CppYuNx9QrsgI9aX72/+HzcMEP4oJntggSS3ejvTMy9Zy2vSeilj+wdVO0SQB qPvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=DSNW4fa1Tr7ekhPeoFTL43WdoJfbGDglBJPlapgQzl4=; b=E4I20iiR7l2LS2qE17qUkRQE5LDeRAIf/u1K51chVxHATdR907YcAu0M7d/FrNnbsN dlqffaK6nk3zMse3zr3cX3b/AUcRPWf0BaxJ/k/edG1kzuqRmaQvfPqIhjvRPkRhKiZg i17Iu1Endp6PXwHFC3gGEx+JeR/Ul9/pifHqUnkGw0VrXKzS+ovyKqreijATzH50xtA7 BCC+t8m7/l0BwsHlhXvgnPmF+M7NxTdMlJ0Qqbet6rLtEkwJDEQ2ikfTSm21cfuIqqDb 9+7Fvu/U+wVPYoteXXsqrFW78pFbMIsElmRb5Vhi65yAnxGLYgagOySTl+kpq5OXXrA7 klRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q6YMTZlJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12-v6si15858662plr.131.2018.04.17.13.38.36; Tue, 17 Apr 2018 13:38:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q6YMTZlJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760AbeDQUhd (ORCPT + 99 others); Tue, 17 Apr 2018 16:37:33 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:46566 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbeDQUhb (ORCPT ); Tue, 17 Apr 2018 16:37:31 -0400 Received: by mail-pl0-f65.google.com with SMTP id 59-v6so12630780plc.13; Tue, 17 Apr 2018 13:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DSNW4fa1Tr7ekhPeoFTL43WdoJfbGDglBJPlapgQzl4=; b=Q6YMTZlJsMQ/AAmCJdlC534MVgSGWYxrDgLezL0N7HxIVebXjiDBnQHnSLxVPDo9D6 TJxojiXFloN/fCq9OGL54vOUb8Zrap+RL+iAAv5GjsPV4Bw7nXImtrHZATxe3sfDrWQk PPyMssZAGCsdbpRalVVHjZ1JLV1SAVgOjEXoM0vokysrBB/rGurZqguF7D9YvpQ/8vTh cBwB85boMicHwKsiYiz8WWqA3HB58BHpZ2kwH3U9+4HWsedMB7wOL4MnvROiHrR3wFLL 826hTXGXecJRyvbmPQDkRb1T4krmRkQIoolblb6r9wnXzmyszIq03t2RcdKM8kSHjYzg rT9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DSNW4fa1Tr7ekhPeoFTL43WdoJfbGDglBJPlapgQzl4=; b=UprVuIwHBXOL2cLjN1Ac5mA6pFkaXfZiLY7j+ju+WguiIS+m/JaNKvP/DWweWvM3tS 90MPtFDRNmelFimOtavCBBTO2U8MCBjw8G9mZJpRvEPWpXNhvGyqRbWMtOmW0wFqaqdB LL4IXKMLXDh7D21AKSG2R5CUkX5E3kcryla2BA52I+vrIs4kqTXeem//+6ALYJPCRDB6 IWInnA8nBl8Nulio26IU43aHl+f510fKHKU6Q7x4ZcHtPv7QOoK8F3OZmQjnuY8ck6ZV wGlhlX1IgWt0VLVii1wK5ClaQsgzS7UK2BGuUQN+Qej/P4OFcHEQBy9C+QctBxZOFx+Y O/kg== X-Gm-Message-State: ALQs6tAB3b5knAhr3RE3438BS9n0zZIbxXjeBiMZEqlXt22LtelJQ6Gt AssPg9XmYMkzldU0jI9xJ5kuBP3IFxo3A2PysF0= X-Received: by 2002:a17:902:43:: with SMTP id 61-v6mr3477681pla.112.1523997450543; Tue, 17 Apr 2018 13:37:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.152.97 with HTTP; Tue, 17 Apr 2018 13:37:10 -0700 (PDT) In-Reply-To: References: <20180417191710.14855-1-longli@linuxonhyperv.com> <20180417191710.14855-2-longli@linuxonhyperv.com> From: Steve French Date: Tue, 17 Apr 2018 15:37:10 -0500 Message-ID: Subject: Re: [Patch v2 2/6] cifs: Allocate validate negotiation request through kmalloc To: Long Li Cc: Parav Pandit , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "stable@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 17, 2018 at 3:11 PM, Long Li via samba-technical wrote: >> Subject: RE: [Patch v2 2/6] cifs: Allocate validate negotiation request through >> kmalloc >> >> >> >> > -----Original Message----- >> > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- >> > owner@vger.kernel.org] On Behalf Of Long Li >> > Sent: Tuesday, April 17, 2018 2:17 PM >> > To: Steve French ; linux-cifs@vger.kernel.org; >> > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org; linux- >> > rdma@vger.kernel.org >> > Cc: longli ; stable@vger.kernel.org >> > Subject: [Patch v2 2/6] cifs: Allocate validate negotiation request >> > through kmalloc >> > >> > From: Long Li >> > >> > The data buffer allocated on the stack can't be DMA'ed, and hence >> > can't send through RDMA via SMB Direct. >> > >> > Fix this by allocating the request on the heap in smb3_validate_negotiate. >> > >> > Fixes: ff1c038addc4f205d5f1ede449426c7d316c0eed "Check SMB3 dialects >> > against downgrade attacks" >> > >> >> Format is: >> Fixes: ff1c038addc4 ("Check SMB3 dialects against downgrade attacks") It >> should be right above Signed-off signature. > > I will fix up and resend this patch. > > How about the rest patches (1, 3-6) in the series? If they don't need any changes, is it okay that I resend this one only? Doesn't matter to me either way - I already merged patch 1 in any case. >> > Changes in v2: >> > Removed duplicated code on freeing buffers on function exit. >> > (Thanks to Parav Pandit ) -- Thanks, Steve