Received: by 10.192.165.156 with SMTP id m28csp623962imm; Tue, 17 Apr 2018 16:43:58 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+mCI0UmxZvoVLF/+8W6NrrYF8VdFwbcFH0ePZJX4PeAXMaTZn8yWaJETqgJu6bUhYHdIqD X-Received: by 10.98.8.133 with SMTP id 5mr3749483pfi.154.1524008637975; Tue, 17 Apr 2018 16:43:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524008637; cv=none; d=google.com; s=arc-20160816; b=iC3aTGVfqJgZU0sN/HFBtdKghRfulQlNCcmF5vcCpY1VNsuCG3vS9Hj781k4G4ObJM AZRI0a5BtgCmkeyB/yCK1Gi1QLNmaFAbhptXqUQms2uD0aWflLq+GUAMEA7x2QoxAIym y9bVgow8S66L1bdwmmiSIWVABCryHUfHrj3BV+/Hchg/FsOPOJ3mjbPaOWG4ahQ7kwk0 fGLmCZ7k63cT4vjp2oWzVdjohUz3vlbEVwsex855pcMuamBkV6EykSw96i+PlBwpVRH2 HTEC7FbvE0JrRmRpL/yW/Q3VDmtSq7ITYxf1tzgey6VNXDpNQ8KNefulf+hwJhhv+8MA +KDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:to:subject :dkim-signature:arc-authentication-results; bh=u5eyHiUJpEhCucgQqfhxtWsx8SGGGPHCc2VkNO8Ads8=; b=AyMgCYIJb9ji1Bna+aA64rHdXQx6c54TnX4Br7kXCbv40yx7iWy6pM9Nq9/R4AJ1zP BWapeIt9Zl15mrx4w/Jp3VwKsQznwBBo//gjWfiVEgb0p8m79Ftypr25wFpsJBAYXWfd Z5hy9k9TZHOgwmQLUEk3TMNgSs20XfdWm5sMQlTYoTfxPWE6rSFlBAyhU6oKHl0e/ivR YJjV0Ji4lydn7h6iBxWMLLZJkQL+xX4NPAnGYlhiK/Ksss/XUK7A4ZrK8WXSaCqLoG90 61QWXQFMxasE7nYWxwGlMXiaLuUMCbmUg5dtTSzRZpVU8BRcjkVNeJ/9vrLOxnx5+Wv6 Y9pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wfpq/uEo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e12si11003103pff.366.2018.04.17.16.43.43; Tue, 17 Apr 2018 16:43:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wfpq/uEo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165AbeDQXmb (ORCPT + 99 others); Tue, 17 Apr 2018 19:42:31 -0400 Received: from mail-qt0-f180.google.com ([209.85.216.180]:34024 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbeDQXm3 (ORCPT ); Tue, 17 Apr 2018 19:42:29 -0400 Received: by mail-qt0-f180.google.com with SMTP id a25so14408814qtm.1; Tue, 17 Apr 2018 16:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u5eyHiUJpEhCucgQqfhxtWsx8SGGGPHCc2VkNO8Ads8=; b=Wfpq/uEoujQZUgbhVaBMu8zywIe+Z19TDqDFzL28I6rGAWdJcHFVk7z5EwOZKGbvS6 YlghmTmI/FJnPksLA51ZVVX364XItbauwLp7VnwMzpRPVrpiuBXpkFhDgohnnCO/Jvdi KGIwlpKJKwB0XHEtkeXC6abbLIZGKVuXnrE5PScKrBnd9esUglZ5B1qN9PA2fMArAd/m WeYeJhNNXX8khWH4PEHkAL6bTbky+/MoC4pPXX/a4sEz6t5iaz821eTSkbuAR67OsffA jbSPyIDL4eUNu86khJnAgYnxpIynnpIcS401dYWEldnAaeCL4SV4SLnhiZaegx0A4mKq bIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=u5eyHiUJpEhCucgQqfhxtWsx8SGGGPHCc2VkNO8Ads8=; b=h6bEcRu63fh5365KXF08HQW12fbspxR2xKdADQP4FBQNfG+bcxokml/ZVwHcG2BA6y M+6CmAJEssHMrkKWXO2NWmyhB0vCoVGHk8GJpImuwzkvEGHS0bK0AqH55vx5ltG8uYhF iQ0pw7YieaXe2+92yGJcvfKnV6EcFbRytKuP14yJ5InsLWi+SREv8LU3ixnqFZpmGINj l8IAxc9HLh0uRgWJNBuRdScDeaXi9Bb4Tvo+PWQ/LEFSslZ78r92YFkKT1ZQFwMe+7+D inHcoAWBAvuq/gnqxiaX+PyqY9K4LXV7fAWAbIsPrGu8W0qga5x0Hlvf5MRhW5vzaqLG 9egw== X-Gm-Message-State: ALQs6tA1ptznOYDJX+q+B2MKdL9Io9Z0bXodIiWkks2QswAETM/uJ7Mk hYgRetqbLXPSC+nFjIaIjjI= X-Received: by 10.200.49.9 with SMTP id g9mr697706qtb.399.1524008548802; Tue, 17 Apr 2018 16:42:28 -0700 (PDT) Received: from [10.69.41.93] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id z85sm1845350qkb.63.2018.04.17.16.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Apr 2018 16:42:27 -0700 (PDT) Subject: Re: fix for bnx2x panic during ethtool reporting To: Sebastian Kuzminsky , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ariel.elior@cavium.com, everest-linux-l2@cavium.com References: From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <7747689b-6774-ca84-e0d5-ffd9b0d59e1b@gmail.com> Date: Tue, 17 Apr 2018 16:42:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +netdev, Ariel, On 04/17/2018 10:21 AM, Sebastian Kuzminsky wrote: > "ethtool -i" on a bnx2x interface causes kernel panic when the > firmware version is longer than expected. The attached patch fixes > the problem by simplifying the string handling in bnx2x_fill_fw_str(). > It applies cleanly to 4.14 and 4.17-rc1. If you want to have a chance of getting your patch included, your should make sure you copy the driver maintainers and the network mailinglist, doing that. -- Florian