Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neilb@suse.com>
To:     James Simmons <jsimmons@infradead.org>
Date:   Wed, 18 Apr 2018 12:32:01 +1000
Cc:     Oleg Drokin <oleg.drokin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 2/6] staging: lustre: remove libcfs/linux/libcfs.h
In-Reply-To: <alpine.LFD.2.21.1804160431550.16188@casper.infradead.org>
References: <152383910760.23409.2327082725637657049.stgit@noble> <152383935734.23409.11654775387996961581.stgit@noble> <alpine.LFD.2.21.1804160431550.16188@casper.infradead.org>
Message-ID: <874lk9s0ri.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 16 2018, James Simmons wrote:

>> This include file is only included in one place,
>> and only contains a list of other include directives.
>> So just move all those to the place where this file
>> is included, and discard the file.
>>=20
>> One include directive uses a local name ("linux-cpu.h"), so
>> that needs to be given a proper path.
>>=20
>> Probably many of these should be remove from here, and moved to
>> just the files that need them.
>
> Nak. Dumping all the extra headers from linux/libcfs.h to libcfs.h is
> the wrong approach. The one header, libcfs.h, to be the only header
> in all lustre files is the wrong approach. I have been looking to
> unroll that mess. I have patch that I need to polish you that I can
> submit.

I think we both have the same goal - maybe just different paths to get
there.  If you have something nearly ready to submit, I'm happy to wait
for it, then proceed on top of it.

Thanks,
NeilBrown

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlrWriEACgkQOeye3VZi
gbmYXA//SzzRCt5Akx9xfIAKtqygbbQw2MoCPyG+Ad1CPAj5qx2trBlIVuEOAYm9
5541vj9pi5PRSNg7m9VJBQ3tAEV8vcl9Uvi4lYUAnbDulgagTs7za5DCkd20Kcpb
xuNM8OKFSCprN1kXPaUorwzjGAxdzVkywb7DR4uX+zUy/7qLgJpbKnDFs11ATCMB
kt8Ug30GPXEE71nt/AciVolMcJKWnyEsUTCo1cqdKuG3XlWR1eDpRxwdS/6N6xQT
qJAzO2Kjb//dFVhmGILSM3L5k3AsNG/v07riJsjtZBtPROkKbeTnW6/iCRz5x0Yp
5HqDfrKU7k4ehQeTUGoTYPL1JFqQuEOyT7jq6FmK4PvM5AkugpuMRfGj2oLi5Ie3
TyEw20NYKPzX1H3m0nTGKdUKb/6lgEahPfEkONNPKtnCEbqZOzgLop6ydy3kPxca
jqmmmDkNB7HSrRxg+m6iW3sgT4bU2ZUQkSVs34NqE4jo7/2mxuW9AC6p/IwSpmPB
gWbCw/SIFzWBkNwyN8fn0PSxkLIiRmBBZiKTSo1xIaXCdBuZEXzlzG56SKUcvBId
+tbBZ1bo9P6F0i9LkpmFxyiv8623R04PI7kONgH4ln/zUQHwOwbbx6G8HoHkLUt7
gm9SZy5fCASzyKjwbNJqUnBvRlPqI07EtqUZvXO5vCPzq1kSw+k=
=cvrd
-----END PGP SIGNATURE-----
--=-=-=--