Received: by 10.192.165.156 with SMTP id m28csp871802imm; Tue, 17 Apr 2018 23:06:19 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/AAH4rEA6SICjxJR2PGlUbCfCyD8KQZ3KfTOec3FIGpxfEYdRkbTeE5ukPKGThzEG8XOIu X-Received: by 10.98.109.66 with SMTP id i63mr764456pfc.233.1524031579400; Tue, 17 Apr 2018 23:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524031579; cv=none; d=google.com; s=arc-20160816; b=BiVXYfSWhv9I4mOO6YL13QppZADdHgQA5wfzBP/qJwEuc6RRQbFMQVxf0yMr9hSkrT pydrVlYgiCgjO9WRjgBv4KKncsi8CXm34vF2NzktL8ClTGJQE55fENYRRyG4IJO6qKi6 +RByWha1FA6fRhuV8qoHOMWaTusbyvbumfCk8ufo2IJDfXGQS2czWgUcknzMzrIkUJFa AHh9hzSdkCqZTRqsbUQ94rZtWsmig2akJ3m3smSqRzVlOqzKp022j1RHblZWqKWzryON FRqaua8pM+ZglAPRGvg/beCLjJ1o7BeA4v3WTp0fuhhpXpFkmL/yqVwXKVH9s9qOoP4+ ZLcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=2aJ/GcRcfTmPXPXj+ZXlf9J4NwDcrEeW2IJT3A25cI4=; b=yBsoG55b9i5nEMBiqmDDyeeKkNl9ucrM0kGQeR/vNXmlX/MIG9pwHvJHB7HUwwTvnc ZsZguYNHed8X3dtbdJ791xZp+ufbBrcE4FUIGBVrgA0L3iDMBrnTaZRUIW9hMg/e52/r qq9dy/uiEFb/lgjyhEk2rtTH+Gpofe1lHeuz0CozvKRKrmBh28B5eF37bwA6vZQaT3EN m5d6Gwy+SDv4pKSVbYO6YE+cab+/tn58ZakNBavyD+txmK3UI3a3jgn8vGxf2qAF/IZ9 eSfKhe3Sg2E4sYK+qNqUrViDOt5JLN/8SsEhCpKGGsqs0zInhuhaMJzRR3bhjBSiFR4Q eo+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14-v6si643399plk.535.2018.04.17.23.05.57; Tue, 17 Apr 2018 23:06:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbeDRGEo (ORCPT + 99 others); Wed, 18 Apr 2018 02:04:44 -0400 Received: from mga14.intel.com ([192.55.52.115]:51538 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbeDRGEm (ORCPT ); Wed, 18 Apr 2018 02:04:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 23:04:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="32807767" Received: from mylly.fi.intel.com (HELO [10.237.72.58]) ([10.237.72.58]) by fmsmga007.fm.intel.com with ESMTP; 17 Apr 2018 23:04:39 -0700 Subject: Re: [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static To: kbuild test robot Cc: kbuild-all@01.org, linux-spi@vger.kernel.org, Mark Brown , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <201804180300.Pn9JAJQ2%fengguang.wu@intel.com> <20180417195323.GA69680@ivb43> From: Jarkko Nikula Message-ID: <22cf611b-6a88-ec72-bb3c-51f8b62a8019@linux.intel.com> Date: Wed, 18 Apr 2018 09:04:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180417195323.GA69680@ivb43> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/17/18 22:53, kbuild test robot wrote: > > Fixes: d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop") > Signed-off-by: Fengguang Wu > --- > spi-pxa2xx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c > index c852ea5..40f1346 100644 > --- a/drivers/spi/spi-pxa2xx.c > +++ b/drivers/spi/spi-pxa2xx.c > @@ -911,9 +911,9 @@ static bool pxa2xx_spi_can_dma(struct spi_controller *master, > xfer->len >= chip->dma_burst_size; > } > > -int pxa2xx_spi_transfer_one(struct spi_controller *master, > - struct spi_device *spi, > - struct spi_transfer *transfer) > +static int pxa2xx_spi_transfer_one(struct spi_controller *master, > + struct spi_device *spi, > + struct spi_transfer *transfer) Thanks Fengguang. I don't understand how I managed to drop "static" while doing manual s/pump_transfers/pxa2xx_spi_transfer_one/ :-) Reviewed-by: Jarkko Nikula