Received: by 10.192.165.156 with SMTP id m28csp925326imm; Wed, 18 Apr 2018 00:24:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/ZXL4+XWo2RJiSqe8XW1yIMPDEPOzNoue+LucK5DNIwJJieCB/j/dqIuxkhDFWn80Tli4N X-Received: by 10.167.131.203 with SMTP id j11mr976945pfn.101.1524036242014; Wed, 18 Apr 2018 00:24:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524036241; cv=none; d=google.com; s=arc-20160816; b=SzcxCb2V2YDdGOj6QtrhXTFOaM1QgBqOabTn8NZ3RM8UFJTChvkCGY6felLEbbKfzF TmeVSLCqhgMkMSxkwv5FTOcrJUDKH3vn3v8+Z48sHniCCpf8lovepm67Yt0zoHK1usqb /jgYbsdrcN5GvONKkW4XomhiOINlXXq7bbCDSGdxYSqwiY5HRPMoD5CtSv+YQ3HLNggH TzhwjKiiRB9+KjIvayISGVuLDBuEgfYEWIgk4XOnixYYoa6kfA8HAfexptuTXbIQJ+aV 3yNksPpBieRCM6ushCTV+Ny0ZOJnRWNhy6sPduFalxWj4C9kOCZHDPBQUBQGGlE8LYIo 3Uxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :organization:from:references:cc:to:subject :arc-authentication-results; bh=CnB0kYK4ce65Ua1g2CqDM6yWyWyGUyWV997wLsV+TU0=; b=SI1gviCWzb6eUQ9SdDIN4OZyw9igpi3WpOrkXN+dr5eabAqeOB7CkBH6eVqSRNj0Yy vcHO64GErUjbot006LYXTEgZ5tQB0/Q/gkuzXu/SlldZa2sKkraJTmzZq8p+w1HWg2aJ dZmtgf2G7paBQvSkedybUM7Q/lS/j1/iyOCxjerRgv7j4RWSRIJ30uZtCCWzWjfuJg35 8HtiKGBoEjpjjMBh4geGHfLEoG06WvD0zbdWvSAq52AIK5Ufigl0A8syoDYpICL7w/Wv iqxtl6PBoco9PA0GNLXOpPtPT2SyGYQzA+jDwEkfJ9lBOuLKnw7Zb3VXq4op/PQEj65l G+Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si624464pfi.113.2018.04.18.00.23.48; Wed, 18 Apr 2018 00:24:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089AbeDRHWl (ORCPT + 99 others); Wed, 18 Apr 2018 03:22:41 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:41728 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752705AbeDRHWj (ORCPT ); Wed, 18 Apr 2018 03:22:39 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3I7LfKA135479 for ; Wed, 18 Apr 2018 03:22:39 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hdwnfhj5a-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Wed, 18 Apr 2018 03:22:39 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Apr 2018 08:22:36 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 18 Apr 2018 08:22:32 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3I7MWDV8847762; Wed, 18 Apr 2018 07:22:32 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 46DF1A4057; Wed, 18 Apr 2018 08:14:40 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1924A4055; Wed, 18 Apr 2018 08:14:39 +0100 (BST) Received: from oc3784624756.ibm.com (unknown [9.152.212.90]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 18 Apr 2018 08:14:39 +0100 (BST) Subject: Re: [PATCH v3] module: Fix display of wrong module .text address To: "Tobin C. Harding" Cc: jeyu@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, borntraeger@de.ibm.com, schwidefsky@de.ibm.com, brueckner@linux.vnet.ibm.com, heiko.carstens@de.ibm.com, peterz@infradead.org, acme@kernel.org, keescook@chromium.org, stable@vger.kernel.org References: <20180418071436.21392-1-tmricht@linux.ibm.com> <20180418071724.GA6892@eros> From: Thomas-Mich Richter Organization: IBM LTC Date: Wed, 18 Apr 2018 09:22:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180418071724.GA6892@eros> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18041807-0012-0000-0000-000005CC1A0D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041807-0013-0000-0000-000019486957 Message-Id: <72461e74-2229-bf33-cbce-9a016bef4df9@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-18_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804180068 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18/2018 09:17 AM, Tobin C. Harding wrote: > On Wed, Apr 18, 2018 at 09:14:36AM +0200, Thomas Richter wrote: >> Reading file /proc/modules shows the correct address: >> [root@s35lp76 ~]# cat /proc/modules | egrep '^qeth_l2' >> qeth_l2 94208 1 - Live 0x000003ff80401000 >> >> and reading file /sys/module/qeth_l2/sections/.text >> [root@s35lp76 ~]# cat /sys/module/qeth_l2/sections/.text >> 0x0000000018ea8363 >> displays a random address. >> >> This breaks the perf tool which uses this address on s390 >> to calculate start of .text section in memory. >> >> Fix this by printing the correct (unhashed) address. >> >> Thanks to Jessica Yu for helping on this. >> >> Fixes: ef0010a30935 ("vsprintf: don't use 'restricted_pointer()' when not restricting") >> Cc: # v4.15+ >> Suggested-by: Linus Torvalds >> Signed-off-by: Thomas Richter >> Cc: Jessica Yu >> --- > > What's changed in each version please? > > > thanks, > Tobin. > V2: Changed sprintf format string from %#lx to 0x%px (suggested by Kees Cook). V3: Changed sprintf agrument from 0 to NULL to avoid sparse warning. -- Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294