Received: by 10.192.165.156 with SMTP id m28csp1056350imm; Wed, 18 Apr 2018 03:20:01 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+pfI8QSrLPoOcEv4jhKSKMmerEPRQEIl8SxAvwLkQRleS0xj+1yE+oWLe2iWMfM1X7zrSu X-Received: by 10.99.113.84 with SMTP id b20mr1307324pgn.426.1524046801297; Wed, 18 Apr 2018 03:20:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524046801; cv=none; d=google.com; s=arc-20160816; b=tTgf6feTerzrAQEWgF8I6WwqgkzWF8Eld2dWiVtP4jw4/N/VTfJ+XSFm0wstiv3hbf kvcsuafjdpThiDdS3balVR6UhAzZiIKpFDCQM7kJSPBNOghoFddhATAq0j5/+hMyZ+9N O37TeesL+bhs2W2AxN1ce3Rxb8cHFjFOUJZHoPra0Vk74EWAUApcJpnfX3bpWkC5+yJz 1JD0fjmUGlSlkwgUEMv/r4HiBy5/R3dGzVcje2M9kfx7zzn7z6/MwyWat4CGbtlKu82H h+oc+vCRdiqgJi8neEUvaqjbckbI707na4dYv2lqJ9SWsJzykOLsyfFvUp9inkggffJb 0R3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=lw7cTTDVEiS+bZtOry4c4FN46oyDsrLqpAFvlXaOOYA=; b=fyvXRykSMr+r8Vo2ieKnIOC+Bvv3hjDUq6rY03a4JxIUtSUl69SQ6isHeX/z8zQs7i 2uRT3mqKrSi2PK7uTQUVpv5eubenAWhevCCHEP2g9y1TW81L/LyYHJcjPwtJ8D+Mz9n0 9n+ew+aZIf3aGM0kGUCjzqrvHSZOe8pn61zvQOQCFiqS0OttWPRlOccUDEA09Ksfp/Yp xSqickq/nx9oUIGYadVekiVU0QoZGL0YMNkiDbzANymCxkGw8578aUsrbNUkBKWVG4gu tbVvKEJgs8yyMeBs9+TLaBCI8RACacU0eJy9ZiPO5crcZom8Fc+bwQJvYEvHk4yp5t7N kh+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si863710pff.107.2018.04.18.03.19.45; Wed, 18 Apr 2018 03:20:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002AbeDRKSi (ORCPT + 99 others); Wed, 18 Apr 2018 06:18:38 -0400 Received: from verein.lst.de ([213.95.11.211]:59749 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbeDRKSf (ORCPT ); Wed, 18 Apr 2018 06:18:35 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id BBF186FA92; Wed, 18 Apr 2018 12:19:13 +0200 (CEST) Date: Wed, 18 Apr 2018 12:19:13 +0200 From: Christoph Hellwig To: Jianchao Wang Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current_path Message-ID: <20180418101913.GB15833@lst.de> References: <1524036767-3701-1-git-send-email-jianchao.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524036767-3701-1-git-send-email-jianchao.w.wang@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 18, 2018 at 03:32:47PM +0800, Jianchao Wang wrote: > With lockdep enabled, when trigger nvme_remove, suspicious RCU > usage warning will be printed out. > Fix it with adding srcu_read_lock/unlock in it. Looks fine, Reviewed-by: Christoph Hellwig