Received: by 10.192.165.156 with SMTP id m28csp1345500imm; Wed, 18 Apr 2018 08:14:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx49/tR+OBVW47BWLQa6hbaD8uoMHonuJG9GQlCS6e4LKaiwuj328TNvtKP9tU80ayfgzTDb7 X-Received: by 2002:a17:902:8f96:: with SMTP id z22-v6mr2446448plo.200.1524064481140; Wed, 18 Apr 2018 08:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524064481; cv=none; d=google.com; s=arc-20160816; b=Wh2wh4SO6jeaZVDsrtwIZqz5bZgoq0s2B3naZ3FLLoSdPTcP3LHxuEICVTUJKIbTZD dLEc6efUxi/HL2AGuPJ/wFMRQ/CQIlcCm81j8OegW6KfFQbBrxU82mYxKZgINGYMGzvi 58o1MlTulsbkL6G+4tOimCph/3uD4q+pwLPHWq8XG0z9bjdtaPyFxkJ8aKUcESrqzlEQ huw1wfrLyQx+fCn7fg+GMEHbIHmT9fzl/LxV9xwuRi6Pb+eQCDYE92Q4BsfGlNgDHpq9 BoHq8cQd2jX4bEQRgwiHyXpaOSimY24NV0IlNJpEMehu3AuTjIcTFwEVCIHKCNmNkquk syVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=h+35txiT7bi06DgvBjrAzIuDSPZ3jEhS9NG4Z+CTXcQ=; b=BsSZTBWMDQLAx09bnJIJDC95IgRBV3zUXFLEueBnySb+saPpw7GaYogMOgu2FKGlhx zvTrXfJ+bPSXuANzykAnwRfVFfTUhc3gkyw857/wIsUfZH+TcAF8Ywwwg7e8jvzdjlCG rPaFEvIe913x4lTillKQoFxt2ybX9ajYaGVKKcsSnze8woO0xsyHHNBw6z6FAdIVIJFR 8CyClQ6NLsg45JTIs+MvJzH0j0H/b01zlroxeSxxE5sD4gauGFpQg09PSTitWDlz37ys m9CVf8/7Zp8M0loj2I4vXp47ZMLExerjPY8s9qfdJmtmbrru/yYHcX5OVsizjINGioYD i7lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o4si1207024pgd.125.2018.04.18.08.14.24; Wed, 18 Apr 2018 08:14:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbeDRPLK (ORCPT + 99 others); Wed, 18 Apr 2018 11:11:10 -0400 Received: from resqmta-ch2-06v.sys.comcast.net ([69.252.207.38]:54486 "EHLO resqmta-ch2-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752744AbeDRPLJ (ORCPT ); Wed, 18 Apr 2018 11:11:09 -0400 Received: from resomta-ch2-03v.sys.comcast.net ([69.252.207.99]) by resqmta-ch2-06v.sys.comcast.net with ESMTP id 8ojkftsIqsRj38ojkf80RF; Wed, 18 Apr 2018 15:11:08 +0000 Received: from gentwo.org ([98.222.162.64]) by resomta-ch2-03v.sys.comcast.net with SMTP id 8ojifTAdKmGmd8ojjfp1Tt; Wed, 18 Apr 2018 15:11:08 +0000 Received: by gentwo.org (Postfix, from userid 1001) id D041D1161663; Wed, 18 Apr 2018 10:11:06 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id CDAE1116047F; Wed, 18 Apr 2018 10:11:06 -0500 (CDT) Date: Wed, 18 Apr 2018 10:11:06 -0500 (CDT) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Mikulas Patocka cc: Vlastimil Babka , Mike Snitzer , Matthew Wilcox , Pekka Enberg , linux-mm@kvack.org, dm-devel@redhat.com, David Rientjes , Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfJzpnjc7gtd8bV9Q1GjJ2pMyybECbTKSADxaiiGP6dBXum4RLZl2i7IzbqDb3n4MvUHdovXteN5KV80xMhE/0xMF3QtFBny4DDxjhYJhU3K0U4UjOyDf fNIfwcbfEgEcwxtqMWEGzMTEciRkk6gD7K9EtYsxuDygUM05WUgXc/VhbKY4Sscb4RG5itMiYl99l/kG+1HgIgK4uCtoj9NOf0RK3j8+PY1vxNlHlE39Cwer 3wyp9hr9BumvgUvGvuJo6bNQvGXOGh/+zzxueXTG9D+NntiEP/cH+Ea5cqCk0JdHMAiYBGD329DuH2n47ZBfcuWd1w6FysTBwUvrph1EFEPziLCUW1QnvvAy qe6k91azntiTvkjlOI/H+s4su9ZeqfpzoMXnKMFh8Age7pfy/pEomQ2EmzBKe0aD49xkL8nux3KOFJ8MB2ABKx592mGXgou1cXwuHHgpL559jNt4II4jhn+y s3nFw9O3YWElpGZw Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Apr 2018, Mikulas Patocka wrote: > No, this would hit NULL pointer dereference if page is NULL and > __GFP_NORETRY is set. You want this: You are right Acked-by: Christoph Lameter