Received: by 10.192.165.156 with SMTP id m28csp1382357imm; Wed, 18 Apr 2018 08:48:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/hOaBxzW/sgvOeS40ZlHohzgFqGf8bcdoFUXdUQS83utO8g9dL1cfCYsYf2PBA1ACJfN7j X-Received: by 2002:a17:902:9a0b:: with SMTP id v11-v6mr2574391plp.387.1524066510000; Wed, 18 Apr 2018 08:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524066509; cv=none; d=google.com; s=arc-20160816; b=tD96fe0ZfuGXVk7af6QUoJVW5AGs4+0i80TO75RfLBiDqyC7kApZ8l0kC4SQoLTrV3 g2+osrlydvGECCpBJX5ztyndxrotD3lmCxXdEtqLWjIIp3Ufp9cqE45KcmSaz2mcYlpN Yuye4dBOYilcT3ApaK7olmSoNppi47Ea7yUfnlXJXtGvNpCSQFd2TT3Kla5jD7fW49cC 7gmz6Q71jq3P4oNzfiCRS4aKzK8nNZ4wk7oAzUZpKNFHKmxj7gEU1GvZentxrBrcoetl YsECmrwxOcXYlYcUbdz1IfcPQSRGAj6/1gl1PS+3n91qjcwR4l2WGu2bBB8Km3ETMoNW Tkzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dmarc-filter:arc-authentication-results; bh=3TNUzPAksRwe94Er8s39pmNbdCzeT+taILtNYyzdlqM=; b=PLIMdR8DVGHZRbwRvuyTac6sXDg2FuFvbmlkfq0ir4/FDXFqwAk8oMScG943ob5Onh dFTbrv58gOczS6r77ZAn5/l1RgWxp/ddCmUlFVrAbQsjgzrv2VmERWW1glHh/yBhFFdQ Qr67sERzyM0sdGK+BBF5uvyDwp9GRthuxmgkKSeqX2EBUKzeJs6hRirkPiDLlVuu+p4V K2+KvooyEqVhblpFSe8QnrifFlug3M3Ax/vjAq6cvFcZAwsft9tLv3Qr6KbS0AfLiE1q vlBqkzhPX4szzsrwZCn0oJjPI2N4MqSAAXRxt/ivpt45MsOWrn79Zs1Zr2eWG9CZW6qx meWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si780074pfg.137.2018.04.18.08.48.15; Wed, 18 Apr 2018 08:48:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbeDRPrK convert rfc822-to-8bit (ORCPT + 99 others); Wed, 18 Apr 2018 11:47:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:40338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639AbeDRPrI (ORCPT ); Wed, 18 Apr 2018 11:47:08 -0400 Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A1F32175C; Wed, 18 Apr 2018 15:47:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A1F32175C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org Received: by mail-wr0-f178.google.com with SMTP id q6-v6so6139386wrd.6; Wed, 18 Apr 2018 08:47:07 -0700 (PDT) X-Gm-Message-State: ALQs6tBlq68i4841is4Zc39P2k8X1QB32MyNVxzxx6ssCQHuxH1ZC3pv 0vPQhhIGcw2wmCyY97CsSi3pToSja2SKVUxBGFg= X-Received: by 10.28.0.4 with SMTP id 4mr2050624wma.118.1524066425807; Wed, 18 Apr 2018 08:47:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.199.7 with HTTP; Wed, 18 Apr 2018 08:47:04 -0700 (PDT) In-Reply-To: References: <1523893966-8884-1-git-send-email-pawel.mikolaj.chmiel@gmail.com> <1523893966-8884-2-git-send-email-pawel.mikolaj.chmiel@gmail.com> From: Krzysztof Kozlowski Date: Wed, 18 Apr 2018 17:47:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] pinctrl/samsung: Correct EINTG banks order To: Tomasz Figa Cc: =?UTF-8?Q?Pawe=C5=82_Chmiel?= , Sylwester Nawrocki , "linus.walleij@linaro.org" , Kukjin Kim , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-gpio@vger.kernel.org, linux-kernel , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 17, 2018 at 4:12 AM, Tomasz Figa wrote: > 2018-04-17 0:52 GMT+09:00 Paweł Chmiel : >> All banks with GPIO interrupts should be at beginning >> of bank array and without any other types of banks between them. >> This order is expected by exynos_eint_gpio_irq, when doing >> interrupt group to bank translation. >> Otherwise, kernel NULL pointer dereference would happen >> when trying to handle interrupt, due to wrong bank being looked up. >> Observed on s5pv210, when trying to handle gpj0 interrupt, >> where kernel was mapping it to gpi bank. >> >> Cc: stable@vger.kernel.org >> Fixes: 023e06dfa6882f500b9c86fd61f0b1913aa07f36 ("pinctrl: exynos: add exynos5410 SoC specific data") >> Fixes: 608a26a7bc04a39cfd7041f31ca2b2100113d14e ("pinctrl: Add s5pv210 support to pinctrl-exynos) Use short SHA (for example: git config --global core.abbrev 12; git config --global pretty.fixes 'Fixes: %h ("%s")' ; git config --global alias.sf 'show --pretty=fixes' ; git sf COMMIT). The subject prefix should be "pinctrl: samsung:" (git log --oneline -- drivers/pinctrl/samsung/). I fixed this, re-wrapped commit for 72-column and applied to my tree. Linus, I'll send them to you in pull request for next release cycle. Best regards, Krzysztof