Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 18 Apr 2018 13:40:43 -0400
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Colin King <colin.king@canonical.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: make several const arrays static, shrinks object
 size
Message-ID: <20180418174043.GA15833@sophia>
References: <20180418172634.14734-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180418172634.14734-1-colin.king@canonical.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 18, 2018 at 06:26:34PM +0100, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Don't populate the const read-only arrays 'port' on the stack but
>instead make them static. Makes the object code smaller:
>
>Before:
>  text    data     bss     dec    hex filename
>  8542    4088     672   13302   33f6 drivers/gpio/gpio-gpio-mm.o
> 10959    4952     832   16743   4167 drivers/gpio/gpio-104-dio-48e.o
>  9022    5064    1408   15494   3c86 drivers/gpio/gpio-104-idi-48.o
>
>After:
>  text    data     bss     dec    hex filename
>  8372    4144     672   13188   3384 drivers/gpio/gpio-gpio-mm.o
> 10790    5008     832   16630   40f6 drivers/gpio/gpio-104-dio-48e.o
>  8853    5152    1408   15413   3c35 linux/drivers/gpio/gpio-104-idi-48.o
>
>(gcc version 7.2.0 x86_64)
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>